[Due for payment 2026-08-19] Spend - "Violations" is not shown in column list when it is a table column

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.4.52-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #97067
Email or phone of affected tester (no customers): sjodnijsodnjosjoijos@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Search

Action Performed:

Precondition:

Enable Rules.
Invite user B to the workspace.
User B submits an expense without category in the invited workspace.
Perform the steps below as owner:

Go to staging.new.expensify.com
Go to Spend > Violations by submitter.
Click Submitted and change it to This month.
Expand the group.
Click Display > Edit columns.

Expected Result:

"Violations" should be shown in column list because it is a table column.

Actual Result:

"Violations" is not shown in column list when it is a table column.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7230498_1786396392819.10.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7230498

Issue Owner

Current Issue Owner: @mallenexpensify

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/ed7efa7df2acfb6e31d296865645c4d2b5fa587d18be100bdacf191793a117e7

@neil-marcellini

@neil-marcellini recently merged #97067, but they are OOO right now, so I'll auto-assign someone else.

@Valforte

Triggered auto assignment to @Valforte (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@neil-marcellini

@neil-marcellini @cretadn22 you have been assigned to this deploy blocker because you reviewed the offending PR: #97067

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Deploy Blocker Analysis

Root cause: #97067 (the PR named in the report) introduced the new Violations transaction column. It auto-renders the column in the table whenever a transaction has submitted violations, but registered the column in COLUMN_AVAILABILITY with search: false, which deliberately excludes it from the Edit columns picker. So the column shows in the table but can't be toggled — exactly the reported inconsistency. Confidence: High (staging-only; brand-new feature).

Recommended resolution: roll forward, not revert. Reverting #97067 would drop the entire "expanding groups / Violations by submitter" feature to fix a minor picker inconsistency. The targeted fix is a one-line decision in COLUMN_AVAILABILITY. neil-marcellini is OOO, so the PR author nkdengineer should confirm the intended behavior:

If Violations should be user-toggleable in Search → set search: true on the VIOLATIONS entry (src/CONST/index.ts:6999) and update the guard test tests/unit/Search/ColumnAvailabilityTest.ts.
If auto-inject-only is intended → suppress rendering Violations as a standalone toggleable column so table and picker agree.

Given it's a cosmetic edge-case in a staging-only feature (the violations data still displays correctly), this is also a reasonable demote candidate.

Evidence & investigation details

Picker excludes the column — the Edit-columns list filters COLUMN_AVAILABILITY to only entries flagged search: true, dropping VIOLATIONS:

src/CONST/index.ts:6999-7003 — new VIOLATIONS availability entry: { search: false, reportView: false }
src/CONST/index.ts:7102-7109 — TYPE_CUSTOM_COLUMNS.EXPENSE derivation (filters on search)
src/pages/Search/SearchColumnsPage.tsx:23 → getCustomColumns(queryType)
src/libs/SearchUIUtils.ts:4449-4452 — returns Object.values(TYPE_CUSTOM_COLUMNS.EXPENSE)

Table renders the column anyway — data-driven, independent of the picker:

src/libs/SearchUIUtils.ts:6414-6419 — sets columns[VIOLATIONS] = true when submitted violations exist
src/libs/SearchUIUtils.ts:6535-6543 — injects VIOLATIONS into the returned column set
Render pieces added by the same PR: src/components/Search/SearchTableHeader.tsx (header) and src/components/TransactionItemRow/TransactionItemRowWide.tsx (case TABLE_COLUMNS.VIOLATIONS)

Verification: The VIOLATIONS: { search: false, reportView: false } block is present in the gh pr diff 97067 diff alongside TABLE_COLUMNS.VIOLATIONS: 'violations' and the render/inject logic above. No other PR in the current StagingDeployCash touches this code path. Merge date (2026-08-07) aligns with the 9.4.52-0 staging build.

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/98204) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

@cretadn22

@cretadn22

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP stag] Revert "[Insights: Violations]: Expanding group & Suggested search" #98345

If no regressions arise, payment will be issued on 2026-08-19. 🎊

@cretadn22

@cretadn22 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Awaiting Payment)

@cretadn22

Payment Summary

Resolving PRs:

[CP stag] Revert "[Insights: Violations]: Expanding group & Suggested search" #98345
Reviewer: @cretadn22 owed $250 via NewDot

BugZero Checklist (@mallenexpensify)

I have confirmed assignees, roles, and Upwork contracts look correct
I have paid out Upwork contracts / manual NewDot requests

@MelvinBot

@MelvinBot why is @cretadn22 listed in the payment summary above? They're not assigned as a reviewer or assignee to the PR

I'm assuming no one is due payment here, comment if you disagree.

You're right — cretadn22 isn't owed payment here.

The payment summary is generated from this issue's assignees and their roles, not from who reviewed the resolving PR. cretadn22 is an assignee on this issue (assignees: Valforte, mallenexpensify, neil-marcellini, cretadn22) in the "Reviewer" role. They landed there via the deploy-blocker auto-assignment on 2026-08-10 — "you have been assigned to this deploy blocker because you reviewed the offending PR: #97067" — i.e. they reviewed the PR that caused the blocker, not the fix.

The resolving PR #98345 was a straight revert of #97067, authored by jasperhuangg and approved by Valforte. cretadn22 didn't review or author it, so there's no reviewer work on the fix to pay out.

So the $250 "Reviewer" line is just an artifact of the deploy-blocker auto-assignment carrying the offending-PR reviewer into the payment summary. No payment is due to cretadn22 for this one.

Deploy Blocker #100114 was identified to be related to the PR #98391 that attempted to fix this issue.

Deploy Blocker #100122 was identified to be related to the PR #98391 that attempted to fix this issue.

Deploy Blocker #100139 was identified to be related to the PR #98391 that attempted to fix this issue.

Navigation Menu

Repository navigation

[Due for payment 2026-08-19] Spend - "Violations" is not shown in column list when it is a table column #98204

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Deploy Blocker Analysis

11 remaining items

Payment Summary

BugZero Checklist (@mallenexpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2026-08-19] Spend - "Violations" is not shown in column list when it is a table column #98204

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

applause-bot commented on Aug 10, 2026

melvin-bot commented on Aug 10, 2026

melvin-bot commented on Aug 10, 2026

melvin-bot commented on Aug 10, 2026

melvin-bot commented on Aug 10, 2026

github-actions commented on Aug 10, 2026

MelvinBot commented on Aug 10, 2026

Deploy Blocker Analysis

11 remaining items

melvin-bot commented on Aug 12, 2026

melvin-bot commented on Aug 14, 2026

melvin-bot commented on Aug 18, 2026

melvin-bot commented on Aug 18, 2026

Payment Summary

BugZero Checklist (@mallenexpensify)

mallenexpensify commented on Aug 20, 2026

MelvinBot commented on Aug 20, 2026

mitarachim commented on Sep 2, 2026

mitarachim commented on Sep 2, 2026

mitarachim commented on Sep 2, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions