Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: v9.4.52-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/68502605/folder/54018371/109584594/1646242938?sort=%2Bidentifier
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 10 / Chrome, Honor x6b/ Android 16
App Component: Other
Action Performed:
- Log into NewDot
- Navigate to Settings > Wallet and click on "Import transactions"
- Click on the Card display name field, input a valid name, and save the input
- Toggle off "Transactions are reimbursable"
- Click the "Next" button container and upload the "CSV file to upload"
- Click on "Import"
- Click directly on the newly created transaction card item row
- Verify that Mark transactions as reimbursable is toggle off
Result: Mark transactions as reimbursable is enabled - Close and reopen RHP
Result: Mark transactions as reimbursable is enabled - Click on "View transactions"
- Return to the Card imported row
- Click to open RHP
Result: Mark transactions as reimbursable is disabled.
Expected Result:
When Transactions are reimbursable is disabled during card import, the Mark transactions as reimbursable toggle should remain disabled
Actual Result:
After importing the card with Transactions are reimbursable disabled, the Mark transactions as reimbursable toggle in the card details is enabled. After navigating to imported transactions and back to the imported card and reopening it, the Mark transactions as reimbursable toggle is displayed as disabled.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7230489_1786395973629.bandicam_2026-08-10_16-01-30-873.mp4
Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7230489
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022087028253854326070
- Upwork Job ID: 2087028253854326070
- Last Price Increase: 2026-08-11
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
applause-bot commentedon Aug 11, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a8cc9e707ec91c6443f51b18e69700efe60deb701b9d4e3271f59ed8badef1b6
[-]Personal Card-Mark transactions as reimbursable toggle show enabled after disable it in import[/-][+]Personal Card - Mark transactions as reimbursable toggle show enabled after disable it in import[/+]MelvinBot commentedon Aug 11, 2026
Proposal
What is the root cause of that problem?
The optimistic card created during CSV import never stores the
reimbursablevalue the user chose, and the card details page defaults a missing value to enabled.When you import and toggle Transactions are reimbursable OFF, that
isReimbursable=falseis correctly applied to the optimistic transactions, the saved column layout, and the API request — but not to the optimistic card object written toCARD_LIST.buildOptimisticCard()isn't even passedisReimbursableand returns a card with noreimbursablefield.The card details RHP then reads
card?.reimbursable ?? true. Since the optimistic card'sreimbursableisundefined, it falls back totrue, so the toggle shows enabled right after import. Once you visit "View transactions" and come back, the card is refreshed from the server (which returnsreimbursable: false), so the toggle then correctly shows disabled. That refresh is why the workaround "fixes" the display.Evidence / data flow
settings.isReimbursable = false.isReimbursable=falseflows to optimistic transactions (ImportTransactions.ts:233), the saved column layout (ImportTransactions.ts:111), and the API param (ImportTransactions.ts:329) — all correct.buildOptimisticCard(), called atImportTransactions.ts:313, never receives or setsreimbursable, so the optimistic card inCARD_LISThasreimbursable === undefined.PersonalCardDetailsPage.tsx:84?? true→ toggle renders enabled viaisActive={reimbursableSetting}inPersonalCardDetailsHeaderMenu.tsx.reimbursableis a first-class optional Card field (types/onyx/Card.ts:108-109) the server later fills in — which is why it self-corrects after a re-fetch.What changes do you think we should make in order to solve the problem?
Populate the optimistic card with the user's chosen value so the local state matches the server. Pass
isReimbursableintobuildOptimisticCard()and setreimbursableon the returned card object (updating the call site atImportTransactions.ts:313accordingly). This keeps the toggle correct immediately after import, with no reliance on a server round-trip.What alternative solutions did you explore? (Optional)
Changing the default at
PersonalCardDetailsPage.tsx:84was considered but rejected — the user's selection is already known at import time, so fixing the optimistic write is the correct fix; the?? truedefault is a reasonable fallback for cards where the field genuinely hasn't been set.Possibly related
#97779 — "Wallet - Upload CSV 'flip amount sign' is not preserved for subsequent uploads" is in the same CSV-import settings-persistence area, though a different field. Worth a glance but likely a separate fix.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/98243)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
melvin-bot commentedon Aug 11, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (
External)melvin-bot commentedon Aug 11, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022087028253854326070
brunovjk commentedon Aug 12, 2026
I believe we can go with @MelvinBot's proposal; it works well in my initial tests. Thank you.
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Aug 12, 2026
Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
rlinoz commentedon Aug 12, 2026
Sounds good, can you ask it to implement it please?
MelvinBot commentedon Aug 12, 2026
Thanks for the review,
brunovjk🙏This now goes to
rlinozfor the internal engineer sign-off. Once it's approved, reply with@MelvinBot implement [this](https://github.com/Expensify/App/issues/98243#issuecomment-5248872710)and I'll spin up the draft PR.16 remaining items
Better handling
brunovjk commentedon Aug 24, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: 5d30ea5#r197494222
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/675708
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-19bd-a57e-8ce8-5dddc13092b4melvin-bot commentedon Aug 24, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 24, 2026
Payment Summary
Resolving PRs:
Persist reimbursable selection on optimistic CSV import card #98486
Reviewer: @brunovjk owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 26, 2026
Payment Summary
Contributor+: @brunovjk due $250 via NewDot
laurenreidexpensify commentedon Aug 27, 2026
$250 approved @brunovjk New Expensify