Skip to content

[Due for payment 2026-08-25] Investigate workflow job failing on main: typecheck / typecheck #98669

Closed

Description

@github-actions

🚨 Failure Summary 🚨:

  • 📋 Job Name: typecheck / typecheck
  • 🔧 Failure in Workflow: Process new code merged to main
  • 🔗 Triggered by PR: PR Link
  • 👤 PR Author: @KioCoan
  • 🤝 Merged by: @Beamanator
  • 🐛 Error Message:
    warning: Skipping sticky disk commit due to previous step failures
    warning: Found 2 failed/cancelled steps in previous workflow steps
    warning: Skipping sticky disk commit due to previous step failures
    warning: Found 2 failed/cancelled steps in previous workflow steps
    failure: Process completed with exit code 2.
    failure: Property 'email' is missing in type '{ id: string; name: string; currency: "USD"; }' but required in type 'Vendor'.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named typecheck / typecheck.
🔍 This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

For detailed instructions, check this SO.

🐛 We appreciate your help in squashing this bug!

Activity

  1. Beamanator commented on Aug 14, 2026

    @Beamanator
    Contributor

    @MelvinBot investigate the failed check and propose a fix

  2. MelvinBot commented on Aug 14, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    Root Cause: A semantic merge conflict between two individually-green PRs, not a bug in either one.

    • Expensify/App#98436 ("Clean up unsafe type assertions in UI tests", merged Aug 13) tightened renderMoneyRequestView's policy param from Record<string, unknown> to PartialDeep<Policy> in tests/ui/MoneyRequestViewTest.tsx:103. PartialDeep does not recurse into arrays by default, so connections…data.vendors stays strictly typed as Vendor[], and Vendor requires email: string.
    • Expensify/App#98516 (this PR, merged Aug 14) added a new test whose QBO vendor literal at tests/ui/MoneyRequestViewTest.tsx:544 omits email.

    #98516's branch was last synced with main before #98436 merged, so its own typecheck ran against the old loose signature and passed (green ✅). Once it landed on a main that already had #98436's strict signature, the literal became invalid — hence error TS2741: Property 'email' is missing … but required in type 'Vendor' on main only.

    Recommended Fix: Add the required email field to the vendor literal at tests/ui/MoneyRequestViewTest.tsx:544:

    data: {vendors: [{id: 'v-1', name: 'Acme Co', currency: CONST.CURRENCY.USD, email: ''}]},

    email: '' matches the existing QBO-vendor convention in the test suite (e.g. PolicyUtilsTest expects email: '' for QBO vendors), and the test only asserts on the vendor name ('Acme Co'), so behavior is unchanged. This is the only type error in the failed run.

    Investigation details
    • Failing job: typecheck / typecheck — single error:
      tests/ui/MoneyRequestViewTest.tsx(544,38): error TS2741: Property 'email' is missing in type '{ id: string; name: string; currency: "USD"; }' but required in type 'Vendor'.
    • #98516's own typecheck check passed (run 31656753617) with the byte-identical line, confirming the break only appears when combined with #98436 on main.
    • #98436 diff: -policy?: Record<string, unknown> → +policy?: PartialDeep<Policy> (plus import type {PartialDeep} from 'type-fest').
    • No other files or vendor literals are affected — QBO vendor literals in PolicyUtilsTest/AddVendorPageTest go through createMock<…> (partial-typed) and stay green.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/98669) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  3. Beamanator commented on Aug 14, 2026

    @Beamanator
    Contributor

    @MelvinBot implement this

  4. MelvinBot commented on Aug 14, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #98671

    Adds the required email field to the QBO vendor test literal at tests/ui/MoneyRequestViewTest.tsx:544, resolving the typecheck / typecheck failure on main (semantic merge conflict between Expensify/App#98436 and Expensify/App#98516). Verified locally: npm run typecheck passes and eslint is clean on the changed file.

    Please mark it as "Ready for review" when it is ready for review.

  5. changed the title [-]Investigate workflow job failing on main: typecheck / typecheck[/-] [+][Due for payment 2026-08-25] Investigate workflow job failing on main: typecheck / typecheck[/+] on Aug 18, 2026
  6. melvin-bot commented on Aug 18, 2026

    @melvin-bot

    @Beamanator

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-25. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions