You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Amount inline field is populated with 0.00 when amount is empty #98786
Version Number: 9.4.54-2 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#96772 Email or phone of affected tester (no customers):sjdoinsjdnoijnsdojo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create a manual expense.
Create a scan expense with invalid receipt.
Wait for scan to fail.
Open the report.
Click amount inline field.
Expected Result:
Amount inline field should be empty because amount is empty.
Actual Result:
Amount inline field is populated with 0.00 when amount is empty.
Classification: Frontend bug Causing PR: #96772 - "fix: show scan error instead of populating $0 amount when scan fails" by @x-dev90 (High confidence) Related Issues: #94494 (the issue PR #96772 was fixing)
Recommendation: ROLL FORWARD
PR #96772 intentionally made a failed-scan amount render empty in the read-only displays, but it never updated the inline edit input, which still initializes from absoluteAmount (0) and therefore renders 0.00. A clean revert would reintroduce the broader $0.00-everywhere bug this PR fixed (#94494), so a small targeted follow-up in TotalCell.tsx (make the inline MoneyRequestAmountInput start empty for the failed-scan placeholder, mirroring the display path) is safer than reverting.
Assigned: @x-dev90 (PR author), @Ollyws and @arosiclair (approving reviewers) — already assigned Labels: No change. DeployBlockerCash correctly stays (App deploy is blocked); no DeployBlocker (Web) label is present.
The PR's entire purpose was failed-scan amount handling ("distinguishing the SmartScan placeholder 0 from a user-entered $0.00"). It added isFailedScanAmountPlaceholder(...) and used it to blank out the amount in several display surfaces (MoneyRequestView, TotalCell, useConfirmationAmount, TransactionPreviewUtils).
Reviewer @Ollyws even flagged a related inconsistency during review ("the expense report page is the only one that displays $0.00"), which is the same class of gap this bug exposes on the inline edit path.
But the inline edit input is still seeded with absoluteAmount (Math.abs(amount ?? 0) = 0): TotalCell.tsx#L77 is passed as amount={absoluteAmount} to MoneyRequestAmountInput at TotalCell.tsx#L176-L179, so on click the input formats 0 to 0.00.
PR #96772 blanked the amount only on the read/display paths for the failed-scan placeholder but left the edit path untouched. In TotalCell, amountToDisplay becomes '' for hasFailedScanAmountPlaceholder, yet the same component passes the raw absoluteAmount (0) into MoneyRequestAmountInput. Entering inline edit therefore shows 0.00 instead of an empty input, contradicting the now-empty display. Before this PR both paths showed 0.00 (consistent, no report); the PR made the display empty without matching the edit input, creating the reported inconsistency. The fix is to make the inline input render empty for hasFailedScanAmountPlaceholder (e.g. don't seed it with 0), consistent with the display and with the submitEditAmount handling the PR already added in IOUAmountSubmission.ts.
Activity
applause-bot commentedon Aug 17, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/cd63315b23617af07467d81cb425569f208382c11cecd716df8e53ae03248d3f
melvin-bot commentedon Aug 17, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #96772
melvin-bot commentedon Aug 17, 2026
@arosiclair @Ollyws you have been assigned to this deploy blocker because you reviewed the offending PR: #96772
melvin-bot commentedon Aug 17, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Aug 17, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #96772 - "fix: show scan error instead of populating $0 amount when scan fails" by @x-dev90 (High confidence)
Related Issues: #94494 (the issue PR #96772 was fixing)
Recommendation: ROLL FORWARD
PR #96772 intentionally made a failed-scan amount render empty in the read-only displays, but it never updated the inline edit input, which still initializes from
absoluteAmount(0) and therefore renders0.00. A clean revert would reintroduce the broader$0.00-everywhere bug this PR fixed (#94494), so a small targeted follow-up inTotalCell.tsx(make the inlineMoneyRequestAmountInputstart empty for the failed-scan placeholder, mirroring the display path) is safer than reverting.Assigned: @x-dev90 (PR author), @Ollyws and @arosiclair (approving reviewers) — already assigned
Labels: No change.
DeployBlockerCashcorrectly stays (App deploy is blocked); noDeployBlocker(Web) label is present.📋 Detailed Analysis
Evidence
mainon 2026-08-14 and is on the current Deploy Checklist 2026-08-14 (#98677) but has not shipped to production — exactly matching a staging-only regression.0from a user-entered$0.00"). It addedisFailedScanAmountPlaceholder(...)and used it to blank out the amount in several display surfaces (MoneyRequestView,TotalCell,useConfirmationAmount,TransactionPreviewUtils).Verification
src/components/TransactionItemRow/DataCells/TotalCell.tsx, one of the files PR fix: show scan error instead of populating $0 amount when scan fails #96772 modifies.TotalCell.tsx#L64-L70.absoluteAmount(Math.abs(amount ?? 0)=0):TotalCell.tsx#L77is passed asamount={absoluteAmount}toMoneyRequestAmountInputatTotalCell.tsx#L176-L179, so on click the input formats0to0.00.TransactionUtils/index.ts#L560-L567.Root Cause
PR #96772 blanked the amount only on the read/display paths for the failed-scan placeholder but left the edit path untouched. In
TotalCell,amountToDisplaybecomes''forhasFailedScanAmountPlaceholder, yet the same component passes the rawabsoluteAmount(0) intoMoneyRequestAmountInput. Entering inline edit therefore shows0.00instead of an empty input, contradicting the now-empty display. Before this PR both paths showed0.00(consistent, no report); the PR made the display empty without matching the edit input, creating the reported inconsistency. The fix is to make the inline input render empty forhasFailedScanAmountPlaceholder(e.g. don't seed it with0), consistent with the display and with thesubmitEditAmounthandling the PR already added inIOUAmountSubmission.ts.arosiclair commentedon Aug 17, 2026
I don't think this is an issue
m-natarajan commentedon Aug 18, 2026
Amount field is populated with 0.00 when scan failed, Win 11/Chrome, v9.4.54-4
Recording.3379.mp4