Skip to content

Expense - Amount inline field is populated with 0.00 when amount is empty #98786

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.54-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #96772
Email or phone of affected tester (no customers): sjdoinsjdnoijnsdojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a manual expense.
  4. Create a scan expense with invalid receipt.
  5. Wait for scan to fail.
  6. Open the report.
  7. Click amount inline field.

Expected Result:

Amount inline field should be empty because amount is empty.

Actual Result:

Amount inline field is populated with 0.00 when amount is empty.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7235685_1786984521192.11.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7235685

Activity

  1. applause-bot commented on Aug 17, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/cd63315b23617af07467d81cb425569f208382c11cecd716df8e53ae03248d3f

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 17, 2026
  3. melvin-bot commented on Aug 17, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #96772

  4. melvin-bot commented on Aug 17, 2026

    @melvin-bot

    @arosiclair @Ollyws you have been assigned to this deploy blocker because you reviewed the offending PR: #96772

  5. melvin-bot commented on Aug 17, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. MelvinBot commented on Aug 17, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #96772 - "fix: show scan error instead of populating $0 amount when scan fails" by @x-dev90 (High confidence)
    Related Issues: #94494 (the issue PR #96772 was fixing)

    Recommendation: ROLL FORWARD

    PR #96772 intentionally made a failed-scan amount render empty in the read-only displays, but it never updated the inline edit input, which still initializes from absoluteAmount (0) and therefore renders 0.00. A clean revert would reintroduce the broader $0.00-everywhere bug this PR fixed (#94494), so a small targeted follow-up in TotalCell.tsx (make the inline MoneyRequestAmountInput start empty for the failed-scan placeholder, mirroring the display path) is safer than reverting.

    Assigned: @x-dev90 (PR author), @Ollyws and @arosiclair (approving reviewers) — already assigned
    Labels: No change. DeployBlockerCash correctly stays (App deploy is blocked); no DeployBlocker (Web) label is present.

    📋 Detailed Analysis

    Evidence

    • The bug is staging-only (v9.4.54-2), not reproducible on production. PR fix: show scan error instead of populating $0 amount when scan fails #96772 merged to main on 2026-08-14 and is on the current Deploy Checklist 2026-08-14 (#98677) but has not shipped to production — exactly matching a staging-only regression.
    • The PR's entire purpose was failed-scan amount handling ("distinguishing the SmartScan placeholder 0 from a user-entered $0.00"). It added isFailedScanAmountPlaceholder(...) and used it to blank out the amount in several display surfaces (MoneyRequestView, TotalCell, useConfirmationAmount, TransactionPreviewUtils).
    • Reviewer @Ollyws even flagged a related inconsistency during review ("the expense report page is the only one that displays $0.00"), which is the same class of gap this bug exposes on the inline edit path.

    Verification

    Root Cause

    PR #96772 blanked the amount only on the read/display paths for the failed-scan placeholder but left the edit path untouched. In TotalCell, amountToDisplay becomes '' for hasFailedScanAmountPlaceholder, yet the same component passes the raw absoluteAmount (0) into MoneyRequestAmountInput. Entering inline edit therefore shows 0.00 instead of an empty input, contradicting the now-empty display. Before this PR both paths showed 0.00 (consistent, no report); the PR made the display empty without matching the edit input, creating the reported inconsistency. The fix is to make the inline input render empty for hasFailedScanAmountPlaceholder (e.g. don't seed it with 0), consistent with the display and with the submitEditAmount handling the PR already added in IOUAmountSubmission.ts.

  7. arosiclair commented on Aug 17, 2026

    @arosiclair
    Contributor

    I don't think this is an issue

  8. m-natarajan commented on Aug 18, 2026

    @m-natarajan

    Amount field is populated with 0.00 when scan failed, Win 11/Chrome, v9.4.54-4

    Recording.3379.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.HourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions