You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-27] Security- After clicking Got it on the success screen, the user is redirected to home #98933
Version Number: v9.4.56-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/69795713/folder/52723519/41236669/1673512178?sort=%2Bidentifier Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Windows 10 / Chrome, Honor x6b/ Android 16 App Component: User Settings
Action Performed:
Navigate to Account > Security > Two Factor Authentication (2FA)
Click on "Download codes"
Open your authenticator app and scan the QR or paste the secret key to set up the authenticator
Enter the 6 digit code provided by the authenticator app
Click on "Next"
6.Click on "Got it"
Verify (Web) the user is redirected to the Two-factor authentication page with 2FA enabled and a Security page is displayed in the background. (Native) user is redirected to the security page
Expected Result:
The user is redirected to the Two-factor authentication page with 2FA enabled and a Security page is displayed in the background
Actual Result:
After clicking Got it on the success screen, the user is redirected to home
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Causing PR:#94486 — "Required 2FA setup screen is unresponsive, blocking new-domain login and account merge" (neerajbachani) — High confidence Recommendation: 🟢 Roll forward with a one-line fix (reverting would reintroduce the more severe require-2FA overlay bug that #94486 fixed).
Root cause: In DynamicSuccessPage.tsx:59 the forced-onboarding check is called with a hardcoded false for the hasCompletedGuidedSetupFlow argument:
The helper (AccountUtils.ts:34-35) is !!account?.twoFactorAuthSetupInProgress && hasCompletedGuidedSetupFlow === false. Since false === false is always true, passing the literal false collapses the guard to justtwoFactorAuthSetupInProgress — a flag that is set to true for every user during the "Download codes" step (TwoFactorAuthActions.ts:24).
So for a normal, already-onboarded user on the success screen, shouldReturnToOnboardingAfter2FA becomes true, and clicking "Got it" takes the onboarding-handoff branch (:99 → completeForcedOnboarding2FAHandoff :62-70) which calls Navigation.revealRouteBeforeDismissingModal(ROUTES.HOME, …) → redirected to Home, instead of the intended Navigation.navigate(ROUTES.SETTINGS_2FA_ENABLED, …) at :106.
This keeps the forced-onboarding handoff working for genuinely-incomplete onboarding users (hasCompletedGuidedSetupFlow === false) while restoring correct navigation for normal, already-onboarded users.
Evidence
The PR diff adds this exact line with the hardcoded false (added line in the PR). Tellingly, every other call site introduced by the same PR passes the real onboarding flag (!!isOnboardingCompleted, hasCompletedGuidedSetupFlow, !!hasCompletedGuidedSetupFlow) — only DynamicSuccessPage hardcodes false, which is the mistake.
Next Steps for Contributor+ team: To accept:@MelvinBot implement this to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
cc neerajbachani (author), iwiznia / thelullabyy (reviewers of #94486)
changed the title [-]Security- After clicking Got it on the success screen, the user is redirected to home[/-][+][Due for payment 2026-08-27] Security- After clicking Got it on the success screen, the user is redirected to home[/+]on Aug 20, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.56-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-27. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Aug 19, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/36b7f36e689a124560dc58bdb7ffb92e29facfa457a92540834383e491f8b98f
melvin-bot commentedon Aug 19, 2026
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 19, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Aug 19, 2026
Production video:
Recording.6221.mp4
MelvinBot commentedon Aug 19, 2026
🔍 Deploy Blocker Analysis
Causing PR: #94486 — "Required 2FA setup screen is unresponsive, blocking new-domain login and account merge" (
neerajbachani) — High confidenceRecommendation: 🟢 Roll forward with a one-line fix (reverting would reintroduce the more severe require-2FA overlay bug that #94486 fixed).
Root cause: In
DynamicSuccessPage.tsx:59the forced-onboarding check is called with a hardcodedfalsefor thehasCompletedGuidedSetupFlowargument:The helper (
AccountUtils.ts:34-35) is!!account?.twoFactorAuthSetupInProgress && hasCompletedGuidedSetupFlow === false. Sincefalse === falseis always true, passing the literalfalsecollapses the guard to justtwoFactorAuthSetupInProgress— a flag that is set totruefor every user during the "Download codes" step (TwoFactorAuthActions.ts:24).So for a normal, already-onboarded user on the success screen,
shouldReturnToOnboardingAfter2FAbecomestrue, and clicking "Got it" takes the onboarding-handoff branch (:99→completeForcedOnboarding2FAHandoff:62-70) which callsNavigation.revealRouteBeforeDismissingModal(ROUTES.HOME, …)→ redirected to Home, instead of the intendedNavigation.navigate(ROUTES.SETTINGS_2FA_ENABLED, …)at:106.Suggested fix: Pass the already-computed real value (
hasCompletedGuidedSetupFlowat :49) instead of the literalfalse:This keeps the forced-onboarding handoff working for genuinely-incomplete onboarding users (
hasCompletedGuidedSetupFlow === false) while restoring correct navigation for normal, already-onboarded users.Evidence
false(added line in the PR). Tellingly, every other call site introduced by the same PR passes the real onboarding flag (!!isOnboardingCompleted,hasCompletedGuidedSetupFlow,!!hasCompletedGuidedSetupFlow) — onlyDynamicSuccessPagehardcodesfalse, which is the mistake.v9.4.56/ Deploy Checklist Deploy Checklist: New Expensify 2026-08-18 #98919). Matches "reproducible on staging, not production" — the production video in the thread confirms production still lands on the 2FA Enabled/Security page.DynamicSuccessPage.tsxandAccountUtils.ts(where the misused helper was added).Next Steps for Contributor+ team:
To accept:
@MelvinBot implement thisto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
cc
neerajbachani(author),iwiznia/thelullabyy(reviewers of #94486)m-natarajan commentedon Aug 19, 2026
Windows 10 / Chrome
Not Repro
v9.4.56-2 PR:98989
bandicam.2026-08-19.16-23-44-627.mp4
m-natarajan commentedon Aug 19, 2026
Windows 10 / chrome
Not Repro
v9.4.56-0 PR:98940
bandicam.2026-08-19.16-52-23-302.mp4
m-natarajan commentedon Aug 19, 2026
Not repro, Win11/Chrome, v9.4.56-3
Recording.3387.mp4
Beamanator commentedon Aug 19, 2026
great! closing!
[-]Security- After clicking Got it on the success screen, the user is redirected to home[/-][+][Due for payment 2026-08-27] Security- After clicking Got it on the success screen, the user is redirected to home[/+]melvin-bot commentedon Aug 20, 2026
@Beamanator / @roryabraham
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.56-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-27. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]