Skip to content

[Due for payment 2026-08-27] Security- After clicking Got it on the success screen, the user is redirected to home #98933

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: v9.4.56-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/69795713/folder/52723519/41236669/1673512178?sort=%2Bidentifier
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 10 / Chrome, Honor x6b/ Android 16
App Component: User Settings

Action Performed:

  1. Navigate to Account > Security > Two Factor Authentication (2FA)
  2. Click on "Download codes"
  3. Open your authenticator app and scan the QR or paste the secret key to set up the authenticator
  4. Enter the 6 digit code provided by the authenticator app
  5. Click on "Next"
    6.Click on "Got it"
  6. Verify (Web) the user is redirected to the Two-factor authentication page with 2FA enabled and a Security page is displayed in the background. (Native) user is redirected to the security page

Expected Result:

The user is redirected to the Two-factor authentication page with 2FA enabled and a Security page is displayed in the background

Actual Result:

After clicking Got it on the success screen, the user is redirected to home

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7236780_1787098099116.bandicam_2026-08-18_19-01-30-068.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7236780

Activity

  1. applause-bot commented on Aug 19, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/36b7f36e689a124560dc58bdb7ffb92e29facfa457a92540834383e491f8b98f

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 19, 2026
  3. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Aug 19, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. lanitochka17 commented on Aug 19, 2026

    @lanitochka17

    Production video:

    Recording.6221.mp4
  7. MelvinBot commented on Aug 19, 2026

    @MelvinBot
    Contributor

    🔍 Deploy Blocker Analysis

    Causing PR: #94486 — "Required 2FA setup screen is unresponsive, blocking new-domain login and account merge" (neerajbachani) — High confidence
    Recommendation: 🟢 Roll forward with a one-line fix (reverting would reintroduce the more severe require-2FA overlay bug that #94486 fixed).

    Root cause: In DynamicSuccessPage.tsx:59 the forced-onboarding check is called with a hardcoded false for the hasCompletedGuidedSetupFlow argument:

    const isForcedOnboardingHandoff = AccountUtils.isForced2FAOnboardingSetup(account, false) || (...);

    The helper (AccountUtils.ts:34-35) is !!account?.twoFactorAuthSetupInProgress && hasCompletedGuidedSetupFlow === false. Since false === false is always true, passing the literal false collapses the guard to just twoFactorAuthSetupInProgress — a flag that is set to true for every user during the "Download codes" step (TwoFactorAuthActions.ts:24).

    So for a normal, already-onboarded user on the success screen, shouldReturnToOnboardingAfter2FA becomes true, and clicking "Got it" takes the onboarding-handoff branch (:99 → completeForcedOnboarding2FAHandoff :62-70) which calls Navigation.revealRouteBeforeDismissingModal(ROUTES.HOME, …) → redirected to Home, instead of the intended Navigation.navigate(ROUTES.SETTINGS_2FA_ENABLED, …) at :106.

    Suggested fix: Pass the already-computed real value (hasCompletedGuidedSetupFlow at :49) instead of the literal false:

    const isForcedOnboardingHandoff =
        AccountUtils.isForced2FAOnboardingSetup(account, hasCompletedGuidedSetupFlow) ||
        (!!account?.requiresTwoFactorAuth && isIncompleteOnboarding && hasSavedOnboardingPath);

    This keeps the forced-onboarding handoff working for genuinely-incomplete onboarding users (hasCompletedGuidedSetupFlow === false) while restoring correct navigation for normal, already-onboarded users.

    Evidence

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement this to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

    cc neerajbachani (author), iwiznia / thelullabyy (reviewers of #94486)

  8. m-natarajan commented on Aug 19, 2026

    @m-natarajan

    Windows 10 / Chrome
    Not Repro
    v9.4.56-2 PR:98989

    bandicam.2026-08-19.16-23-44-627.mp4
  9. m-natarajan commented on Aug 19, 2026

    @m-natarajan

    Windows 10 / chrome
    Not Repro
    v9.4.56-0 PR:98940

    bandicam.2026-08-19.16-52-23-302.mp4
  10. m-natarajan commented on Aug 19, 2026

    @m-natarajan

    Not repro, Win11/Chrome, v9.4.56-3

    Recording.3387.mp4
  11. Beamanator commented on Aug 19, 2026

    @Beamanator
    Contributor

    great! closing!

  12. changed the title [-]Security- After clicking Got it on the success screen, the user is redirected to home[/-] [+][Due for payment 2026-08-27] Security- After clicking Got it on the success screen, the user is redirected to home[/+] on Aug 20, 2026
  13. melvin-bot commented on Aug 20, 2026

    @melvin-bot

    @Beamanator / @roryabraham

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.56-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-27. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions