You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-27] [$250] Security - "What's your work email?" window appears briefly after setting up 2FA #98938
Version Number: 9.4.56-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98756 Email or phone of affected tester (no customers):fischer9966+081826+98519@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: iPhone 17 Pro / 26.6. Google Pixel 5 / Android 14 App Component: User Settings
Action Performed:
Open Expensify app on iOS or Android
Login with Gmail account
Go to Account > Security > Two Factor Authentication (2FA)
Tap to "Download codes"
Enter the 6 digit code from the authenticator app
Tap "Next"
Tap "Got it" on confirmation screen
Expected Result:
The user proceeds to the next screen without the appearance of elements unrelated to the flow.
Actual Result:
After setting up 2FA user proceeds to the next screen after which "What's your work email?" window appears briefly.
Sometimes a screen "Whats your name" may appear instead of "What's your work email?"
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #94486 - "Required 2FA setup screen is unresponsive, blocking new-domain login and account merge" by @neerajbachani (High confidence) Related Issues: The auto-assigned PR #94486 fixes #84246 / addresses the required-2FA-during-onboarding work; the originally-flagged PR #98756 is not the cause (see below).
Recommendation: ROLL FORWARD
The regression is a single, well-understood line: DynamicSuccessPage passes a hardcoded false for hasCompletedGuidedSetupFlow, which defeats the only guard in isForced2FAOnboardingSetup and makes the forced-onboarding handoff fire for every user who sets up 2FA via Settings > Security. A one-argument fix resolves it, whereas reverting a 20-file 2FA/onboarding PR is high-risk and would reintroduce the new-domain-login / account-merge blocker that PR fixed. Revert is an acceptable fallback if a fix can't be verified quickly.
Assigned: @neerajbachani (PR author), @iwiznia and @thelullabyy (approving reviewers) from the causing PR #94486. Labels: No changes. This is a Frontend bug, so DeployBlockerCash stays (App deploy is blocked). No DeployBlocker label is present.
Note on the auto-assignment: melvin-bot assigned #98756 and its author/reviewers (@jakubstec, @roryabraham, @linhvovan29546). #98756 is not the cause — it only touches src/hooks/useIsAgentAccount.ts (a re-render optimization) and a test. It does not touch any onboarding, 2FA-success, navigation, or modal code.
Confirmed the trigger flag is set during normal setup: setCodesAreCopied() sets account.twoFactorAuthSetupInProgress = true at the "Download codes" step — TwoFactorAuthActions.ts#L22-L24.
Root Cause
The 2FA success page decides whether to hand the user off into the onboarding flow:
The call passes a hardcoded false for hasCompletedGuidedSetupFlow, even though the real value is already computed one line above as the hasCompletedGuidedSetupFlow variable. With the literal false, the guard hasCompletedGuidedSetupFlow === false is always true, so the function collapses to just !!account?.twoFactorAuthSetupInProgress.
During the reported flow the user taps "Download codes", which sets twoFactorAuthSetupInProgress = true. So when they reach the success page (entered via Settings > Security, i.e. isSecuritySettingsFlow === true):
isForced2FAOnboardingSetup(account, false) → true
→ isForcedOnboardingHandoff → true
→ shouldReturnToOnboardingAfter2FA → true
Tapping "Got it" (onButtonPress L98-L100) then runs completeForcedOnboarding2FAHandoff() (L62-L70), which does Navigation.revealRouteBeforeDismissingModal(ROUTES.HOME, { afterTransition: () => resumeOnboardingAfterRequired2FASetup(...) }). That resumes the onboarding flow and briefly flashes "What's your work email?" / "What's your name" before onboarding state settles and dismisses. This happens to every user setting up 2FA from Settings > Security, not just the intended forced-onboarding-during-domain-migration case.
Suggested fix (roll forward)
Pass the real value instead of the literal so the guard actually gates on completed onboarding:
This restores the intended behavior: the handoff fires only for users who have not completed guided setup (the genuine forced-onboarding case). For extra safety, consider dropping the first clause entirely and relying on the second clause (requiresTwoFactorAuth && isIncompleteOnboarding && hasSavedOnboardingPath), whose hasSavedOnboardingPath check already discriminates "arrived from the require-2FA onboarding overlay" from "voluntarily opened Settings > Security". Please re-test the domain-migration / required-2FA-before-onboarding flow after the change.
changed the title [-]Security - "What's your work email?" window appears briefly after setting up 2FA[/-][+][$250] Security - "What's your work email?" window appears briefly after setting up 2FA[/+]on Aug 19, 2026
changed the title [-][$250] Security - "What's your work email?" window appears briefly after setting up 2FA[/-][+][Due for payment 2026-08-27] [$250] Security - "What's your work email?" window appears briefly after setting up 2FA[/+]on Aug 20, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.56-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-27. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Aug 19, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e9dc52e20b1666d1db6197b15edaf3e99c88c121be083e463ffceebdac65c747
https://platform.applause.com/services/links/v1/external/964dffe90a5add1e142c2e05edd9a4180a186e598e9cfa17f046218387fe433f
https://platform.applause.com/services/links/v1/external/ec4126fbbd714e635d648ee43a81d25b98df0712f3eecbda645ed1897b4a854f
melvin-bot commentedon Aug 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #98756
melvin-bot commentedon Aug 19, 2026
@roryabraham @linhvovan29546 you have been assigned to this deploy blocker because you reviewed the offending PR: #98756
melvin-bot commentedon Aug 19, 2026
@jakubstec you have been assigned to this deploy blocker because you authored the offending PR: #98756
github-actions commentedon Aug 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 19, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Aug 19, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #94486 - "Required 2FA setup screen is unresponsive, blocking new-domain login and account merge" by @neerajbachani (High confidence)
Related Issues: The auto-assigned PR #94486 fixes #84246 / addresses the required-2FA-during-onboarding work; the originally-flagged PR #98756 is not the cause (see below).
Recommendation: ROLL FORWARD
The regression is a single, well-understood line:
DynamicSuccessPagepasses a hardcodedfalseforhasCompletedGuidedSetupFlow, which defeats the only guard inisForced2FAOnboardingSetupand makes the forced-onboarding handoff fire for every user who sets up 2FA via Settings > Security. A one-argument fix resolves it, whereas reverting a 20-file 2FA/onboarding PR is high-risk and would reintroduce the new-domain-login / account-merge blocker that PR fixed. Revert is an acceptable fallback if a fix can't be verified quickly.Assigned: @neerajbachani (PR author), @iwiznia and @thelullabyy (approving reviewers) from the causing PR #94486.
Labels: No changes. This is a Frontend bug, so
DeployBlockerCashstays (App deploy is blocked). NoDeployBlockerlabel is present.📋 Detailed Analysis
Evidence
src/pages/settings/Security/TwoFactorAuth/DynamicSuccessPage.tsxand the work-email onboarding screensrc/pages/OnboardingWorkEmail/BaseOnboardingWorkEmail.tsx, plusOnboardingGuard.ts,useOnboardingFlow.ts,AccountUtils.ts, andlibs/actions/Welcome/OnboardingFlow.ts.2026-08-18T17:51Z— in this release (#98919). The bug is reproducible on staging but not production, consistent with a PR that first shipped to staging in this deploy.isForcedOnboardingHandoff,shouldReturnToOnboardingAfter2FA,completeForcedOnboarding2FAHandoff, and theresumeOnboardingAfterRequired2FASetupcall intoDynamicSuccessPage. None of this existed before the PR.useOnyxselector inuseIsAgentAccount.ts— unrelated to onboarding/2FA/navigation.Verification
DynamicSuccessPage.tsx(button handler) andAccountUtils.ts(isForced2FAOnboardingSetup), both introduced/modified by Required 2FA setup screen is unresponsive, blocking new-domain login and account merge #94486.git/API history forDynamicSuccessPage.tsxshows the handoff commits all belong to Required 2FA setup screen is unresponsive, blocking new-domain login and account merge #94486's branch (91985-fix-required-2fa-overlay-onboarding), merged into main only on 2026-08-18.setCodesAreCopied()setsaccount.twoFactorAuthSetupInProgress = trueat the "Download codes" step —TwoFactorAuthActions.ts#L22-L24.Root Cause
The 2FA success page decides whether to hand the user off into the onboarding flow:
DynamicSuccessPage.tsx#L56-L60isForced2FAOnboardingSetupisAccountUtils.ts#L34-L36:The call passes a hardcoded
falseforhasCompletedGuidedSetupFlow, even though the real value is already computed one line above as thehasCompletedGuidedSetupFlowvariable. With the literalfalse, the guardhasCompletedGuidedSetupFlow === falseis alwaystrue, so the function collapses to just!!account?.twoFactorAuthSetupInProgress.During the reported flow the user taps "Download codes", which sets
twoFactorAuthSetupInProgress = true. So when they reach the success page (entered via Settings > Security, i.e.isSecuritySettingsFlow === true):isForced2FAOnboardingSetup(account, false)→trueisForcedOnboardingHandoff→trueshouldReturnToOnboardingAfter2FA→trueTapping "Got it" (
onButtonPressL98-L100) then runscompleteForcedOnboarding2FAHandoff()(L62-L70), which doesNavigation.revealRouteBeforeDismissingModal(ROUTES.HOME, { afterTransition: () => resumeOnboardingAfterRequired2FASetup(...) }). That resumes the onboarding flow and briefly flashes "What's your work email?" / "What's your name" before onboarding state settles and dismisses. This happens to every user setting up 2FA from Settings > Security, not just the intended forced-onboarding-during-domain-migration case.Suggested fix (roll forward)
Pass the real value instead of the literal so the guard actually gates on completed onboarding:
This restores the intended behavior: the handoff fires only for users who have not completed guided setup (the genuine forced-onboarding case). For extra safety, consider dropping the first clause entirely and relying on the second clause (
requiresTwoFactorAuth && isIncompleteOnboarding && hasSavedOnboardingPath), whosehasSavedOnboardingPathcheck already discriminates "arrived from the require-2FA onboarding overlay" from "voluntarily opened Settings > Security". Please re-test the domain-migration / required-2FA-before-onboarding flow after the change.6 remaining items
IuliiaHerets commentedon Aug 19, 2026
@roryabraham
Issue not reproducible using ad hoc build v9.4.56-0, PR: 98940.
Device: iPhone 14/26.6
ScreenRecording_08-19-2026.13-08-14_1.MP4
Issue not reproducible using ad hoc build v9.4.56-0, PR: 98940.
Device: Samsung A54/android 16
2026-08-19.1.17.32.PM.mp4
[-]Security - "What's your work email?" window appears briefly after setting up 2FA[/-][+][$250] Security - "What's your work email?" window appears briefly after setting up 2FA[/+]melvin-bot commentedon Aug 19, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022090160402810620327
m-natarajan commentedon Aug 19, 2026
Not Repro, Honor x6b / Android 16, iPhone13 / iOS26.6, v9.4.56-2 PR:98989
document_4913818903068542997.mp4
ScreenRecording_08-19-2026.17-28-26_1.MP4
m-natarajan commentedon Aug 19, 2026
Not repro, iPhone13 / iOS26.6, v9.4.56-3
WhatsApp.Video.2026-08-19.at.6.57.48.PM.mp4
Beamanator commentedon Aug 19, 2026
great! closing!
[-][$250] Security - "What's your work email?" window appears briefly after setting up 2FA[/-][+][Due for payment 2026-08-27] [$250] Security - "What's your work email?" window appears briefly after setting up 2FA[/+]melvin-bot commentedon Aug 20, 2026
@linhvovan29546 / @thelullabyy
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.56-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-27. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]