Skip to content

[Due for payment 2026-08-29] [Search] Add logs to silent skips in Search bulk/row actions #98986

Closed

Description

@VickyStash

Background

This issue is preventative: add a log line to each skip, mirroring the [BulkPay] pattern, so the next report of "the button did nothing" comes with evidence.

Skips to instrument

  1. Bulk Unhold — src/hooks/useSearchBulkActions.ts:2487-2490: silent continue when selectedTransactions[transactionID].reportAction?.childReportID is missing. Held transactions always have a thread server-side, so this should be rare — but if it hits, nothing is logged. Suggested tag: [BulkUnhold].

    for (const transactionID of selectedTransactionsKeys) {
        if (!selectedTransactions[transactionID].reportAction?.childReportID) {
            continue;
        }
  2. Bulk Submit — src/hooks/useSearchBulkActions.ts:2304-2309: if (policy) silently skips items whose policy is missing from the Onyx policies collection; no snapshot-policy fallback. Low risk (the submitter is a policy member, so the policy is normally cached). Suggested tag: [BulkSubmit].

    for (const item of itemList) {
        const policy = policies?.[`${ONYXKEYS.COLLECTION.POLICY}${item.policyID}`];
        if (policy) {
            submitMoneyRequestOnSearch(...);
        }
    }
  3. Bulk Approve — src/hooks/useSearchBulkActions.ts:1046-1050: if (!expenseReport) continue; after the snapshot-first read. Near-impossible in practice (the expense report is the matched snapshot row itself), but symmetric with the others. Suggested tag: [BulkApprove].

  4. Row Export to accounting — src/libs/actions/Search.ts:446-452: silent return when getValidConnectedIntegration(exportPolicy) finds no valid connected integration, and another when item.reportID is missing. The button only renders when the snapshot marked the report exportable, so a silent return here means a visibly dead button. Suggested tag: [SearchExport].

    if (!connectedIntegration) {
        return;
    }
    
    if (!item?.reportID) {
        return;
    }

Proposed change

Add a Log.info at each of the four skip points, including the relevant IDs (transactionID / reportID / policyID) so a skipped row can be traced from logs alone. No behavior change — logging only.

Issue OwnerCurrent Issue Owner: @VickyStash
Issue OwnerCurrent Issue Owner: @VickyStash

Activity

  1. VickyStash commented on Aug 20, 2026

    @VickyStash
    ContributorAuthor

    PR: #99038

  2. changed the title [-][Search] Add logs to silent skips in Search bulk/row actions[/-] [+][Due for payment 2026-08-29] [Search] Add logs to silent skips in Search bulk/row actions[/+] on Aug 22, 2026
  3. melvin-bot commented on Aug 22, 2026

    @melvin-bot

    @mountiny @VickyStash

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-29. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions