You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-29] [Search] Add logs to silent skips in Search bulk/row actions #98986
This issue is preventative: add a log line to each skip, mirroring the [BulkPay] pattern, so the next report of "the button did nothing" comes with evidence.
Skips to instrument
Bulk Unhold — src/hooks/useSearchBulkActions.ts:2487-2490: silent continue when selectedTransactions[transactionID].reportAction?.childReportID is missing. Held transactions always have a thread server-side, so this should be rare — but if it hits, nothing is logged. Suggested tag: [BulkUnhold].
Bulk Submit — src/hooks/useSearchBulkActions.ts:2304-2309: if (policy) silently skips items whose policy is missing from the Onyx policies collection; no snapshot-policy fallback. Low risk (the submitter is a policy member, so the policy is normally cached). Suggested tag: [BulkSubmit].
Bulk Approve — src/hooks/useSearchBulkActions.ts:1046-1050: if (!expenseReport) continue; after the snapshot-first read. Near-impossible in practice (the expense report is the matched snapshot row itself), but symmetric with the others. Suggested tag: [BulkApprove].
Row Export to accounting — src/libs/actions/Search.ts:446-452: silent return when getValidConnectedIntegration(exportPolicy) finds no valid connected integration, and another when item.reportID is missing. The button only renders when the snapshot marked the report exportable, so a silent return here means a visibly dead button. Suggested tag: [SearchExport].
Add a Log.info at each of the four skip points, including the relevant IDs (transactionID / reportID / policyID) so a skipped row can be traced from logs alone. No behavior change — logging only.
changed the title [-][Search] Add logs to silent skips in Search bulk/row actions[/-][+][Due for payment 2026-08-29] [Search] Add logs to silent skips in Search bulk/row actions[/+]on Aug 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-29. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
VickyStash commentedon Aug 20, 2026
PR: #99038
[-][Search] Add logs to silent skips in Search bulk/row actions[/-][+][Due for payment 2026-08-29] [Search] Add logs to silent skips in Search bulk/row actions[/+]melvin-bot commentedon Aug 22, 2026
@mountiny @VickyStash
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-29. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]