You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Group Chat - View scrolls to Recents header when unselecting users from group conversation #9918
Hmm @kbecciv I'm unable to reproduce this on staging v1.1.84-11. The users look like they're being added and removed correctly with no users being hidden:
@NikkiWines Sorry, for confusion. But when you unselected one of your user - the rest of users are hidden on top of the list. You can see them only when you're scrolling. App behavior should be the same when you selecting and deselecting users.
changed the title [-]Group Chat - Previously selected users are hidden after unselecting user from group conversation[/-][+]Group Chat - View scrolls to Recents header when unselecting users from group conversation[/+]on Jul 15, 2022
Ah, @kbecciv, I see! The issue is that it scrolls down to the Recents heading when you select a user instead of staying at the currently selected user's section. I've updated the issue to make that a bit clearer.
This looks good for a contributor to pick up. Marking as external. cc: @roryabraham though just cause it seems like it might be tied to the OptionsSelector (and focusedIndex) logic that was changed recently.
@jeet-dhandha umm once a PR is on staging, it takes ~7 days for a PR to be deployed to production.
It might take longer if there are deploy blockers or when major changes have been introduced (because QA time would increase).
Activity
melvin-bot commentedon Jul 14, 2022
Triggered auto assignment to @NikkiWines (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.NikkiWines commentedon Jul 15, 2022
Hmm @kbecciv I'm unable to reproduce this on staging v1.1.84-11. The users look like they're being added and removed correctly with no users being hidden:
Screen.Recording.2022-07-14.at.18.37.50.mov
kbecciv commentedon Jul 15, 2022
@NikkiWines Sorry, for confusion. But when you unselected one of your user - the rest of users are hidden on top of the list. You can see them only when you're scrolling. App behavior should be the same when you selecting and deselecting users.
[-]Group Chat - Previously selected users are hidden after unselecting user from group conversation[/-][+]Group Chat - View scrolls to Recents header when unselecting users from group conversation[/+]NikkiWines commentedon Jul 15, 2022
Ah, @kbecciv, I see! The issue is that it scrolls down to the
Recentsheading when you select a user instead of staying at the currently selected user's section. I've updated the issue to make that a bit clearer.This looks good for a contributor to pick up. Marking as external. cc: @roryabraham though just cause it seems like it might be tied to the
OptionsSelector(andfocusedIndex) logic that was changed recently.melvin-bot commentedon Jul 15, 2022
Triggered auto assignment to @jliexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.roryabraham commentedon Jul 15, 2022
I'll sign on as CME here since I'm very familiar with this code
40 remaining items
mvtglobally commentedon Aug 9, 2022
Issue not reproducible during KI retests. (First week)
jeet-dhandha commentedon Aug 9, 2022
@jliexpensify when does merged PR(s) gets deployed to production ?
rushatgabhane commentedon Aug 9, 2022
@jeet-dhandha umm once a PR is on staging, it takes ~7 days for a PR to be deployed to production.
It might take longer if there are deploy blockers or when major changes have been introduced (because QA time would increase).
mvtglobally commentedon Aug 16, 2022
Issue not reproducible during KI retests. (Second week)
kadiealexander commentedon Aug 22, 2022
Not overdue, waiting for PR to be deployed to production.
mvtglobally commentedon Aug 23, 2022
Issue not reproducible during KI retests. (Third week)
rushatgabhane commentedon Aug 30, 2022
@kadiealexander this issue can be settled because the code is on production.
The bot didn't comment because there was some issue in one of the release cycle
#10146 (comment)
mvtglobally commentedon Aug 30, 2022
Issue not reproducible during KI retests. (Fourth week)
kadiealexander commentedon Sep 1, 2022
@roryabraham @rushatgabhane could one of you please confirm what day this was deployed to production?
rushatgabhane commentedon Sep 1, 2022
@kadiealexander I'm sure it's 9 days ago - #10495
roryabraham commentedon Sep 2, 2022
Yep, lets pay this out now
kadiealexander commentedon Sep 2, 2022
Both paid! Thanks team :)