Skip to content

[$250] Group Chat - View scrolls to Recents header when unselecting users from group conversation #9918

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found during executing PR #9798

Action Performed:

  1. Go to staging.new.expensifail.com
  2. Log in with any use
  3. Tap on Fub menu
  4. Tab Group Chat
  5. Scroll and select the user
  6. Select a couple more users
  7. Unselect one of the user from the list

Expected Result:

View does not scroll after unselecting a user from a group conversation

Actual Result:

View scrolls down to the Recents header (hiding currently selected users) after unselecting a user from a group conversation

Workaround:

Yes, they can scroll up to see the users again

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.84.11

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220714-113103_Chrome.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Jul 14, 2022

    @melvin-bot

    Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. NikkiWines commented on Jul 15, 2022

    @NikkiWines
    Contributor

    Hmm @kbecciv I'm unable to reproduce this on staging v1.1.84-11. The users look like they're being added and removed correctly with no users being hidden:

    Screen.Recording.2022-07-14.at.18.37.50.mov
  3. kbecciv commented on Jul 15, 2022

    @kbecciv
    Author

    @NikkiWines Sorry, for confusion. But when you unselected one of your user - the rest of users are hidden on top of the list. You can see them only when you're scrolling. App behavior should be the same when you selecting and deselecting users.

  4. changed the title [-]Group Chat - Previously selected users are hidden after unselecting user from group conversation[/-] [+]Group Chat - View scrolls to Recents header when unselecting users from group conversation[/+] on Jul 15, 2022
  5. NikkiWines commented on Jul 15, 2022

    @NikkiWines
    Contributor

    Ah, @kbecciv, I see! The issue is that it scrolls down to the Recents heading when you select a user instead of staying at the currently selected user's section. I've updated the issue to make that a bit clearer.

    This looks good for a contributor to pick up. Marking as external. cc: @roryabraham though just cause it seems like it might be tied to the OptionsSelector (and focusedIndex) logic that was changed recently.

  6. removed their assignment
    on Jul 15, 2022
  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 15, 2022
  8. melvin-bot commented on Jul 15, 2022

    @melvin-bot

    Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  9. self-assigned this
    on Jul 15, 2022
  10. roryabraham commented on Jul 15, 2022

    @roryabraham
    Contributor

    I'll sign on as CME here since I'm very familiar with this code

  11. 40 remaining items

  12. mvtglobally commented on Aug 9, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  13. jeet-dhandha commented on Aug 9, 2022

    @jeet-dhandha
    Contributor

    @jliexpensify when does merged PR(s) gets deployed to production ?

  14. rushatgabhane commented on Aug 9, 2022

    @rushatgabhane
    Member

    @jeet-dhandha umm once a PR is on staging, it takes ~7 days for a PR to be deployed to production.
    It might take longer if there are deploy blockers or when major changes have been introduced (because QA time would increase).

  15. mvtglobally commented on Aug 16, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  16. kadiealexander commented on Aug 22, 2022

    @kadiealexander
    Contributor

    Not overdue, waiting for PR to be deployed to production.

  17. mvtglobally commented on Aug 23, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (Third week)

  18. rushatgabhane commented on Aug 30, 2022

    @rushatgabhane
    Member

    @kadiealexander this issue can be settled because the code is on production.

    The bot didn't comment because there was some issue in one of the release cycle

    #10146 (comment)

  19. mvtglobally commented on Aug 30, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (Fourth week)

  20. kadiealexander commented on Sep 1, 2022

    @kadiealexander
    Contributor

    @roryabraham @rushatgabhane could one of you please confirm what day this was deployed to production?

  21. rushatgabhane commented on Sep 1, 2022

    @rushatgabhane
    Member

    @kadiealexander I'm sure it's 9 days ago - #10495

  22. roryabraham commented on Sep 2, 2022

    @roryabraham
    Contributor

    Yep, lets pay this out now

  23. kadiealexander commented on Sep 2, 2022

    @kadiealexander
    Contributor

    Both paid! Thanks team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions