Skip to content

[Due for payment 2026-08-29] Payment issue for E/App PR#98704 #99231

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #98704
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/671728.
Contributor+ member who reviewed the PR - @situchan.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Aug 22, 2026

    @melvin-bot
    Author

    @situchan The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. situchan commented on Aug 22, 2026

    @situchan
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Inconsistency issue with backend

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/677583

    Regression Test Proposal

    Precondition:

    Requires a workspace with delayed submissions enabled, the Dynamic External Workflow approval mode and routed to user in DEW to be same as the workspace approver.

    Test:

    1. As an employee on the workspace, create an expense and submit the report.
    2. Click on Create Workspace from the composer in the same workspace chat.
    3. Enter an amount > Next.
    4. Verify that clicking on the report field shows only draft reports and does not include the submitted report from step 1.
    5. Submit the report.
    6. Verify that the report is submitted successfully.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-c31f-af7b-f296-1b59e79ff5e4
  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 22, 2026
  4. melvin-bot commented on Aug 28, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  5. melvin-bot commented on Aug 28, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  6. melvin-bot commented on Aug 31, 2026

    @melvin-bot
    Author

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. mallenexpensify commented on Sep 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @situchan due $250 via NewDot

  8. laurenreidexpensify commented on Sep 3, 2026

    @laurenreidexpensify
    Contributor

    $250 approved @situchan New Expensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions