You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Distance rates-Copy under Auto‑update government rate toggle is not as specified #99269
Version Number: v9.4.59-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#97936 Email or phone of affected tester (no customers):applausetester+ag220826@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 11/ Chrome, Samsung S23FE/ Android 16, iPhone 13 Mini/ iOS 26.5 App Component: Workspace Settings
Action Performed:
Preconditions: Use an Expensifail account.
Have a Control workspace where you're an admin, with Distance rates enabled.
Workspace currency is set to USD.
Go to workspace settings > Distance rates > Settings
Expected Result:
The copy displayed under the Auto‑update government rate toggle is: "Automatically create new rates when the United States publishes new guidance. Doesn't modify existing rates."
Actual Result:
The copy displayed under the Auto‑update government rate toggle is: "Automatically create new rates when the United States publishes new guidance."
The sentence "Doesn't modify existing rates." is missing.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #97936 - "feat: add auto-update government distance rates toggle" by Krishna2323 (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
This is a copy-only miss in a brand-new feature: the trailing sentence "Doesn't modify existing rates." was never added to the source string in any locale. A one-line copy fix is far safer and simpler than reverting the entire feature PR.
Assigned: Krishna2323 (PR author), neil-marcellini and thelullabyy (approving reviewers) — already assigned Labels: No changes. Frontend bug, so DeployBlockerCash is kept. DeployBlocker was not present, so nothing to remove.
The bug is staging-only because the feature does not exist in production yet.
The reported "actual" copy exactly matches the current source string: for US, countryPhrase = "the United States", producing "Automatically create new rates when the United States publishes new guidance."
Verification
Rendering component: src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx line 227 renders translate('workspace.distanceRates.autoUpdateGovernmentRateDescription', translate(countryPhraseTranslationKey)) as the toggle subtitle. This is the only string used for the subtitle (no concatenation with a second string).
English source string: src/languages/en.ts line 7442.
Spanish source string: src/languages/es.ts line 7216.
A repo-wide grep for "Doesn't modify", "modify existing", and "existing rates" returns zero matches anywhere in src/. The sentence was never added to any string in any locale.
Confirmed via the PR diff that feat: add auto-update government distance rates toggle #97936 added autoUpdateGovernmentRateDescription to every locale (en, es, de, fr, it, ja, nl, pl, pt-BR, zh-hans, el) and none of them include the trailing sentence — so this is not a translation-only miss; the English source itself is missing it.
Permalinks (App HEAD f2e972156affcdfd5386ca5cbe77273af7754535):
The description copy shipped without the second sentence. The source en string ends at "...publishes new guidance." and every translation mirrored that shortened copy, so the required "Doesn't modify existing rates." disclaimer is absent on all platforms.
Suggested Fix
Append the missing sentence to the autoUpdateGovernmentRateDescription string in every locale file. For the two primary locales:
English (src/languages/en.ts line 7442):
autoUpdateGovernmentRateDescription: (countryPhrase: string)=>`Automatically create new rates when ${countryPhrase} publishes new guidance. Doesn't modify existing rates.`,
Spanish (src/languages/es.ts line 7216):
autoUpdateGovernmentRateDescription: (countryPhrase: string)=>`Crea automáticamente nuevas tasas cuando ${countryPhrase} publique nuevas directrices. No modifica las tasas existentes.`,
The same trailing sentence should be added to the remaining locale files (de, fr, it, ja, nl, pl, pt-BR, zh-hans, el) to keep translations in sync.
Activity
applause-bot commentedon Aug 23, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/cc1d438b5c4858bcbee96389c05917f8878f4ea718c39407c01ae6b7f00af27f
melvin-bot commentedon Aug 23, 2026
@neil-marcellini recently merged #97936, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Aug 23, 2026
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 23, 2026
@neil-marcellini @thelullabyy you have been assigned to this deploy blocker because you reviewed the offending PR: #97936
melvin-bot commentedon Aug 23, 2026
@Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #97936
melvin-bot commentedon Aug 23, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Aug 23, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #97936 - "feat: add auto-update government distance rates toggle" by
Krishna2323(High confidence)Related Issues: None
Recommendation: ROLL FORWARD
This is a copy-only miss in a brand-new feature: the trailing sentence "Doesn't modify existing rates." was never added to the source string in any locale. A one-line copy fix is far safer and simpler than reverting the entire feature PR.
Assigned:
Krishna2323(PR author),neil-marcelliniandthelullabyy(approving reviewers) — already assignedLabels: No changes. Frontend bug, so
DeployBlockerCashis kept.DeployBlockerwas not present, so nothing to remove.📋 Detailed Analysis
Evidence
workspace.distanceRates.autoUpdateGovernmentRateDescriptionacross all locale files.countryPhrase= "the United States", producing "Automatically create new rates when the United States publishes new guidance."Verification
src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsxline 227 renderstranslate('workspace.distanceRates.autoUpdateGovernmentRateDescription', translate(countryPhraseTranslationKey))as the toggle subtitle. This is the only string used for the subtitle (no concatenation with a second string).src/languages/en.tsline 7442.src/languages/es.tsline 7216.src/. The sentence was never added to any string in any locale.autoUpdateGovernmentRateDescriptionto every locale (en, es, de, fr, it, ja, nl, pl, pt-BR, zh-hans, el) and none of them include the trailing sentence — so this is not a translation-only miss; the English source itself is missing it.Permalinks (App HEAD
f2e972156affcdfd5386ca5cbe77273af7754535):Root Cause
The description copy shipped without the second sentence. The source
enstring ends at "...publishes new guidance." and every translation mirrored that shortened copy, so the required "Doesn't modify existing rates." disclaimer is absent on all platforms.Suggested Fix
Append the missing sentence to the
autoUpdateGovernmentRateDescriptionstring in every locale file. For the two primary locales:English (
src/languages/en.tsline 7442):Spanish (
src/languages/es.tsline 7216):The same trailing sentence should be added to the remaining locale files (de, fr, it, ja, nl, pl, pt-BR, zh-hans, el) to keep translations in sync.
view run
Krishna2323 commentedon Aug 24, 2026
It's expected and was changed here. I forgot to update the PR test steps, but I've updated them now. We can close this issue.
robertjchen commentedon Aug 24, 2026
thanks!