You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-04] [Domain Control - Request access] [FE] Review pending domain admin requests on the Domain Admins page #99383
On the Domain Admins page, show the pending requests in a "Requests" group above the "Admins" group. One row per requester, with "Approve" and "Deny". Show a green dot on the Domain admins item in the left menu while requests are pending.
Admins get every requester from OpenApp and OpenDomainPage. OpenDomainPage also sends the requesters' missing personal details, so the rows can show a name and an avatar. A requester can come from another domain.
Action
Command
Parameters
Approve
AddDomainAdmin
targetEmail, domainAccountID
Deny
DeclineDomainAdminshipRequest
targetAccountID, domainAccountID
Both set domain_adminRequesters.<accountID> to null for the admins and the requester.
"Deny" errors go to domainErrors_<domainAccountID>, under adminshipRequesterErrors.<targetAccountID>.errors.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: NA
Link to the comment on the Issue: NA
It's a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Open App
Sign in as User A, who is an admin of a domain (e.g. domain.com).
Sign in as User B in another browser/incognito window.
As User B, go to Workspaces > Domains > New, and try to add domain.com.
On the "Domain already exists" screen, tap Request access.
As User A, go to Workspaces > Domains > domain.com > Admins.
Verify a "Requests" section appears above "Admins" showing User B, with Approve and Deny buttons.
Verify a green dot shows on the Admins menu item, on the domain.com row in the Domains list, and on the Workspaces tab in the bottom nav.
Tap Approve — verify User B moves into the Admins group and the dots disappear.
Revoke User B admin access
Repeat steps 2-7 and tap Deny instead - verify the request disappears and the dots disappear too.
But since it was a fairly complex PR and testing took quite a long time, and all the regressions were edge cases
Could we leave the default payment here, please?
changed the title [-][Domain Control - Request access] [FE] Review pending domain admin requests on the Domain Admins page[/-][+][Due for payment 2026-10-04] [Domain Control - Request access] [FE] Review pending domain admin requests on the Domain Admins page[/+]on Oct 4, 2026
Activity
melvin-bot commentedon Aug 28, 2026
@jakubstec Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Sep 1, 2026
@war-in Whoops! This issue is 2 days overdue. Let's get this updated quick!
31 remaining items
ZhenjaHorbach commentedon Oct 2, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: NA
Link to the comment on the Issue: NA
It's a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
ZhenjaHorbach commentedon Oct 2, 2026
Okay
We had 2 deploy blockers that were edge cases
#101042
#101056
But since it was a fairly complex PR and testing took quite a long time, and all the regressions were edge cases
Could we leave the default payment here, please?
CC: @mountiny
[-][Domain Control - Request access] [FE] Review pending domain admin requests on the Domain Admins page[/-][+][Due for payment 2026-10-04] [Domain Control - Request access] [FE] Review pending domain admin requests on the Domain Admins page[/+]melvin-bot commentedon Oct 4, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mountiny commentedon Oct 4, 2026
Since the same people handled the edge cases i think we can keep the normal bounty
melvin-bot commentedon Oct 4, 2026
Payment Summary
Resolving PRs:
feat: show pending requests on the domain admins page #100161
Contributor: @war-in does not require payment (Contractor)
Contributor: @jakubstec does not require payment (Contractor)
Reviewer: @ZhenjaHorbach owed $175 via NewDot
Contributor: @rayane-d does not require payment (Contractor)
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 6, 2026
Payment Summary
Contributor+: @ZhenjaHorbach due $250 via NewDot
garrettmknight commentedon Nov 5, 2026
$250 approved for @ZhenjaHorbach