Skip to content

[Due for payment 2026-10-04] [Domain Control - Request access] [FE] Review pending domain admin requests on the Domain Admins page #99383

Closed

Description

@rayane-d

Part of #97053

On the Domain Admins page, show the pending requests in a "Requests" group above the "Admins" group. One row per requester, with "Approve" and "Deny". Show a green dot on the Domain admins item in the left menu while requests are pending.

Design

Image

Data and commands

Pending requests are in the domain Onyx object:

domain_<domainAccountID>: {
    accountID: 111,
    email: "+@test.com",
    domain_adminRequesters: {"202": "read", "303": "read"}
}

Admins get every requester from OpenApp and OpenDomainPage. OpenDomainPage also sends the requesters' missing personal details, so the rows can show a name and an avatar. A requester can come from another domain.

Action Command Parameters
Approve AddDomainAdmin targetEmail, domainAccountID
Deny DeclineDomainAdminshipRequest targetAccountID, domainAccountID

Both set domain_adminRequesters.<accountID> to null for the admins and the requester.

"Deny" errors go to domainErrors_<domainAccountID>, under adminshipRequesterErrors.<targetAccountID>.errors.

Out of scope: bulk actions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Aug 25, 2026
  2. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    @jakubstec Whoops! This issue is 2 days overdue. Let's get this updated quick!

  3. melvin-bot commented on Sep 1, 2026

    @melvin-bot

    @war-in Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. 31 remaining items

  5. ZhenjaHorbach commented on Oct 2, 2026

    @ZhenjaHorbach
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: NA
      Link to the comment on the Issue: NA

    It's a new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Open App
    2. Sign in as User A, who is an admin of a domain (e.g. domain.com).
    3. Sign in as User B in another browser/incognito window.
    4. As User B, go to Workspaces > Domains > New, and try to add domain.com.
    5. On the "Domain already exists" screen, tap Request access.
    6. As User A, go to Workspaces > Domains > domain.com > Admins.
    7. Verify a "Requests" section appears above "Admins" showing User B, with Approve and Deny buttons.
    8. Verify a green dot shows on the Admins menu item, on the domain.com row in the Domains list, and on the Workspaces tab in the bottom nav.
    9. Tap Approve — verify User B moves into the Admins group and the dots disappear.
    10. Revoke User B admin access
    11. Repeat steps 2-7 and tap Deny instead - verify the request disappears and the dots disappear too.

    Do we agree 👍 or 👎

  6. ZhenjaHorbach commented on Oct 2, 2026

    @ZhenjaHorbach
    Contributor

    Okay
    We had 2 deploy blockers that were edge cases

    #101042
    #101056

    But since it was a fairly complex PR and testing took quite a long time, and all the regressions were edge cases
    Could we leave the default payment here, please?

    CC: @mountiny

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Oct 4, 2026
  8. changed the title [-][Domain Control - Request access] [FE] Review pending domain admin requests on the Domain Admins page[/-] [+][Due for payment 2026-10-04] [Domain Control - Request access] [FE] Review pending domain admin requests on the Domain Admins page[/+] on Oct 4, 2026
  9. melvin-bot commented on Oct 4, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. mountiny commented on Oct 4, 2026

    @mountiny
    Contributor

    Since the same people handled the edge cases i think we can keep the normal bounty

  11. melvin-bot commented on Oct 4, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  12. mallenexpensify commented on Oct 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @ZhenjaHorbach due $250 via NewDot

  13. garrettmknight commented on Nov 5, 2026

    @garrettmknight
    Contributor

    $250 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions