Skip to content

Migrate remaining dynamic-icons Avatar usages (follow-up to #98031) #99461

Closed

Description

@MelvinBot

Background

PR #98031 migrated raw Avatar call sites across 33 files to UserAvatar (or Icon / AccountAvatar where appropriate), removing duplicated avatar-resolution logic and per-site Onyx lookups.

As called out in that PR, some Avatar uses were intentionally left un-migrated because they depend on dynamic icons and can render as either a User or a workspace/Avatar depending on runtime data.

Task

Finish the migration by handling the remaining dynamic-icons Avatar call sites that PR #98031 left in place:

  1. Audit the remaining raw Avatar usages that resolve their type dynamically at runtime.
  2. Migrate each to the appropriate abstraction (UserAvatar, AccountAvatar, Icon, or a suitable component that handles the dynamic user-vs-workspace case) so fallback and tooltip behavior stays consistent.
  3. Verify no visual/behavioral regressions across the affected surfaces (chats, avatars in previews, member/profile pages, etc.).

Related

  • Parent: #95600 — [M4] Migrate User Avatar usages
  • Prior PR: #98031 — Migrate User Avatar usages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions