Skip to content

[Due for payment 2026-09-07] Android - Home - Concierge prompt box is still focused after closing keyboard via gesture. #99499

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.61.0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98336
Email or phone of affected tester (no customers): ibellicotest+2766@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Other

Action Performed:

  1. Open the Expensify app.
  2. Navigate to "Home"
  3. Tap on Concierge prompt box to focus it.
  4. Close keyboard by tapping outside of it.
  5. Note that after keyboard is closed, box is no longer focused.
  6. Tap on prompt box again to focus it.
  7. Close keyboard via back gesture.
  8. Note that keyboard is closed but box is still focused.

Expected Result:

Once keyboard is closed, Concierge prompt box should be no longer focused.

Actual Result:

After closing keyboard via gesture, Concierge prompt box is still focused.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7242871_1787703749645.Prompt.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7242871

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. applause-bot commented on Aug 26, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/7e706ca4ff896c9ddf4e6df41ff32eb2d04f965ebeba5ae1ef9238a4b53db4e1

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 26, 2026
  3. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #98336

  4. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @puneetlath @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #98336

  5. github-actions commented on Aug 26, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #98336

  7. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Aug 26, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #98336 - "[Home Page] Add Concierge prompt box to home For You section" by @adamgrzybowski (High confidence)
    Related Issues: #94497 (feature request implemented by the PR)

    Recommendation: ROLL FORWARD

    The Concierge prompt box is a brand-new component introduced entirely by this PR, so the regression is unquestionably from #98336. However, reverting would pull the whole Home "For You" Concierge feature (30+ files) for a minor Android-only focus-state issue — a small targeted fix is the better path.

    Assigned: @adamgrzybowski (PR author), @puneetlath and @ZhenjaHorbach (approving reviewers) — already auto-assigned to this issue.
    Labels: No changes. DeployBlockerCash is kept (App PR caused it → App deploy is blocked). No DeployBlocker label was present, so nothing to remove.

    📋 Detailed Analysis

    Evidence

    • The entire src/pages/home/ForYouSection/ConciergePromptBox.tsx file (266 lines) is new in PR [Home Page] Add Concierge prompt box to home For You section #98336 — there is no prior version, so the box cannot have regressed from any earlier PR.
    • The bug is reproducible on staging only ("N/A - new feature, doesn't exist in prod"), consistent with a just-shipped feature.
    • The symptom (focus indicator persisting after keyboard dismissal) maps directly to how this component tracks and renders focus state.

    Verification

    • Affected file: src/pages/home/ForYouSection/ConciergePromptBox.tsx.
    • git log confirms the file was first added by this PR (merged 2026-08-25).
    • The focus visual is driven by local isFocused state:
      • The box border color switches on isFocused: ConciergePromptBox.tsx#L143
      • isFocused is set/cleared only by the Composer's onFocus/onBlur: ConciergePromptBox.tsx#L225-L226
      • The component already reads keyboard state via useKeyboardState (L64) but only uses isKeyboardShown for hotkey handling — it never uses it to blur the input or reset focus.

    Root Cause

    On Android, dismissing the keyboard with the back gesture hides the native keyboard without blurring the underlying JS TextInput. React Native therefore does not fire onBlur, so setIsFocused(false) at L226 never runs and the focused border color at L143 stays applied. When the keyboard is dismissed by tapping outside, RN blurs the input and onBlur fires normally, which is why that path behaves correctly (steps 3–5 of the repro).

    The component relies solely on the Composer's onBlur to track focus and has no keyboard-hide handling to cover the Android back-gesture case.

    Suggested targeted fix

    When the keyboard transitions to hidden (e.g. Keyboard.addListener('keyboardDidHide', …), or by reacting to isKeyboardShown going true → false), blur the Composer and/or setIsFocused(false) so the focus indicator clears regardless of how the keyboard was dismissed. This is far less disruptive than reverting the whole feature.

  9. 11 remaining items

  10. jmusial commented on Aug 26, 2026

    @jmusial
    Contributor

    Opened a PR here

  11. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. mitarachim commented on Aug 28, 2026

    @mitarachim

    Deploy Blocker #99804 was identified to be related to the PR #99540 that attempted to fix this issue.

  13. changed the title [-]Android - Home - Concierge prompt box is still focused after closing keyboard via gesture.[/-] [+][Due for payment 2026-09-07] Android - Home - Concierge prompt box is still focused after closing keyboard via gesture.[/+] on Aug 31, 2026
  14. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    @ZhenjaHorbach

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.64-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-07. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  15. ZhenjaHorbach commented on Sep 1, 2026

    @ZhenjaHorbach
    Contributor

    @grgia @puneetlath
    Let's close this!

  16. grgia commented on Sep 1, 2026

    @grgia
    Contributor

    Closing

  17. moved this from Backlog to Done in Home pageon Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions