Skip to content

[Due for payment 2026-09-02] iOS - Home - Concierge prompt box remains expanded after sending attachment #99522

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.61-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98336
Email or phone of affected tester (no customers): sdsiodjnosdjiodsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.6.1
App Component: Other

Action Performed:

  1. Launch Expensify app.
  2. Go to Home.
  3. Tap on Concierge prompt box.
  4. Create 4 empty lines.
  5. Tap + > Add attachment > Choose from gallery.
  6. Select a photo.
  7. Tap Send.
  8. Tap app back button.

Expected Result:

Concierge prompt box will be collapsed after sending attachment.

Actual Result:

Concierge prompt box remains expanded after sending attachment.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7243071_1787729129719.ScreenRecording_08-26-2026_15-22-31_1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7243071

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. applause-bot commented on Aug 26, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/8094db3eaf16877c80765eb5f7964421742ef94d3cd20ee3ad42709358142a28

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 26, 2026
  3. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #98336

  4. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @puneetlath @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #98336

  5. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #98336

  6. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Aug 26, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Aug 26, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #98336 - "Add Concierge prompt box to Home 'For You' section" by adamgrzybowski (High confidence)
    Related Issues: #94497 (the feature request this PR implemented)

    Recommendation: ROLL FORWARD

    PR #98336 introduces the entire Concierge prompt box + attachment flow (the feature doesn't exist in production, matching "N/A in production"), so it is unquestionably the cause — but it is a large (~40 file) new feature and this is a minor, iOS-only visual glitch (the box stays tall; the attachment still sends correctly). A targeted fix is far simpler and lower-risk than reverting the whole feature, and the PR author is already assigned.

    Assigned: adamgrzybowski (PR author), puneetlath and ZhenjaHorbach (approving reviewers) — already assigned to this issue.
    Labels: No change. This is a frontend bug, so DeployBlockerCash (App deploy) is correctly kept. DeployBlocker (Web) is not present, so nothing to remove.

    📋 Detailed Analysis

    Evidence

    • PR [Home Page] Add Concierge prompt box to home For You section #98336 adds the Concierge prompt box to Home ("For You" section) plus the attachment send flow. New files include src/pages/home/ForYouSection/ConciergePromptBox.tsx and src/pages/home/ForYouSection/useConciergeAttachmentPicker.ts — exactly the component and flow in the repro steps.
    • The feature is brand new (not in production), which matches the report: reproducible on staging, N/A in production.
    • It is the only PR on the current StagingDeployCash (9.4.61-0) that touches this feature; no other candidate PR is involved.

    Verification

    • Affected component: src/pages/home/ForYouSection/ConciergePromptBox.tsx (the composer whose height stays expanded).
    • Attachment send path: ConciergePromptBox → useConciergeAttachmentPicker (opens REPORT_ADD_ATTACHMENT modal with confirmLeavesScreen: true) → on confirm the modal invokes the sendAttachment callback.
    • All of these files are added/modified by PR [Home Page] Add Concierge prompt box to home For You section #98336 (confirmed via gh pr view 98336 --json files).

    Root Cause

    Both the text-send and attachment-send paths clear the composer the same way — via React controlled state:

    clearInput() only does setValue('') + setSelection({start:0,end:0}). The composer is the native auto-growing multiline RNMarkdownTextInput (Composer/implementation/index.native.tsx), whose height is driven by the native intrinsic content size, not by JS.

    The difference between the two paths is focus/timing when the state is cleared:

    • Text send: submit() runs while the prompt box is on-screen and focused. Setting value='' re-renders the focused native input, iOS recomputes its content size, and the box collapses. Works.
    • Attachment send: the confirm fires from inside the AttachmentModalScreen, and because useConciergeAttachmentPicker passes confirmLeavesScreen: true, submitAndClose() on native does onClose({shouldCallDirectly: true}) then confirm() — see AttachmentModalBaseContent/index.tsx#L175-L203. So clearInput()/setValue('') runs against a composer that is unfocused and was just uncovered by the closing modal. On iOS a multiline TextInput whose text is set programmatically while it is not first responder does not recompute its intrinsic content height until it is re-laid out or refocused, so the box keeps its stale, expanded (4-line) height. This is precisely why the bug is iOS-App-only.

    The standard ReportActionCompose flow avoids this by clearing the composer imperatively through its native ref (the deferred composerRef.clearWorklet the base modal alludes to in its comment at index.tsx#L201), which resets both the text and the native height. ConciergePromptBox clears via controlled state only and holds no composer ref, so nothing forces the native re-measure.

    Suggested targeted fix

    In ConciergePromptBox, hold a ref to the Composer and, in clearInput(), clear/reset it imperatively (mirroring ReportActionCompose) so the native TextInput re-measures its height — or force a re-measure/blur-refocus on the native input after setValue(''). Because the attachment path clears while the composer is unfocused and off-screen, deferring the clear (e.g. requestAnimationFrame / InteractionManager after the screen is focused) or driving it through the native ref is required; controlled state alone is insufficient on iOS.

    Note: This is an iOS-App-only bug (native intrinsic-height re-measure timing), so it cannot be reproduced on web — no web verification was run.


    view run

  9. mhawryluk commented on Aug 26, 2026

    @mhawryluk
    Member

    @GCyganek is looking into this one

  10. m-natarajan commented on Aug 26, 2026

    @m-natarajan

    Issue is not reproducible on iPhone 11 Pro / iOS 18.4.1 in v9.4.61-3

    IMG_9201.MP4
  11. puneetlath commented on Aug 26, 2026

    @puneetlath
    Contributor

    Great! Fix worked.

  12. changed the title [-]iOS - Home - Concierge prompt box remains expanded after sending attachment[/-] [+][Due for payment 2026-09-02] iOS - Home - Concierge prompt box remains expanded after sending attachment[/+] on Aug 26, 2026
  13. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @ZhenjaHorbach

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-02. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions