You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Home-Expand button is missing on enlarged compose box. #99551
Version Number: V9.4.61-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98336 Email or phone of affected tester (no customers):dreamnitethedragon+vegst@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Redmi note 10s android 13 App Component: User Settings
Action Performed:
Launch app
In home page, enter space multiple times, add a text and tap space to enlarge compose box
Expected Result:
Expand button must be shown on enlarged compose box.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #98336 - "[Home Page] Add Concierge prompt box to home For You section" by @adamgrzybowski (High confidence) Related Issues: #94497 (feature request that #98336 implemented)
Recommendation: DEMOTE
The home "Ask Concierge" prompt box added by #98336 is a new, lightweight composer that intentionally has no Expand/Collapse (full-size) button — the input is fully functional and scrolls internally after 5 lines, so this is a minor UX‑parity gap on a brand‑new, staging‑only discovery feature, not a functional regression worth blocking the deploy. If product wants expand parity, it should be a targeted fast‑follow, not a revert of this 40‑file feature PR.
Assigned: @adamgrzybowski (PR author), @puneetlath and @ZhenjaHorbach (approving reviewers) — already auto-assigned to this issue by melvin-bot. Labels: No changes. DeployBlockerCash is kept (frontend bug with a causing App PR, and staging-only new feature). No DeployBlocker label is present.
📋 Detailed Analysis
Evidence
The reproduction is on the Home page compose box. The only Home-page compose box is the new ConciergePromptBox, added by [Home Page] Add Concierge prompt box to home For You section #98336 (merged 2026-08-25, in staging as V9.4.61). The feature does not exist in production, which matches "Reproducible in production?: N/A - new feature."
The "Expand" button the tester expects is the report composer's Expand/Collapse (full-size) control. That control lives only in the report composer, at AttachmentPickerWithMenuItems.tsx L497-L505 (<ExpandCollapseButton .../>).
The new ConciergePromptBox never renders that button. Its composer row contains only the "+" attachment button and the Send button — see ConciergePromptBox.tsx L137-L260. A grep for "Expand" in this file returns 0 matches, and there is no ExpandCollapseButton/isComposerFullSize usage anywhere under src/pages/home/.
I checked that [Home Page] Add Concierge prompt box to home For You section #98336 did NOT break the report composer's real Expand button. The PR only refactored that button's inline layout styles into two shared named styles, composerButtonColumn (index.ts L2534) and composerButtonStack (index.ts L2542), reused by the new box. The extracted values are byte-equivalent to the previous inline atoms (flexBasis: 40 + 3*2 = 46, flexGrow:0/flexShrink:0 for the column; column-reverse + flexWrap:wrap + overflow:hidden + paddingVertical:3 for the stack), so the report composer's Expand button behavior is unchanged.
Root Cause
There is no regression: the report composer's Expand button still appears/hides correctly. The report on Home is an expectation mismatch — the tester applied the report composer's mental model to the new ConciergePromptBox, which deliberately omits the Expand/Collapse (full-size) button and instead scrolls internally past 5 lines. In the shared composerButtonStack (a column-reverse + flexWrap:wrap + overflow:hidden stack), the second child wraps into a clipped column when there isn't room for two buttons. In the report composer that second child is the Expand button (hidden only when the composer is too short); in ConciergePromptBox the second child is an empty spacer, and the "+" button (first child) always stays visible. So no button actually disappears on the Home box — the Expand button was simply never part of this new component.
Activity
applause-bot commentedon Aug 26, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/4b2507c3c90c84254db0cf73c1551ff0f09b7db65145dd4370e25fb291025a47
melvin-bot commentedon Aug 26, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #98336
github-actions commentedon Aug 26, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 26, 2026
@puneetlath @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #98336
melvin-bot commentedon Aug 26, 2026
@adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #98336
melvin-bot commentedon Aug 26, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Aug 26, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #98336 - "[Home Page] Add Concierge prompt box to home For You section" by @adamgrzybowski (High confidence)
Related Issues: #94497 (feature request that #98336 implemented)
Recommendation: DEMOTE
The home "Ask Concierge" prompt box added by #98336 is a new, lightweight composer that intentionally has no Expand/Collapse (full-size) button — the input is fully functional and scrolls internally after 5 lines, so this is a minor UX‑parity gap on a brand‑new, staging‑only discovery feature, not a functional regression worth blocking the deploy. If product wants expand parity, it should be a targeted fast‑follow, not a revert of this 40‑file feature PR.
Assigned: @adamgrzybowski (PR author), @puneetlath and @ZhenjaHorbach (approving reviewers) — already auto-assigned to this issue by melvin-bot.
Labels: No changes.
DeployBlockerCashis kept (frontend bug with a causing App PR, and staging-only new feature). NoDeployBlockerlabel is present.📋 Detailed Analysis
Evidence
ConciergePromptBox, added by [Home Page] Add Concierge prompt box to home For You section #98336 (merged 2026-08-25, in staging as V9.4.61). The feature does not exist in production, which matches "Reproducible in production?: N/A - new feature."AttachmentPickerWithMenuItems.tsxL497-L505 (<ExpandCollapseButton .../>).ConciergePromptBoxnever renders that button. Its composer row contains only the "+" attachment button and the Send button — seeConciergePromptBox.tsxL137-L260. A grep for "Expand" in this file returns 0 matches, and there is noExpandCollapseButton/isComposerFullSizeusage anywhere undersrc/pages/home/.MAX_INPUT_LINES = 5at L42-L43, applied viamaxLines={MAX_INPUT_LINES}at L228. The Figma/feature spec in [Due for payment 2026-09-02] Add a "Ask Concierge" box to the top of the home page #94497 does not include a full-size expand control.Verification
ConciergePromptBoxcompose box (src/pages/home/ForYouSection/ConciergePromptBox.tsx), a file created by [Home Page] Add Concierge prompt box to home For You section #98336.composerButtonColumn(index.ts L2534) andcomposerButtonStack(index.ts L2542), reused by the new box. The extracted values are byte-equivalent to the previous inline atoms (flexBasis: 40 + 3*2 = 46,flexGrow:0/flexShrink:0for the column;column-reverse+flexWrap:wrap+overflow:hidden+paddingVertical:3for the stack), so the report composer's Expand button behavior is unchanged.Root Cause
There is no regression: the report composer's Expand button still appears/hides correctly. The report on Home is an expectation mismatch — the tester applied the report composer's mental model to the new
ConciergePromptBox, which deliberately omits the Expand/Collapse (full-size) button and instead scrolls internally past 5 lines. In the sharedcomposerButtonStack(acolumn-reverse+flexWrap:wrap+overflow:hiddenstack), the second child wraps into a clipped column when there isn't room for two buttons. In the report composer that second child is the Expand button (hidden only when the composer is too short); inConciergePromptBoxthe second child is an empty spacer, and the "+" button (first child) always stays visible. So no button actually disappears on the Home box — the Expand button was simply never part of this new component.puneetlath commentedon Aug 26, 2026
Similar to the mentions, I don't feel strongly that we need to support expanding the box here. What do you think @shawnborton?
puneetlath commentedon Aug 26, 2026
Closing as discussed here: expensify.slack.com/archives/C01GTK53T8Q/p1787759877638149?thread_ts=1787752406.280489&cid=C01GTK53T8Q
shawnborton commentedon Aug 26, 2026
Agree, we purposely did not implement this because there's no real good way to do it from a variable height container card.