Skip to content

Home-Expand button is missing on enlarged compose box. #99551

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: V9.4.61-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98336
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redmi note 10s android 13
App Component: User Settings

Action Performed:

  1. Launch app
  2. In home page, enter space multiple times, add a text and tap space to enlarge compose box

Expected Result:

Expand button must be shown on enlarged compose box.

Actual Result:

Expand button is missing on enlarged compose box.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7243158_1787738738043.Screenrecorder-2026-08-26-15-30-41-686.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7243158

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 26, 2026
  2. applause-bot commented on Aug 26, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/4b2507c3c90c84254db0cf73c1551ff0f09b7db65145dd4370e25fb291025a47

  3. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #98336

  4. github-actions commented on Aug 26, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @puneetlath @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #98336

  6. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #98336

  7. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Aug 26, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #98336 - "[Home Page] Add Concierge prompt box to home For You section" by @adamgrzybowski (High confidence)
    Related Issues: #94497 (feature request that #98336 implemented)

    Recommendation: DEMOTE

    The home "Ask Concierge" prompt box added by #98336 is a new, lightweight composer that intentionally has no Expand/Collapse (full-size) button — the input is fully functional and scrolls internally after 5 lines, so this is a minor UX‑parity gap on a brand‑new, staging‑only discovery feature, not a functional regression worth blocking the deploy. If product wants expand parity, it should be a targeted fast‑follow, not a revert of this 40‑file feature PR.

    Assigned: @adamgrzybowski (PR author), @puneetlath and @ZhenjaHorbach (approving reviewers) — already auto-assigned to this issue by melvin-bot.
    Labels: No changes. DeployBlockerCash is kept (frontend bug with a causing App PR, and staging-only new feature). No DeployBlocker label is present.

    📋 Detailed Analysis

    Evidence

    • The reproduction is on the Home page compose box. The only Home-page compose box is the new ConciergePromptBox, added by [Home Page] Add Concierge prompt box to home For You section #98336 (merged 2026-08-25, in staging as V9.4.61). The feature does not exist in production, which matches "Reproducible in production?: N/A - new feature."
    • The "Expand" button the tester expects is the report composer's Expand/Collapse (full-size) control. That control lives only in the report composer, at AttachmentPickerWithMenuItems.tsx L497-L505 (<ExpandCollapseButton .../>).
    • The new ConciergePromptBox never renders that button. Its composer row contains only the "+" attachment button and the Send button — see ConciergePromptBox.tsx L137-L260. A grep for "Expand" in this file returns 0 matches, and there is no ExpandCollapseButton/isComposerFullSize usage anywhere under src/pages/home/.
    • This is by design for the feature: instead of expanding, the input caps its growth and scrolls internally after 5 lines — MAX_INPUT_LINES = 5 at L42-L43, applied via maxLines={MAX_INPUT_LINES} at L228. The Figma/feature spec in [Due for payment 2026-09-02] Add a "Ask Concierge" box to the top of the home page #94497 does not include a full-size expand control.

    Verification

    Root Cause

    There is no regression: the report composer's Expand button still appears/hides correctly. The report on Home is an expectation mismatch — the tester applied the report composer's mental model to the new ConciergePromptBox, which deliberately omits the Expand/Collapse (full-size) button and instead scrolls internally past 5 lines. In the shared composerButtonStack (a column-reverse + flexWrap:wrap + overflow:hidden stack), the second child wraps into a clipped column when there isn't room for two buttons. In the report composer that second child is the Expand button (hidden only when the composer is too short); in ConciergePromptBox the second child is an empty spacer, and the "+" button (first child) always stays visible. So no button actually disappears on the Home box — the Expand button was simply never part of this new component.

  9. puneetlath commented on Aug 26, 2026

    @puneetlath
    Contributor

    Similar to the mentions, I don't feel strongly that we need to support expanding the box here. What do you think @shawnborton?

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 26, 2026
  11. puneetlath commented on Aug 26, 2026

    @puneetlath
    Contributor
  12. shawnborton commented on Aug 26, 2026

    @shawnborton
    Contributor

    Agree, we purposely did not implement this because there's no real good way to do it from a variable height container card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions