You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-04] Home - Draft text is not cleared after clearing cache in Home search box. #99555
Version Number: V9.4.61-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98336 Email or phone of affected tester (no customers):dreamnitethedragon+vegst@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Redmi note 10s android 13 App Component: User Settings
Action Performed:
Launch app
In Home, search box enter a text
Go to troubleshoot - clear cache
Go to Home and note text is not cleared
Go to concierge
Enter a text
Go to troubleshoot and clear cache
Go to to Concierge
Note draft text is cleared
Expected Result:
Draft text must be cleared after clearing cache in Home search box.
Actual Result:
Draft text is not cleared after clearing cache in Home search box.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #98336 - "[Home Page] Add Concierge prompt box to home For You section" by @adamgrzybowski (High confidence) Related Issues: #94497 (feature request implemented by the PR)
Recommendation: ROLL FORWARD
The confirmed cause is a brand-new feature; reverting the whole ~266-line PR (plus attachment/date/style refactors) is disproportionate for a stale-draft edge case that only appears after a manual "Clear cache". A small targeted fix is preferable. Note: severity is low (no data loss, no crash, functionality unaffected), so the team may reasonably choose to DEMOTE — but I am keeping DeployBlockerCash because an App PR caused the bug and I do not remove App-deploy blocker labels for App-caused issues.
Assigned: @adamgrzybowski (PR author), @puneetlath and @ZhenjaHorbach (approving reviewers) — already assigned on the issue. Labels: No changes. Only DeployBlockerCash was present; this is a Frontend bug so it is correctly kept. No DeployBlocker (Web) label was present to remove.
📋 Detailed Analysis
Evidence
The "Home search box" in the repro is the new Concierge prompt box on the Home "For You" section, added exclusively by PR [Home Page] Add Concierge prompt box to home For You section #98336 (src/pages/home/ForYouSection/ConciergePromptBox.tsx is a new file in that PR). This is a new feature not present in production, which matches "reproducible in staging, N/A in prod".
"Clear cache" (Troubleshoot) calls clearOnyxAndResetApp, which wipes Onyx storage (clearOnyxAndSeedFullReconnect(KEYS_TO_PRESERVE)) but does not unmount/remount the React tree — App.ts#L924-L978.
Root Cause
"Clear cache" clears Onyx, not React component state. The Concierge comment composer reads its draft from Onyx (REPORT_DRAFT_COMMENT), so wiping Onyx makes it re-render empty — correct behavior. The new Home Concierge prompt box holds its draft only in useState('') (ConciergePromptBox.tsx#L69), which survives the Onyx wipe because the component is never remounted. Result: the Home box keeps its stale text while report comment drafts clear.
Suggested fix
Targeted, roll-forward fix (no revert needed). Either:
Persist the prompt-box draft to a dedicated Onyx key read via useOnyx (mirroring the REPORT_DRAFT_COMMENT pattern), so clearOnyxAndResetApp clears it automatically; or
If keeping the draft local is intentional, reset the local state when the app resets — e.g. subscribe to the same reset signal / clear on Onyx-cleared so clearInput() runs during cache clear.
Option 1 is the more consistent approach and matches how every other composer draft behaves across the app.
Let's follow whatever behavior we do if you're in the Inbox chatting with Concierge. If we clear it there, then let's do the same here. Otherwise, I'm fine leaving it. I don't think this is really a common user flow, so I think as long as we're consistent we're good.
changed the title [-]Home - Draft text is not cleared after clearing cache in Home search box.[/-][+][Due for payment 2026-09-04] Home - Draft text is not cleared after clearing cache in Home search box.[/+]on Aug 28, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.63-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-04. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Aug 26, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/32bcb9b0582603c5d4b67c0b10fdcfaa4b5effb9d587a68430edf116eff8c340
melvin-bot commentedon Aug 26, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #98336
melvin-bot commentedon Aug 26, 2026
@puneetlath @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #98336
github-actions commentedon Aug 26, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 26, 2026
@adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #98336
melvin-bot commentedon Aug 26, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Aug 26, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #98336 - "[Home Page] Add Concierge prompt box to home For You section" by @adamgrzybowski (High confidence)
Related Issues: #94497 (feature request implemented by the PR)
Recommendation: ROLL FORWARD
The confirmed cause is a brand-new feature; reverting the whole ~266-line PR (plus attachment/date/style refactors) is disproportionate for a stale-draft edge case that only appears after a manual "Clear cache". A small targeted fix is preferable. Note: severity is low (no data loss, no crash, functionality unaffected), so the team may reasonably choose to DEMOTE — but I am keeping
DeployBlockerCashbecause an App PR caused the bug and I do not remove App-deploy blocker labels for App-caused issues.Assigned: @adamgrzybowski (PR author), @puneetlath and @ZhenjaHorbach (approving reviewers) — already assigned on the issue.
Labels: No changes. Only
DeployBlockerCashwas present; this is a Frontend bug so it is correctly kept. NoDeployBlocker(Web) label was present to remove.📋 Detailed Analysis
Evidence
src/pages/home/ForYouSection/ConciergePromptBox.tsxis a new file in that PR). This is a new feature not present in production, which matches "reproducible in staging, N/A in prod".Verification
src/pages/home/ForYouSection/ConciergePromptBox.tsx(new in PR [Home Page] Add Concierge prompt box to home For You section #98336).const [value, setValue] = useState('');— ConciergePromptBox.tsx#L69clearInputonly resets that local state — ConciergePromptBox.tsx#L79-L82const [draftComment] = useOnyx(\${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`);` — ComposerProvider.tsx#L50clearOnyxAndResetApp, which wipes Onyx storage (clearOnyxAndSeedFullReconnect(KEYS_TO_PRESERVE)) but does not unmount/remount the React tree — App.ts#L924-L978.Root Cause
"Clear cache" clears Onyx, not React component state. The Concierge comment composer reads its draft from Onyx (
REPORT_DRAFT_COMMENT), so wiping Onyx makes it re-render empty — correct behavior. The new Home Concierge prompt box holds its draft only inuseState('')(ConciergePromptBox.tsx#L69), which survives the Onyx wipe because the component is never remounted. Result: the Home box keeps its stale text while report comment drafts clear.Suggested fix
Targeted, roll-forward fix (no revert needed). Either:
useOnyx(mirroring theREPORT_DRAFT_COMMENTpattern), soclearOnyxAndResetAppclears it automatically; orclearInput()runs during cache clear.Option 1 is the more consistent approach and matches how every other composer draft behaves across the app.
13 remaining items
mhawryluk commentedon Aug 27, 2026
got it, thanks! created a PR: #99570
[-]Home - Draft text is not cleared after clearing cache in Home search box.[/-][+][Due for payment 2026-09-04] Home - Draft text is not cleared after clearing cache in Home search box.[/+]melvin-bot commentedon Aug 28, 2026
@ZhenjaHorbach
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.63-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-04. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Aug 31, 2026
@ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
ZhenjaHorbach commentedon Sep 1, 2026
@puneetlath @grgia
Let's close this!
grgia commentedon Sep 1, 2026
Closing