Skip to content

[Due for payment 2026-09-04] Home - Draft text is not cleared after clearing cache in Home search box. #99555

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: V9.4.61-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98336
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redmi note 10s android 13
App Component: User Settings

Action Performed:

  1. Launch app
  2. In Home, search box enter a text
  3. Go to troubleshoot - clear cache
  4. Go to Home and note text is not cleared
  5. Go to concierge
  6. Enter a text
  7. Go to troubleshoot and clear cache
  8. Go to to Concierge
  9. Note draft text is cleared

Expected Result:

Draft text must be cleared after clearing cache in Home search box.

Actual Result:

Draft text is not cleared after clearing cache in Home search box.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7243175_1787740981157.Screenrecorder-2026-08-26-16-08-06-15.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7243175

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 26, 2026
  2. applause-bot commented on Aug 26, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/32bcb9b0582603c5d4b67c0b10fdcfaa4b5effb9d587a68430edf116eff8c340

  3. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #98336

  4. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @puneetlath @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #98336

  5. github-actions commented on Aug 26, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #98336

  7. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Aug 26, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #98336 - "[Home Page] Add Concierge prompt box to home For You section" by @adamgrzybowski (High confidence)
    Related Issues: #94497 (feature request implemented by the PR)

    Recommendation: ROLL FORWARD

    The confirmed cause is a brand-new feature; reverting the whole ~266-line PR (plus attachment/date/style refactors) is disproportionate for a stale-draft edge case that only appears after a manual "Clear cache". A small targeted fix is preferable. Note: severity is low (no data loss, no crash, functionality unaffected), so the team may reasonably choose to DEMOTE — but I am keeping DeployBlockerCash because an App PR caused the bug and I do not remove App-deploy blocker labels for App-caused issues.

    Assigned: @adamgrzybowski (PR author), @puneetlath and @ZhenjaHorbach (approving reviewers) — already assigned on the issue.
    Labels: No changes. Only DeployBlockerCash was present; this is a Frontend bug so it is correctly kept. No DeployBlocker (Web) label was present to remove.

    📋 Detailed Analysis

    Evidence

    Verification

    Root Cause

    "Clear cache" clears Onyx, not React component state. The Concierge comment composer reads its draft from Onyx (REPORT_DRAFT_COMMENT), so wiping Onyx makes it re-render empty — correct behavior. The new Home Concierge prompt box holds its draft only in useState('') (ConciergePromptBox.tsx#L69), which survives the Onyx wipe because the component is never remounted. Result: the Home box keeps its stale text while report comment drafts clear.

    Suggested fix

    Targeted, roll-forward fix (no revert needed). Either:

    1. Persist the prompt-box draft to a dedicated Onyx key read via useOnyx (mirroring the REPORT_DRAFT_COMMENT pattern), so clearOnyxAndResetApp clears it automatically; or
    2. If keeping the draft local is intentional, reset the local state when the app resets — e.g. subscribe to the same reset signal / clear on Onyx-cleared so clearInput() runs during cache clear.

    Option 1 is the more consistent approach and matches how every other composer draft behaves across the app.

  9. 13 remaining items

  10. mhawryluk commented on Aug 27, 2026

    @mhawryluk
    Member

    Let's follow whatever behavior we do if you're in the Inbox chatting with Concierge. If we clear it there, then let's do the same here. Otherwise, I'm fine leaving it. I don't think this is really a common user flow, so I think as long as we're consistent we're good.

    got it, thanks! created a PR: #99570

  11. changed the title [-]Home - Draft text is not cleared after clearing cache in Home search box.[/-] [+][Due for payment 2026-09-04] Home - Draft text is not cleared after clearing cache in Home search box.[/+] on Aug 28, 2026
  12. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    @ZhenjaHorbach

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.63-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-04. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  13. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. ZhenjaHorbach commented on Sep 1, 2026

    @ZhenjaHorbach
    Contributor

    @puneetlath @grgia
    Let's close this!

  15. grgia commented on Sep 1, 2026

    @grgia
    Contributor

    Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions