Skip to content

[Due for payment 2026-11-02] "Are you enjoying New Expensify?" pop-up repeatedly reappears and prevents the user from accessing the app #99564

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number:
Reproducible in staging?: Needs Reproduction (Unable to reproduce)
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ade-constantiniu
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Log in to New Expensify on the web or mobile app.
  2. When the “Are you enjoying New Expensify?" pop-up appears, click the buttons to dismiss it.
  3. The pop-up immediately reappears.
  4. Repeat the action, but the user remains stuck in the same loop and cannot access the app.

Expected Result:

After the user responds to or dismisses the feedback pop-up, it should close, allowing them to continue using New Expensify.

Actual Result:

The pop-up keeps reappearing after the user responds to or dismisses it, preventing them from progressing past that screen. The issue occurs on both the web and mobile. They have already tested Chrome, an incognito window, and a clean sign-out, but the behavior persists.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Recording.3431.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 26, 2026
  2. exfy-zapier commented on Aug 26, 2026

    @exfy-zapier

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  3. MelvinBot commented on Aug 26, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The "Enjoying New Expensify?" modal is only permanently dismissed when the user answers positively. For a "Not really" (negative) or a dismiss (skip) response, the only thing that keeps the modal hidden is a recent lastPrompt timestamp (a 30‑day cooldown). If lastPrompt is ever missing from nvp_appReview, the gate falls through and the modal re‑shows forever — which is exactly the loop reported here.

    In src/hooks/useProactiveAppReview.ts:37-45 the modal is hidden only if response === 'positive' or a recent lastPrompt exists. A negative/skip response with no lastPrompt matches neither branch, so shouldShowModal stays true.

    The client optimistically writes lastPrompt: now when responding, so the modal closes for a moment — but there is no successData re-write for nvp_appReview, and the request never sends a timestamp to the server. So the authoritative value comes entirely from what the backend pushes back. If the server's nvp_appReview keeps trigger + response but omits lastPrompt (or replaces the object via set), the optimistic lastPrompt is dropped once the round-trip completes and the modal immediately reappears. This also explains why it survives a clean sign-out (it's account/NVP state, not local cache) and why it's hard to reproduce (users who tap "Yeah!" are permanently exempted; only negative/skip responders hit it).

    Evidence & data flow

    Flow: respond negative/skip → optimistic {response, lastPrompt: now} → modal closes → server round-trip returns nvp_appReview (shape decided server-side) → if it lacks lastPrompt, the optimistic value is gone → hook falls through → shouldShowModal = true → modal reopens.

    What changes do you think we should make in order to solve the problem?

    Harden the client gate so a recorded answer can never produce an infinite loop, then confirm the backend contract:

    1. Client (App): In useProactiveAppReview.ts, treat any recorded response (not just positive) as "answered", and only re-prompt a negative/skip response when a valid recent-enough lastPrompt is present. Concretely, when response is negative/skip but lastPrompt is missing/invalid, keep the modal hidden (fail closed) rather than falling through to shouldShowModal = true. This breaks the loop regardless of backend behavior.

    2. Backend (needs internal engineer): This behavior depends on what RespondToProactiveAppReview persists and returns for nvp_appReview. The App side never sends lastPrompt, so the server must generate/persist it. I can't read that repo, so an internal engineer should verify that a negative/skip response durably persists a lastPrompt (and that the returned Onyx update doesn't drop it via set). If it doesn't, that's the true root cause and the fix belongs there.

    What alternative solutions did you explore? (Optional)

    Add a successData re-write for nvp_appReview on the client so the optimistic lastPrompt isn't lost on round-trip — but this only masks the problem if the backend also doesn't persist lastPrompt (it would still reappear on the next OpenApp). The gate hardening in (1) is the robust client-side guard.


    ⚠️ Confidence: Medium. The client-side gap is confirmed with code evidence and fully explains the loop; the trigger (backend omitting lastPrompt) is inferred and needs verification by someone with backend access. No affected account/reportID was in the issue, so this wasn't confirmed against production logs.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/99564) to create a draft PR for the client-side hardening.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 26, 2026
  5. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  6. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  7. Javokhiir commented on Aug 26, 2026

    @Javokhiir

    the optimistic lastPrompt is dropped once the round-trip completes and the modal immediately reappears.

    @eVoloshchak i reproduced this consistently on web, and there is a small correction to this part. RespondToProactiveAppReview returned jsonCode 200 with onyxData: [], so nothing was pushed back and lastPrompt wasn't dropped by that round trip.

    lastPrompt exists only from the optimistic merge. the prompt comes back when the authoritative {trigger: 'submit', response: 'negative'} lands again. so the missing server timestamp is confirmed here, not inferred, but the exact failure sequence in Melvin's RCA is not correct. i think this distinction matters for deciding where the fix should live.

  8. oqildev commented on Aug 29, 2026

    @oqildev
    Contributor

    @eVoloshchak It's reproducible.

    I reproduced this (Chrome). Video attached.

    nvp_appReview.trigger is server-set, so I drove it through window.Onyx in a dev build:

    1. Onyx.set('nvp_appReview', {trigger: 'submit'}) → modal appears
    2. Click "Not really." → it closes
    3. Onyx.get('nvp_appReview') → {trigger, response: 'negative', lastPrompt: '...'}
    4. Onyx.set('nvp_appReview', {trigger: 'submit', response: 'negative'}) → modal comes back on its own
    5. Onyx.get('nvp_appReview') → {trigger, response: 'negative'} — no lastPrompt

    Repeat step 4 and it returns every time.

    Step 4 isn't me forcing the modal open - I'm writing the state the account is left in with the answer already recorded. If the stored copy carried a fresh lastPrompt, the modal wouldn't return at all, so the symptom itself tells us it doesn't. Step 3 vs step 5 is the whole thing: the answer survives, the timestamp doesn't, and it only ever existed on the device.

    That's also why the reporter's clean sign-out didn't help - this is account state, not local cache.

    I have a fix with red→green tests ready (it reproduces in Jest too). Happy to post the full proposal once Help Wanted lands, or sooner if you'd like.

    Repro Video:

    Repro.pop-up.mp4
  9. eVoloshchak commented on Aug 30, 2026

    @eVoloshchak
    Contributor
    Screen.Recording.2026-08-30.at.22.01.58.mov

    Not reproducible for me

    @oqildev, @Javokhiir, is this still reproducible for you?

  10. 79 remaining items

  11. melvin-bot commented on Nov 1, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  12. eVoloshchak commented on Nov 2, 2026

    @eVoloshchak
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: there isn't an offending PR, this guard was never implemented in the first place
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: regression wasn't critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • The prompt is armed by the server, so the account has to be in the affected state: nvp_appReview carrying trigger, a non-positive response, and a lastPrompt older than 30 days. An account that was prompted and answered "Not really." more than 30 days ago is in exactly that state; otherwise move the machine clock past lastPrompt + 30 days, which is the same state a user reaches by waiting.

    Test:

    1. Sign in with such an account.
    2. Verify the "Are you enjoying New Expensify?" modal appears — this is the intended 30-day re-prompt.
    3. Press Not really.
    4. Verify the modal closes and does not re-open while the rest of the account data finishes loading.
    5. Refresh the page and verify the modal does not appear.
    6. In the JS console run window.Onyx.log('appReviewLastPrompt') and verify it holds {accountID: , lastPrompt: }.
    7. Sign out, sign back in, and verify the modal does not appear. (Before this change it came back on every sign-in.)
    8. Move the clock another 31 days forward, reload, and verify the modal appears again — the 30-day re-prompt is intact.
    9. Sign out, sign in with a different account on the same browser, and verify that account's own prompt state decides whether the modal shows — the record from step 6 is ignored.

    Do we agree 👍 or 👎

  13. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. mallenexpensify commented on Nov 5, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @oqildev paid $250 via Upwork
    Contributor+: @eVoloshchak due $250 via NewDot

    @oqildev can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022118487480095708602

  17. oqildev commented on Nov 6, 2026

    @oqildev
    Contributor

    Payment Summary

    Contributor: @oqildev due $250 via Upwork
    Contributor+: @eVoloshchak due $250 via NewDot

    @oqildev can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022118487480095708602

    I accepted.

  18. mallenexpensify commented on Nov 6, 2026

    @mallenexpensify
    Contributor

    @oqildev paid, summary updated above. Thx.

  19. JmillsExpensify commented on Nov 10, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @eVoloshchak

  20. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    📣 @cristianobrocheir! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNeeds ReproductionReproducible steps needed

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions