You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-02] "Are you enjoying New Expensify?" pop-up repeatedly reappears and prevents the user from accessing the app #99564
Version Number: Reproducible in staging?: Needs Reproduction (Unable to reproduce) Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@ade-constantiniu Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Log in to New Expensify on the web or mobile app.
When the “Are you enjoying New Expensify?" pop-up appears, click the buttons to dismiss it.
The pop-up immediately reappears.
Repeat the action, but the user remains stuck in the same loop and cannot access the app.
Expected Result:
After the user responds to or dismisses the feedback pop-up, it should close, allowing them to continue using New Expensify.
Actual Result:
The pop-up keeps reappearing after the user responds to or dismisses it, preventing them from progressing past that screen. The issue occurs on both the web and mobile. They have already tested Chrome, an incognito window, and a clean sign-out, but the behavior persists.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
The "Enjoying New Expensify?" modal is only permanently dismissed when the user answers positively. For a "Not really" (negative) or a dismiss (skip) response, the only thing that keeps the modal hidden is a recent lastPrompt timestamp (a 30‑day cooldown). If lastPrompt is ever missing from nvp_appReview, the gate falls through and the modal re‑shows forever — which is exactly the loop reported here.
In src/hooks/useProactiveAppReview.ts:37-45 the modal is hidden only if response === 'positive'or a recent lastPrompt exists. A negative/skip response with no lastPrompt matches neither branch, so shouldShowModal stays true.
The client optimistically writes lastPrompt: now when responding, so the modal closes for a moment — but there is no successData re-write for nvp_appReview, and the request never sends a timestamp to the server. So the authoritative value comes entirely from what the backend pushes back. If the server's nvp_appReview keeps trigger + response but omits lastPrompt (or replaces the object via set), the optimistic lastPrompt is dropped once the round-trip completes and the modal immediately reappears. This also explains why it survives a clean sign-out (it's account/NVP state, not local cache) and why it's hard to reproduce (users who tap "Yeah!" are permanently exempted; only negative/skip responders hit it).
Evidence & data flow
Gate logic (the gap): useProactiveAppReview.ts:29-46 — hides on response === 'positive' else on a recent lastPrompt; negative/skip without lastPrompt → shows.
lastPrompt is optional on the type, so a payload of {trigger, response} is valid and triggers the loop: AppReview.ts:8-19.
Flow: respond negative/skip → optimistic {response, lastPrompt: now} → modal closes → server round-trip returns nvp_appReview (shape decided server-side) → if it lacks lastPrompt, the optimistic value is gone → hook falls through → shouldShowModal = true → modal reopens.
What changes do you think we should make in order to solve the problem?
Harden the client gate so a recorded answer can never produce an infinite loop, then confirm the backend contract:
Client (App): In useProactiveAppReview.ts, treat any recorded response (not just positive) as "answered", and only re-prompt a negative/skip response when a valid recent-enough lastPrompt is present. Concretely, when response is negative/skip but lastPrompt is missing/invalid, keep the modal hidden (fail closed) rather than falling through to shouldShowModal = true. This breaks the loop regardless of backend behavior.
Backend (needs internal engineer): This behavior depends on what RespondToProactiveAppReview persists and returns for nvp_appReview. The App side never sends lastPrompt, so the server must generate/persist it. I can't read that repo, so an internal engineer should verify that a negative/skip response durably persists a lastPrompt (and that the returned Onyx update doesn't drop it via set). If it doesn't, that's the true root cause and the fix belongs there.
What alternative solutions did you explore? (Optional)
Add a successData re-write for nvp_appReview on the client so the optimistic lastPrompt isn't lost on round-trip — but this only masks the problem if the backend also doesn't persist lastPrompt (it would still reappear on the next OpenApp). The gate hardening in (1) is the robust client-side guard.
⚠️Confidence: Medium. The client-side gap is confirmed with code evidence and fully explains the loop; the trigger (backend omitting lastPrompt) is inferred and needs verification by someone with backend access. No affected account/reportID was in the issue, so this wasn't confirmed against production logs.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/99564) to create a draft PR for the client-side hardening. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
the optimistic lastPrompt is dropped once the round-trip completes and the modal immediately reappears.
@eVoloshchak i reproduced this consistently on web, and there is a small correction to this part. RespondToProactiveAppReview returned jsonCode 200 with onyxData: [], so nothing was pushed back and lastPrompt wasn't dropped by that round trip.
lastPrompt exists only from the optimistic merge. the prompt comes back when the authoritative {trigger: 'submit', response: 'negative'} lands again. so the missing server timestamp is confirmed here, not inferred, but the exact failure sequence in Melvin's RCA is not correct. i think this distinction matters for deciding where the fix should live.
Onyx.set('nvp_appReview', {trigger: 'submit', response: 'negative'}) → modal comes back on its own
Onyx.get('nvp_appReview') → {trigger, response: 'negative'} — no lastPrompt
Repeat step 4 and it returns every time.
Step 4 isn't me forcing the modal open - I'm writing the state the account is left in with the answer already recorded. If the stored copy carried a fresh lastPrompt, the modal wouldn't return at all, so the symptom itself tells us it doesn't. Step 3 vs step 5 is the whole thing: the answer survives, the timestamp doesn't, and it only ever existed on the device.
That's also why the reporter's clean sign-out didn't help - this is account state, not local cache.
I have a fix with red→green tests ready (it reproduces in Jest too). Happy to post the full proposal once Help Wanted lands, or sooner if you'd like.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: there isn't an offending PR, this guard was never implemented in the first place
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: regression wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
The prompt is armed by the server, so the account has to be in the affected state: nvp_appReview carrying trigger, a non-positive response, and a lastPrompt older than 30 days. An account that was prompted and answered "Not really." more than 30 days ago is in exactly that state; otherwise move the machine clock past lastPrompt + 30 days, which is the same state a user reaches by waiting.
Test:
Sign in with such an account.
Verify the "Are you enjoying New Expensify?" modal appears — this is the intended 30-day re-prompt.
Press Not really.
Verify the modal closes and does not re-open while the rest of the account data finishes loading.
Refresh the page and verify the modal does not appear.
In the JS console run window.Onyx.log('appReviewLastPrompt') and verify it holds {accountID: , lastPrompt: }.
Sign out, sign back in, and verify the modal does not appear. (Before this change it came back on every sign-in.)
Move the clock another 31 days forward, reload, and verify the modal appears again — the 30-day re-prompt is intact.
Sign out, sign in with a different account on the same browser, and verify that account's own prompt state decides whether the modal shows — the record from step 6 is ignored.
📣 @cristianobrocheir! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
exfy-zapier commentedon Aug 26, 2026
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
MelvinBot commentedon Aug 26, 2026
Proposal
What is the root cause of that problem?
The "Enjoying New Expensify?" modal is only permanently dismissed when the user answers positively. For a "Not really" (negative) or a dismiss (skip) response, the only thing that keeps the modal hidden is a recent
lastPrompttimestamp (a 30‑day cooldown). IflastPromptis ever missing fromnvp_appReview, the gate falls through and the modal re‑shows forever — which is exactly the loop reported here.In
src/hooks/useProactiveAppReview.ts:37-45the modal is hidden only ifresponse === 'positive'or a recentlastPromptexists. Anegative/skipresponse with nolastPromptmatches neither branch, soshouldShowModalstaystrue.The client optimistically writes
lastPrompt: nowwhen responding, so the modal closes for a moment — but there is nosuccessDatare-write fornvp_appReview, and the request never sends a timestamp to the server. So the authoritative value comes entirely from what the backend pushes back. If the server'snvp_appReviewkeepstrigger+responsebut omitslastPrompt(or replaces the object viaset), the optimisticlastPromptis dropped once the round-trip completes and the modal immediately reappears. This also explains why it survives a clean sign-out (it's account/NVP state, not local cache) and why it's hard to reproduce (users who tap "Yeah!" are permanently exempted; only negative/skip responders hit it).Evidence & data flow
useProactiveAppReview.ts:29-46— hides onresponse === 'positive'else on a recentlastPrompt; negative/skip withoutlastPrompt→ shows.successDatafor the NVP:User.ts:1631-1650. Params sent to server contain no timestamp (RespondToProactiveAppReviewParams.ts).lastPromptis optional on the type, so a payload of{trigger, response}is valid and triggers the loop:AppReview.ts:8-19.Flow: respond
negative/skip→ optimistic{response, lastPrompt: now}→ modal closes → server round-trip returnsnvp_appReview(shape decided server-side) → if it lackslastPrompt, the optimistic value is gone → hook falls through →shouldShowModal = true→ modal reopens.What changes do you think we should make in order to solve the problem?
Harden the client gate so a recorded answer can never produce an infinite loop, then confirm the backend contract:
Client (App): In
useProactiveAppReview.ts, treat any recordedresponse(not justpositive) as "answered", and only re-prompt a negative/skip response when a valid recent-enoughlastPromptis present. Concretely, whenresponseisnegative/skipbutlastPromptis missing/invalid, keep the modal hidden (fail closed) rather than falling through toshouldShowModal = true. This breaks the loop regardless of backend behavior.Backend (needs internal engineer): This behavior depends on what
RespondToProactiveAppReviewpersists and returns fornvp_appReview. The App side never sendslastPrompt, so the server must generate/persist it. I can't read that repo, so an internal engineer should verify that a negative/skip response durably persists alastPrompt(and that the returned Onyx update doesn't drop it viaset). If it doesn't, that's the true root cause and the fix belongs there.What alternative solutions did you explore? (Optional)
Add a
successDatare-write fornvp_appReviewon the client so the optimisticlastPromptisn't lost on round-trip — but this only masks the problem if the backend also doesn't persistlastPrompt(it would still reappear on the nextOpenApp). The gate hardening in (1) is the robust client-side guard.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/99564)to create a draft PR for the client-side hardening.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Aug 26, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Aug 26, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
Javokhiir commentedon Aug 26, 2026
@eVoloshchak i reproduced this consistently on web, and there is a small correction to this part. RespondToProactiveAppReview returned jsonCode 200 with onyxData: [], so nothing was pushed back and lastPrompt wasn't dropped by that round trip.
lastPrompt exists only from the optimistic merge. the prompt comes back when the authoritative {trigger: 'submit', response: 'negative'} lands again. so the missing server timestamp is confirmed here, not inferred, but the exact failure sequence in Melvin's RCA is not correct. i think this distinction matters for deciding where the fix should live.
oqildev commentedon Aug 29, 2026
@eVoloshchak It's reproducible.
I reproduced this (Chrome). Video attached.
nvp_appReview.triggeris server-set, so I drove it throughwindow.Onyxin a dev build:Onyx.set('nvp_appReview', {trigger: 'submit'})→ modal appearsOnyx.get('nvp_appReview')→{trigger, response: 'negative', lastPrompt: '...'}Onyx.set('nvp_appReview', {trigger: 'submit', response: 'negative'})→ modal comes back on its ownOnyx.get('nvp_appReview')→{trigger, response: 'negative'}— nolastPromptRepeat step 4 and it returns every time.
Step 4 isn't me forcing the modal open - I'm writing the state the account is left in with the answer already recorded. If the stored copy carried a fresh
lastPrompt, the modal wouldn't return at all, so the symptom itself tells us it doesn't. Step 3 vs step 5 is the whole thing: the answer survives, the timestamp doesn't, and it only ever existed on the device.That's also why the reporter's clean sign-out didn't help - this is account state, not local cache.
I have a fix with red→green tests ready (it reproduces in Jest too). Happy to post the full proposal once
Help Wantedlands, or sooner if you'd like.Repro Video:
Repro.pop-up.mp4
eVoloshchak commentedon Aug 30, 2026
Screen.Recording.2026-08-30.at.22.01.58.mov
Not reproducible for me
@oqildev, @Javokhiir, is this still reproducible for you?
79 remaining items
melvin-bot commentedon Nov 1, 2026
Payment Summary
Resolving PRs:
Stop the app review prompt from reappearing after the user answers it #102904
Reviewer: @eVoloshchak owed $175 via NewDot
Assignee: @oqildev requires payment (Needs manual offer from BZ)
BugZero Checklist (@mallenexpensify)
eVoloshchak commentedon Nov 2, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: there isn't an offending PR, this guard was never implemented in the first place
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: regression wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Nov 5, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Nov 5, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Nov 5, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Nov 5, 2026
Payment Summary
Contributor: @oqildev paid $250 via Upwork
Contributor+: @eVoloshchak due $250 via NewDot
@oqildev can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022118487480095708602
oqildev commentedon Nov 6, 2026
I accepted.
mallenexpensify commentedon Nov 6, 2026
@oqildev paid, summary updated above. Thx.
JmillsExpensify commentedon Nov 10, 2026
$250 approved for @eVoloshchak
melvin-bot commentedon Nov 10, 2026
📣 @cristianobrocheir! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format: