Skip to content

[Due for payment 2026-09-16] Web - "All matching items selected" behavior from #95902 was overwritten during conflict resolution in #96120 #99567

Closed

Description

@MelvinBot

Problem

This is a follow-up to #94143. The "All matching items selected" behavior originally added in #95902 was unintentionally overwritten while resolving conflicts in #96120, specifically in the fix: conflicts commit (e15dbba).

As a result, the fix from #95902 regressed and the "All matching items selected" behavior no longer works as intended.

Action Performed

  1. Select all matching items (so "All matching items selected" is shown).
  2. Observe the selection behavior.

Expected Result

The "All matching items selected" behavior introduced in #95902 should be preserved — all matching items (including non-visible ones) remain selected.

Actual Result

The behavior was overwritten during conflict resolution in #96120, so "All matching items selected" no longer behaves correctly and needs to be restored.

Proposed Solution

Restore the behavior from #95902 that was lost in the fix: conflicts commit of #96120 in a follow-up PR.

Platforms

  • Windows: Chrome
  • MacOS: Chrome / Safari

Reference

Originally raised in this comment on #94143.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 26, 2026
  2. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  3. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  4. MelvinBot commented on Aug 26, 2026

    @MelvinBot
    ContributorAuthor

    @emkhalid I couldn't add you as an assignee here (GitHub only allows assigning users with access to the repo). Tagging you so you're looped in — an admin can add you as an assignee once you have access.

  5. emkhalid commented on Aug 26, 2026

    @emkhalid
    Contributor

    @Valforte can you help me with the assignment, Thanks!

  6. 14 remaining items

  7. melvin-bot commented on Sep 15, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. melvin-bot commented on Sep 15, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  9. melvin-bot commented on Sep 18, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. mallenexpensify commented on Sep 21, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @emkhalid due $250 via Upwork
    Contributor+: @mkhutornyi due $250 via NewDot

    @emkhalid paid, summary updated above. Thx.
    https://www.upwork.com/jobs/~022102170305180771267

  11. mkhutornyi commented on Sep 22, 2026

    @mkhutornyi
    Contributor

    @mallenexpensify can you please update Contributor+? Thanks

  12. emkhalid commented on Sep 22, 2026

    @emkhalid
    Contributor

    @mallenexpensify I accepted the offer, thanks.

  13. mallenexpensify commented on Sep 22, 2026

    @mallenexpensify
    Contributor

    @emkhalid paid, summary updated above. Thx.

    @mkhutornyi apologies, I blame GH

    Image
  14. trjExpensify commented on Oct 1, 2026

    @trjExpensify
    Contributor

    approved $250 for @mkhutornyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions