Repository navigation
Pass the client lastReadTime to MarkAllAsRead API - #100002
Conversation
|
@MelvinBot I assume that this failing test is from main?
|
|
Yes — that failure comes from #98600 (merged today at 06:47 UTC) switched the delegate gate in A test-only fix is already open: #99997. Once it merges, merge How I verified this
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product.
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safarioutput.mp4 |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #99378 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@marcaaron All yours! |
|
🚧 marcaaron has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 9.4.81-0 🚀
|
|
🤖 No help site changes are required for this PR, so I did not create a draft docs PR. Why: the change is a two-line API payload addition — it sends the client's
There is no new feature, no new or renamed UI element, and no change to any documented behavior. It restores the behavior the help site already describes — Navigating-New-Expensify.md:74 already says the Unread tab "Shows only chats with unread messages," which is exactly what New message disappears from Unread tab when come back online broke and this PR fixes. One adjacent gap, out of scope here: the Mark all as read option on the Unread tab does not appear anywhere in @hungvu193, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
Explanation of Change
Pass the
lastReadTimefrom client to the BE so our BE can take it and use it as thelastReadTimeof the report instead of using the server time.Fixed Issues
$ #99378
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-09-05.at.01.07.51.mov
iOS: mWeb Safari
Screen.Recording.2026-09-05.at.01.07.51.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-05.at.01.05.26.mov