Repository navigation
[No QA] Fix import/no-cycle - part 5 - #100029
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
7844faa to
5ecc26d
Compare
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
9dfa9e1 to
7569418
Compare
|
@LukasMod conflicts |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-14.at.19.43.37.mov |
|
@LukasMod Sorry for the late, this got conflicts now. Could you please resolve? |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@thelullabyy no problem, main merged |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.81-0 🚀
|
|
🤖 No help site changes are required for this PR — I did not create a docs PR. This is a pure module move to break an How I confirmed itAll 4 changed files are code-internal. None are in
The public surface is unchanged. No copy changed. The only Nothing documented is affected. The search-related articles that could plausibly be in scope — Use-Search-Shortcuts.md and Use-Search-Operators-to-Filter-and-Analyze.md — describe search behavior and operators, all of which this PR leaves exactly as they were. This matches the PR's own Since there are no docs changes to make, there's no linked help site PR to review. |
|
@jponikarchuk is there any guide how to check such integration? |
|
I don't see how this PR could cause any of those, the code moved as-is, with no behaviour change |
|
@jponikarchuk It seems to be a feature based on: #101408 (comment) |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
Explanation of Change
src/libs/actions/IOU/SearchUpdate.tsneeds two helpers,getSuggestedSearchesandisEligibleForStatus, and it imported them fromSearchUIUtils.ts. That module is ~6,800 linesand imports back into the IOU actions, which closed a cycle:
Those two helpers only build query strings and compare status values, so I moved them and what
they depend on into a new
src/libs/SearchSuggestionUtils.ts:SEARCH_TYPE_MENU_ICON_NAMESgetSuggestedSearchesand itscreateTopSearchMenuItemhelperexpenseStatusActionMapping,isValidExpenseStatus,isEligibleForStatusSearchKeyandSearchTypeMenuItemtypesThe new module imports two things at runtime,
@src/CONSTand./SearchQueryUtils. Its othernine imports are type-only, so they carry no runtime edge.
SearchQueryUtilsimports neithersearch module, so the move adds nothing new to the graph.
SearchUpdate.tsnow imports from the new module, which takes it out of the cycle.SearchUIUtils.tsre-exports everything it exported before, so its other consumers are untouched.The code moved as-is, with no behaviour change.
npx jest tests/unit/Search/SearchUIUtilsTest.tspasses, 517 testsNothing user facing changed, so there is no QA. The suggested search list is covered by the unit
tests above.
Fixed Issues
$ #99650
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari