Repository navigation
[No QA] Docs updates for E/A#99681 Correct delete-workspace steps and confirmation window - #100098
Conversation
…ndow Match the current UI: the three-dot row menu lives on the Workspaces list, and the confirmation window now names the workspace. Co-authored-by: Brandon Stites <stitesExpensify@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@linhvovan29546 @jliexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| 4. Confirm that you want to delete the Workspace. | ||
| 4. In the **Delete [workspace name]?** window, click **Delete**. | ||
|
|
||
| You can also delete a workspace from inside it. Open the workspace, select **More**, then choose **Delete**. The same **Delete [workspace name]?** window appears. |
There was a problem hiding this comment.
Vague navigation phrasing: "Open the workspace" is a prohibited vague navigation phrase (HELPSITE_NAMING_CONVENTIONS.md — Prohibited Language). Replace with an explicit navigation instruction using the exact UI label, e.g. reference the exact tab/step the member takes to enter the workspace. Also confirm More is the exact UI label; if the control is a three dots menu, use the required format: Select the three dots (⋮).
There was a problem hiding this comment.
Should this be "Click on the Workspace" instead?
There was a problem hiding this comment.
Maybe "select"? I don't think we can say "click" because of mobile. I personally think that "open" also makes sense though, your call!
HelpDot Documentation ReviewOverall AssessmentThis PR makes a focused, high-quality refinement to the "How to delete a workspace" procedure in Delete-a-Workspace.md. It tightens navigation wording, replaces a vague confirmation step with an explicit UI-exact action, and adds a helpful alternate path for deleting a workspace from within it. Small in scope but a clear improvement to clarity, determinism, and AI retrieval. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
jliexpensify
left a comment
There was a problem hiding this comment.
LGTM, but left one comment on wording.
| 4. Confirm that you want to delete the Workspace. | ||
| 4. In the **Delete [workspace name]?** window, click **Delete**. | ||
|
|
||
| You can also delete a workspace from inside it. Open the workspace, select **More**, then choose **Delete**. The same **Delete [workspace name]?** window appears. |
There was a problem hiding this comment.
Should this be "Click on the Workspace" instead?
|
@stitesExpensify @stephanieelliott @jliexpensify Anything specific to QA in this PR? |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.81-0 🚀
|
|
Oops! No @mvtglobally -- just marked as No QA! |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
Explanation of Change
Help site follow-up to #99681, which changed the delete-workspace confirmation modal title from the generic "Delete workspace" to Delete [workspace name]?.
docs/articles/new-expensify/workspaces/Delete-a-Workspace.mdwas the only help site article that documents this flow, and its steps no longer matched the UI:Every label was verified against dev NewDot on web rather than assumed. The row menu item reads Delete workspace, the in-workspace menu item reads Delete, and both open the same window:
The leave-workspace half of #99681 needs no help site change — no article under
docs/articlesdocuments leaving a workspace or quotes the Leave button copy.Written against
docs/HELPSITE_NAMING_CONVENTIONS.md(bold UI labels in Sentence case, the required three dots (⋮) phrasing, unified web/mobile navigation sentence),docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. The article's headings, metadata, and structure already complied and were left alone.Fixed Issues
$ #99561
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — help site content only, no app code changes.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@stitesExpensify, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.