Skip to content
Merged
68 changes: 32 additions & 36 deletions src/components/Search/chartGroupByConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,6 @@ import DateUtils from '@libs/DateUtils';

import CONST from '@src/CONST';

import type {
TransactionCardGroupListItemType,
TransactionCategoryGroupListItemType,
TransactionMemberGroupListItemType,
TransactionMerchantGroupListItemType,
TransactionMonthGroupListItemType,
TransactionQuarterGroupListItemType,
TransactionTagGroupListItemType,
TransactionWeekGroupListItemType,
TransactionWithdrawalIDGroupListItemType,
TransactionYearGroupListItemType,
} from './SearchList/ListItem/types';
import type {GroupedItem, SearchGroupBy} from './types';

/** The dates a time bucket covers */
Expand Down Expand Up @@ -49,34 +37,34 @@ type ChartGroupByConfig = {
const CHART_GROUP_BY_CONFIG: Record<SearchGroupBy, ChartGroupByConfig> = {
[CONST.SEARCH.GROUP_BY.FROM]: {
titleIconName: 'Users',
getLabel: (item: GroupedItem) => (item as TransactionMemberGroupListItemType).formattedFrom ?? '',
getFilterQuery: (item: GroupedItem) => `from:${(item as TransactionMemberGroupListItemType).accountID}`,
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.FROM ? (item.formattedFrom ?? '') : ''),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR conflicts with #104927 on the chart config

Both PRs rewrite the same lines in chartGroupByConfig.ts and its test, in opposite ways.
#104927 replaces these groupedBy guards with 'x' in item checks, so whichever merges second conflicts and undoes the other.

[CONST.SEARCH.GROUP_BY.FROM]: {
titleIconName: 'Users',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.FROM ? (item.formattedFrom ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.FROM ? `from:${item.accountID}` : ''),
},
[CONST.SEARCH.GROUP_BY.CARD]: {
titleIconName: 'CreditCard',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.CARD ? (item.formattedCardName ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.CARD ? `cardID:${item.cardID}` : ''),
},
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: {
titleIconName: 'Send',
// eslint-disable-next-line rulesdir/no-default-id-values -- formattedWithdrawalID is a display label, not an Onyx ID
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID ? (item.formattedWithdrawalID ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID ? `withdrawalID:${item.entryID}` : ''),
},
[CONST.SEARCH.GROUP_BY.CATEGORY]: {
titleIconName: 'Folder',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.CATEGORY ? (item.formattedCategory ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.CATEGORY ? `category:"${item.category}"` : ''),
},
[CONST.SEARCH.GROUP_BY.MERCHANT]: {
titleIconName: 'Basket',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.MERCHANT ? (item.formattedMerchant ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.MERCHANT ? `merchant="${item.merchant}"` : ''),
},
[CONST.SEARCH.GROUP_BY.TAG]: {
titleIconName: 'Tag',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.TAG ? (item.formattedTag ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.TAG ? `tag:"${item.tag}"` : ''),
},

[CONST.SEARCH.GROUP_BY.FROM]: {
titleIconName: 'Users',
getLabel: (item: GroupedItem) => ('formattedFrom' in item ? item.formattedFrom : undefined) ?? '',
getFilterQuery: (item: GroupedItem) => `from:${'accountID' in item ? item.accountID : undefined}`,
},
[CONST.SEARCH.GROUP_BY.CARD]: {
titleIconName: 'CreditCard',
getLabel: (item: GroupedItem) => ('formattedCardName' in item ? item.formattedCardName : undefined) ?? '',
getFilterQuery: (item: GroupedItem) => `cardID:${'cardID' in item ? item.cardID : undefined}`,
},
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: {
titleIconName: 'Send',
getLabel: (item: GroupedItem) => ('formattedWithdrawalID' in item ? item.formattedWithdrawalID : undefined) ?? '',
getFilterQuery: (item: GroupedItem) => `withdrawalID:${'entryID' in item ? item.entryID : undefined}`,
},
[CONST.SEARCH.GROUP_BY.CATEGORY]: {
titleIconName: 'Folder',
getLabel: (item: GroupedItem) => ('formattedCategory' in item ? item.formattedCategory : undefined) ?? '',
getFilterQuery: (item: GroupedItem) => `category:"${'category' in item ? item.category : undefined}"`,
},
[CONST.SEARCH.GROUP_BY.MERCHANT]: {
titleIconName: 'Basket',
getLabel: (item: GroupedItem) => ('formattedMerchant' in item ? item.formattedMerchant : undefined) ?? '',
getFilterQuery: (item: GroupedItem) => `merchant="${'merchant' in item ? item.merchant : undefined}"`,
},
[CONST.SEARCH.GROUP_BY.TAG]: {
titleIconName: 'Tag',
getLabel: (item: GroupedItem) => ('formattedTag' in item ? item.formattedTag : undefined) ?? '',
getFilterQuery: (item: GroupedItem) => `tag:"${'tag' in item ? item.tag : undefined}"`,
},

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved. #104927 no longer changes chartGroupByConfig.ts or its test, so this PR is the only one that touches them. It uses the groupedBy guard for each entry.

getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.FROM ? `from:${item.accountID}` : ''),
},
[CONST.SEARCH.GROUP_BY.CARD]: {
titleIconName: 'CreditCard',
getLabel: (item: GroupedItem) => (item as TransactionCardGroupListItemType).formattedCardName ?? '',
getFilterQuery: (item: GroupedItem) => `cardID:${(item as TransactionCardGroupListItemType).cardID}`,
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.CARD ? (item.formattedCardName ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.CARD ? `cardID:${item.cardID}` : ''),
},
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: {
titleIconName: 'Send',
// eslint-disable-next-line rulesdir/no-default-id-values -- formattedWithdrawalID is a display label, not an Onyx ID
getLabel: (item: GroupedItem) => (item as TransactionWithdrawalIDGroupListItemType).formattedWithdrawalID ?? '',
getFilterQuery: (item: GroupedItem) => `withdrawalID:${(item as TransactionWithdrawalIDGroupListItemType).entryID}`,
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID ? (item.formattedWithdrawalID ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID ? `withdrawalID:${item.entryID}` : ''),
},
[CONST.SEARCH.GROUP_BY.CATEGORY]: {
titleIconName: 'Folder',
getLabel: (item: GroupedItem) => (item as TransactionCategoryGroupListItemType).formattedCategory ?? '',
getFilterQuery: (item: GroupedItem) => `category:"${(item as TransactionCategoryGroupListItemType).category}"`,
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.CATEGORY ? (item.formattedCategory ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.CATEGORY ? `category:"${item.category}"` : ''),
},
[CONST.SEARCH.GROUP_BY.MERCHANT]: {
titleIconName: 'Basket',
getLabel: (item: GroupedItem) => (item as TransactionMerchantGroupListItemType).formattedMerchant ?? '',
getFilterQuery: (item: GroupedItem) => `merchant="${(item as TransactionMerchantGroupListItemType).merchant}"`,
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.MERCHANT ? (item.formattedMerchant ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.MERCHANT ? `merchant="${item.merchant}"` : ''),
},
[CONST.SEARCH.GROUP_BY.TAG]: {
titleIconName: 'Tag',
getLabel: (item: GroupedItem) => (item as TransactionTagGroupListItemType).formattedTag ?? '',
getFilterQuery: (item: GroupedItem) => `tag:"${(item as TransactionTagGroupListItemType).tag}"`,
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.TAG ? (item.formattedTag ?? '') : ''),
getFilterQuery: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.TAG ? `tag:"${item.tag}"` : ''),
},
[CONST.SEARCH.GROUP_BY.DAY]: {
titleIconName: 'Calendar',
Expand All @@ -89,48 +77,56 @@ const CHART_GROUP_BY_CONFIG: Record<SearchGroupBy, ChartGroupByConfig> = {
},
[CONST.SEARCH.GROUP_BY.MONTH]: {
titleIconName: 'Calendar',
getLabel: (item: GroupedItem) => (item as TransactionMonthGroupListItemType).formattedMonth ?? '',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.MONTH ? (item.formattedMonth ?? '') : ''),
getShortLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.MONTH ? item.shortFormattedMonth : undefined),
axisLabelSteps: [1, 2, 3, 6],
getFilterQuery: (item: GroupedItem) => {
const monthItem = item as TransactionMonthGroupListItemType;
const {start, end} = DateUtils.getMonthDateRange(monthItem.year, monthItem.month);
if (item.groupedBy !== CONST.SEARCH.GROUP_BY.MONTH) {
return '';
}
const {start, end} = DateUtils.getMonthDateRange(item.year, item.month);
return `date>=${start} date<=${end}`;
},
getDateRange: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.MONTH ? DateUtils.getMonthDateRange(item.year, item.month) : undefined),
},
[CONST.SEARCH.GROUP_BY.WEEK]: {
titleIconName: 'Calendar',
getLabel: (item: GroupedItem) => (item as TransactionWeekGroupListItemType).formattedWeek ?? '',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.WEEK ? (item.formattedWeek ?? '') : ''),
getShortLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.WEEK ? item.shortFormattedWeek : undefined),
getLineChartLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.WEEK ? item.lineChartFormattedWeek : undefined),
axisLabelSteps: [1, 2, 4],
getFilterQuery: (item: GroupedItem) => {
const weekItem = item as TransactionWeekGroupListItemType;
const {start, end} = DateUtils.getWeekDateRange(weekItem.week);
if (item.groupedBy !== CONST.SEARCH.GROUP_BY.WEEK) {
return '';
}
const {start, end} = DateUtils.getWeekDateRange(item.week);
return `date>=${start} date<=${end}`;
},
getDateRange: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.WEEK ? DateUtils.getWeekDateRange(item.week) : undefined),
},
[CONST.SEARCH.GROUP_BY.YEAR]: {
titleIconName: 'Calendar',
getLabel: (item: GroupedItem) => (item as TransactionYearGroupListItemType).formattedYear ?? '',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.YEAR ? (item.formattedYear ?? '') : ''),
axisLabelSteps: [1, 2, 5],
getFilterQuery: (item: GroupedItem) => {
const yearItem = item as TransactionYearGroupListItemType;
const {start, end} = DateUtils.getYearDateRange(yearItem.year);
if (item.groupedBy !== CONST.SEARCH.GROUP_BY.YEAR) {
return '';
}
const {start, end} = DateUtils.getYearDateRange(item.year);
return `date>=${start} date<=${end}`;
},
getDateRange: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.YEAR ? DateUtils.getYearDateRange(item.year) : undefined),
},
[CONST.SEARCH.GROUP_BY.QUARTER]: {
titleIconName: 'Calendar',
getLabel: (item: GroupedItem) => (item as TransactionQuarterGroupListItemType).formattedQuarter ?? '',
getLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.QUARTER ? (item.formattedQuarter ?? '') : ''),
getShortLabel: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.QUARTER ? item.shortFormattedQuarter : undefined),
axisLabelSteps: [1, 2, 4],
getFilterQuery: (item: GroupedItem) => {
const quarterItem = item as TransactionQuarterGroupListItemType;
const {start, end} = DateUtils.getQuarterDateRange(quarterItem.year, quarterItem.quarter);
if (item.groupedBy !== CONST.SEARCH.GROUP_BY.QUARTER) {
return '';
}
const {start, end} = DateUtils.getQuarterDateRange(item.year, item.quarter);
return `date>=${start} date<=${end}`;
},
getDateRange: (item: GroupedItem) => (item.groupedBy === CONST.SEARCH.GROUP_BY.QUARTER ? DateUtils.getQuarterDateRange(item.year, item.quarter) : undefined),
Expand Down
253 changes: 249 additions & 4 deletions tests/unit/Search/chartGroupByConfigTest.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,259 @@
import CHART_GROUP_BY_CONFIG from '@components/Search/chartGroupByConfig';
import type {TransactionMerchantGroupListItemType} from '@components/Search/SearchList/ListItem/types';
import type {
TransactionCardGroupListItemType,
TransactionCategoryGroupListItemType,
TransactionMemberGroupListItemType,
TransactionMerchantGroupListItemType,
TransactionMonthGroupListItemType,
TransactionQuarterGroupListItemType,
TransactionTagGroupListItemType,
TransactionWeekGroupListItemType,
TransactionWithdrawalIDGroupListItemType,
TransactionYearGroupListItemType,
} from '@components/Search/SearchList/ListItem/types';
import type {GroupedItem, SearchGroupBy} from '@components/Search/types';

import CONST from '@src/CONST';

import type HybridAppModuleType from '@expensify/react-native-hybrid-app/src/types';

import createMock from '../../utils/createMock';

describe('chartGroupByConfig', () => {
// The Jest environment has no ReactNativeHybridApp module, which DateUtils loads through IntlStore and Log.
jest.mock('@expensify/react-native-hybrid-app', () => {
return {
__esModule: true,
default: {
isHybridApp: jest.fn<ReturnType<HybridAppModuleType['isHybridApp']>, Parameters<HybridAppModuleType['isHybridApp']>>(() => false),
},
};
});

type ChartGroupByCase = {
groupBy: SearchGroupBy;
item: GroupedItem;
expectedIcon: (typeof CHART_GROUP_BY_CONFIG)[SearchGroupBy]['titleIconName'];
expectedLabel: string;
expectedShortLabel?: string;
expectedFilterQuery: string;
};

const memberItem = createMock<TransactionMemberGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.FROM,
accountID: 0,
formattedFrom: 'Ada Lovelace',
});
const cardItem = createMock<TransactionCardGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.CARD,
cardID: 123,
formattedCardName: 'Travel card',
});

const cases: ChartGroupByCase[] = [
{
groupBy: CONST.SEARCH.GROUP_BY.FROM,
item: memberItem,
expectedIcon: 'Users',
expectedLabel: 'Ada Lovelace',
expectedFilterQuery: 'from:0',
},
{
groupBy: CONST.SEARCH.GROUP_BY.CARD,
item: cardItem,
expectedIcon: 'CreditCard',
expectedLabel: 'Travel card',
expectedFilterQuery: 'cardID:123',
},
{
groupBy: CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID,
item: createMock<TransactionWithdrawalIDGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID,
entryID: 456,
formattedWithdrawalID: '456',
}),
expectedIcon: 'Send',
expectedLabel: '456',
expectedFilterQuery: 'withdrawalID:456',
},
{
groupBy: CONST.SEARCH.GROUP_BY.CATEGORY,
item: createMock<TransactionCategoryGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.CATEGORY,
category: 'Travel meals',
formattedCategory: 'Travel meals',
}),
expectedIcon: 'Folder',
expectedLabel: 'Travel meals',
expectedFilterQuery: 'category:"Travel meals"',
},
{
groupBy: CONST.SEARCH.GROUP_BY.MERCHANT,
item: createMock<TransactionMerchantGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.MERCHANT,
merchant: 'Coffee shop',
formattedMerchant: 'Coffee shop',
}),
expectedIcon: 'Basket',
expectedLabel: 'Coffee shop',
expectedFilterQuery: 'merchant="Coffee shop"',
},
{
groupBy: CONST.SEARCH.GROUP_BY.TAG,
item: createMock<TransactionTagGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.TAG,
tag: 'Client visit',
formattedTag: 'Client visit',
}),
expectedIcon: 'Tag',
expectedLabel: 'Client visit',
expectedFilterQuery: 'tag:"Client visit"',
},
{
groupBy: CONST.SEARCH.GROUP_BY.MONTH,
item: createMock<TransactionMonthGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.MONTH,
year: 2025,
month: 6,
formattedMonth: 'June 2025',
shortFormattedMonth: 'Jun 25',
}),
expectedIcon: 'Calendar',
expectedLabel: 'June 2025',
expectedShortLabel: 'Jun 25',
expectedFilterQuery: 'date>=2025-06-01 date<=2025-06-30',
},
{
groupBy: CONST.SEARCH.GROUP_BY.WEEK,
item: createMock<TransactionWeekGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.WEEK,
week: '2025-06-09',
formattedWeek: 'Jun 9 - Jun 15, 2025',
shortFormattedWeek: 'Jun 9 - 15, 25',
}),
expectedIcon: 'Calendar',
expectedLabel: 'Jun 9 - Jun 15, 2025',
expectedShortLabel: 'Jun 9 - 15, 25',
expectedFilterQuery: 'date>=2025-06-09 date<=2025-06-15',
},
{
groupBy: CONST.SEARCH.GROUP_BY.YEAR,
item: createMock<TransactionYearGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.YEAR,
year: 2025,
formattedYear: '2025',
}),
expectedIcon: 'Calendar',
expectedLabel: '2025',
expectedFilterQuery: 'date>=2025-01-01 date<=2025-12-31',
},
{
groupBy: CONST.SEARCH.GROUP_BY.QUARTER,
item: createMock<TransactionQuarterGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.QUARTER,
year: 2025,
quarter: 3,
formattedQuarter: 'Q3 2025',
shortFormattedQuarter: 'Q3 25',
}),
expectedIcon: 'Calendar',
expectedLabel: 'Q3 2025',
expectedShortLabel: 'Q3 25',
expectedFilterQuery: 'date>=2025-07-01 date<=2025-09-30',
},
];

const optionalLabelCases: Array<Pick<ChartGroupByCase, 'groupBy' | 'item'>> = [
{
groupBy: CONST.SEARCH.GROUP_BY.FROM,
item: createMock<TransactionMemberGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.FROM,
accountID: 1,
}),
},
{
groupBy: CONST.SEARCH.GROUP_BY.CARD,
item: createMock<TransactionCardGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.CARD,
cardID: 2,
formattedCardName: '',
}),
},
{
groupBy: CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID,
item: createMock<TransactionWithdrawalIDGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID,
entryID: 3,
}),
},
{
groupBy: CONST.SEARCH.GROUP_BY.CATEGORY,
item: createMock<TransactionCategoryGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.CATEGORY,
category: '',
formattedCategory: '',
}),
},
{
groupBy: CONST.SEARCH.GROUP_BY.MERCHANT,
item: createMock<TransactionMerchantGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.MERCHANT,
merchant: '',
}),
},
{
groupBy: CONST.SEARCH.GROUP_BY.TAG,
item: createMock<TransactionTagGroupListItemType>({
groupedBy: CONST.SEARCH.GROUP_BY.TAG,
tag: '',
formattedTag: '',
}),
},
];

describe('CHART_GROUP_BY_CONFIG', () => {
it('uses the explicit exact operator for merchant drill-downs', () => {
const item = createMock<TransactionMerchantGroupListItemType>({merchant: 'I'});
// Given a merchant group whose short name must match exactly.
const item = createMock<TransactionMerchantGroupListItemType>({groupedBy: CONST.SEARCH.GROUP_BY.MERCHANT, merchant: 'I'});

// When the chart builds its merchant drill-down query.
const query = CHART_GROUP_BY_CONFIG[CONST.SEARCH.GROUP_BY.MERCHANT].getFilterQuery(item);

// Then the exact operator prevents matching merchants that only contain this name.
expect(query).toBe('merchant="I"');
});

test.each(cases)('returns the $groupBy chart values for a matching item', ({groupBy, item, expectedIcon, expectedLabel, expectedShortLabel, expectedFilterQuery}) => {
// Given a producer-shaped item for the selected group.
const config = CHART_GROUP_BY_CONFIG[groupBy];

// When the chart reads its label and drill-down configuration.
// Then the matching group preserves its display values and filter.
expect(config.titleIconName).toBe(expectedIcon);
expect(config.getLabel(item)).toBe(expectedLabel);
expect(config.getShortLabel?.(item)).toBe(expectedShortLabel);
expect(config.getFilterQuery(item)).toBe(expectedFilterQuery);
});

test.each(cases)('rejects an item that does not match the $groupBy configuration', ({groupBy}) => {
// Given a valid item from a different group.
const config = CHART_GROUP_BY_CONFIG[groupBy];
const mismatchedItem = groupBy === CONST.SEARCH.GROUP_BY.FROM ? cardItem : memberItem;

// When the selected configuration receives the other group.
// Then it returns empty values instead of reading unrelated fields.
expect(config.getLabel(mismatchedItem)).toBe('');
expect(config.getShortLabel?.(mismatchedItem)).toBeUndefined();
expect(config.getFilterQuery(mismatchedItem)).toBe('');
});

test.each(optionalLabelCases)('returns an empty label for an absent or empty optional $groupBy label', ({groupBy, item}) => {
// Given a matching item with an absent or empty display label.
const config = CHART_GROUP_BY_CONFIG[groupBy];

// When the chart requests the optional label.
const label = config.getLabel(item);

expect(CHART_GROUP_BY_CONFIG[CONST.SEARCH.GROUP_BY.MERCHANT].getFilterQuery(item)).toBe('merchant="I"');
// Then the display fallback remains an empty string.
expect(label).toBe('');
});
});
Loading