Repository navigation
[Payment due @gijoe0295] Update Add to Apple Wallet (IOS only) - #100404
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea2add2441
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: mWeb Chrome |
gijoe0295
left a comment
There was a problem hiding this comment.
Code looks good & tests well. Still needs Design confirmation on UI change.
|
BUG: If the card is added successfully, this text has wide spacing:
App/src/components/AddToWalletButton/index.native.tsx Lines 109 to 115 in ce60d13 |
Does that only show when you first come back to the view? Almost wondering if we should just use a growl for that and not worry about putting it right into the RHP UI? cc @Expensify/design for thoughts. |
It'll show permanently every time you open the card detail RHP. |
|
Interesting, what does it currently look like (before this PR)? I kinda think we wouldn't want to keep that information so high up in the RHP... let's see what Danny and Jon think though. |
|
Fixed the review comments, except this one: #100404 (comment) |
|
Conflicts resolved and pushed to What happened: Resolution: kept both sides in all three files. They're distinct features, and
Verification
I did not run a browser test:
|
gijoe0295
left a comment
There was a problem hiding this comment.
LGTM. @hungvu193 Can you merge main to fix the tests? Latest screenshots are in this
|
🎯 @gijoe0295, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@MelvinBot Merge main please |
Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
|
🤖 Merged The branch was 947 commits behind. Merge commit: |
|
@gijoe0295 Can you approve again? There was no internal engineer was auto assign 😅 |
|
|
||
| import type AddToWalletStatusTextProps from './types'; | ||
|
|
||
| const platform = getPlatform() === CONST.PLATFORM.IOS ? 'Apple' : 'Google'; |
There was a problem hiding this comment.
Can we use platform specific files here?
There was a problem hiding this comment.
I'd say no. Minor change and we already use platform-specific here (.native.ts), we also use the same approach with AddToWalletButton
There was a problem hiding this comment.
"No" we can't or "no" you'd rather not?
I think we should, per the guidelines
|
I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually. |
|
🚧 AndrewGable has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.4.91-0 🚀
|
|
🤖 Yes — help site changes are required. Draft PR: Docs updates for E/A#100404 Apple Wallet confirmation screen and added-to-wallet label Two cardholder-visible changes in this PR were undocumented:
Only one article covers this flow: What changed in the article, and how labels were verified
Every label is copied verbatim from the strings this PR added to No changes were made to @MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Hey @hungvu193. The confirmation screen is not displayed on our side. Instead, we see a modal saying “Failed to…”, but it’s the same behavior as shown in the video attached to the PR. 100404I.mp4 |
I'm using purely code to make it successful on dev so I'm not sure to do it on Prod 👀 |
|
I think this is going to have to be tested on production |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #101978 |





Explanation of Change
Update Add to Wallet button and a screen to show the confirmation page once the Apple Wallet is added.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/678322
PROPOSAL: N/A
Tests
Add to apple walletbutton is placed correctly.Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Screen.Recording.2026-09-04.at.21.02.17.mov