[Merge ATS] Generalize merge connection for ATS by bernhardoj · Pull Request #100581 · Expensify/App

bernhardoj · 2026-09-08T10:37:53Z

Explanation of Change

Fixed Issues

$ #99511
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a workspace with Recruiting enabled

Open the Recruiting page
Press Connect on the Greenhouse integration
Verify a Merge Link UI shows
Proceed with the setup
After completion, close the Merge Link UI and go back to ND
Verify a syncing modal is shown
Dismiss the modal
Verify the connection starts syncing

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

output.mp4

Android: mWeb Chrome

output.mp4

iOS: Native

output.mp4

iOS: mWeb Safari

output.mp4

MacOS: Chrome / Safari

output.mp4

melvin-bot · 2026-09-08T10:37:58Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

bernhardoj · 2026-09-08T10:39:11Z

@ishpaul777 let me know when the merge setup link is ready.

I currently see this
{"responseMessage":"inputSettings.integration 'greenhouse' is not supported for category 'hris'","responseCode":400}

codecov · 2026-09-08T10:41:42Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/connections/index.ts	`21.70% <ø> (-0.61%)`	⬇️
src/libs/actions/connections/merge/ATS.ts	`100.00% <ø> (ø)`
src/libs/actions/connections/merge/HR.ts	`0.00% <ø> (ø)`
src/libs/actions/connections/merge/index.ts	`21.21% <100.00%> (+7.87%)`	⬆️
src/pages/workspace/hr/WorkspaceHRPage.tsx	`0.00% <ø> (ø)`
src/components/ConnectToMergeFlow/index.ios.tsx	`0.00% <0.00%> (ø)`
src/components/ConnectToMergeFlow/index.native.tsx	`0.00% <0.00%> (ø)`
src/components/ConnectToMergeFlow/index.tsx	`0.00% <0.00%> (ø)`
src/hooks/useMergeInitialSyncingModal.ts	`0.00% <0.00%> (ø)`
...pages/workspace/merge/MergeConnectionsPageBase.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

ishpaul777 · 2026-09-08T10:46:15Z

@ishpaul777 let me know when the merge setup link is ready.

I currently see this {"responseMessage":"inputSettings.integration 'greenhouse' is not supported for category 'hris'","responseCode":400}

can you check staging looks like it was deployed to staging yesterday

bernhardoj · 2026-09-08T10:55:36Z

Hmm, Use Staging Server is enabled already.

Oh, you mean the setup link? Let me try.

bernhardoj · 2026-09-08T14:37:57Z

Sorry, just have the time to test it now. Yes, staging works, but I need an API key, which you already asked for on Slack. So waiting on that now.

melvin-bot · 2026-09-15T15:32:18Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

Core design doc issue. Good for product.

DylanDylann · 2026-09-16T08:10:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-09-16.at.16.53.01.mov

Android: mWeb Chrome

Screen.Recording.2026-09-16.at.16.41.47.mov

iOS: HybridApp

Screen.Recording.2026-09-16.at.16.51.12.mov

iOS: mWeb Safari

Screen.Recording.2026-09-16.at.16.36.29.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-16.at.16.27.12.mov

DylanDylann · 2026-09-16T08:18:40Z

@bernhardoj Please merge the latest main

bernhardoj · 2026-09-16T08:33:48Z

Done

github-actions · 2026-09-16T18:13:15Z

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-09-16T18:17:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100581.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4694e6a-7d4d08b-550788cc5a023dec87300d2d752bdf1cacd82a90/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4694e6a-7d4d08b-91f5f1da6064eaebeb8f38d0f4417e63269587d3/index.html

Web 🕸️
https://100581.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-16T18:18:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-09-16T19:48:15Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.81-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-09-17T22:14:31Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-09-17T22:26:08Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

generalize merge connection for ATS

affa73d

melvin-bot Bot assigned bernhardoj Sep 8, 2026

update locale structure

3b9289e

Merge branch 'main' into feat/99511-ats-merge-connection

82708b4

bernhardoj marked this pull request as ready for review September 15, 2026 15:32

bernhardoj requested review from a team as code owners September 15, 2026 15:32

melvin-bot Bot requested review from DylanDylann and joekaufmanexpensify and removed request for a team September 15, 2026 15:32

joekaufmanexpensify previously approved these changes Sep 15, 2026

View reviewed changes

DylanDylann reviewed Sep 16, 2026

View reviewed changes

Comment thread src/pages/workspace/merge/MergeConnectionsPageBase.tsx Resolved

bernhardoj added 2 commits September 16, 2026 16:31

Refactor MergeConnectionsPageBase component structure

8854517

Merge branch 'main' into feat/99511-ats-merge-connection

95d3f7d

bernhardoj dismissed joekaufmanexpensify’s stale review via 95d3f7d September 16, 2026 08:33

DylanDylann approved these changes Sep 16, 2026

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon September 16, 2026 09:38

yuwenmemon approved these changes Sep 16, 2026

View reviewed changes

yuwenmemon merged commit 4694e6a into Expensify:main Sep 16, 2026
37 of 39 checks passed

OSBotify mentioned this pull request Sep 16, 2026

Deploy Checklist: New Expensify 2026-09-16 #101366

Closed

48 tasks done

This was referenced Sep 17, 2026

NetSuite - 2FA required to connect #101408

Closed

NetSuite - Tax import fails with a OAuth 2.0 #101409

Open

melvin-bot Bot mentioned this pull request Sep 17, 2026

R1: Generalize the Merge connection UI for ATS #99511

Closed

Conversation

bernhardoj commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 8, 2026

Uh oh!

bernhardoj commented Sep 8, 2026

Uh oh!

codecov Bot commented Sep 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ishpaul777 commented Sep 8, 2026

Uh oh!

bernhardoj commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Sep 8, 2026

Uh oh!

melvin-bot Bot commented Sep 15, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

DylanDylann commented Sep 16, 2026

Uh oh!

bernhardoj commented Sep 16, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 16, 2026

Uh oh!

github-actions Bot commented Sep 16, 2026

Uh oh!

OSBotify commented Sep 16, 2026

Uh oh!

OSBotify commented Sep 16, 2026

Uh oh!

OSBotify commented Sep 17, 2026

Uh oh!

OSBotify commented Sep 17, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bernhardoj commented Sep 8, 2026 •

edited

Loading

codecov Bot commented Sep 8, 2026 •

edited by github-actions Bot

Loading

bernhardoj commented Sep 8, 2026 •

edited

Loading

DylanDylann commented Sep 16, 2026 •

edited

Loading