Skip to content

Upgrade Blacksmith checkout action - #100619

Merged
iwiznia merged 4 commits into
mainfrom
ionatan/blacksmith-checkout-container
Sep 8, 2026
Merged

iwiznia merged 4 commits into
mainfrom
ionatan/blacksmith-checkout-container

Conversation

@iwiznia

@iwiznia iwiznia commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Issue

https://github.com/Expensify/Expensify/issues/679682

Details

  • Upgrade useblacksmith/checkout to f50565632710173b0e366f2cd39b928d31362815.
  • Enable allow-inside-container and dissociate for every checkout step.
  • Add --privileged -v /dev:/dev to affected job containers.

Tests

  • Not run (GitHub Actions workflow-only changes).

@iwiznia
iwiznia requested a review from a team as a code owner September 8, 2026 17:21
@melvin-bot
melvin-bot Bot requested review from chiragsalian and removed request for a team September 8, 2026 17:22
@melvin-bot

melvin-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

This comment has been minimized.

@iwiznia
iwiznia requested review from coleaeason and removed request for chiragsalian September 8, 2026 17:46
coleaeason
coleaeason previously approved these changes Sep 8, 2026
Comment thread .github/workflows/androidBump.yml Outdated
Comment on lines +14 to +16
with:
allow-inside-container: true
dissociate: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be removed from this workflow, it doesn't run in a container. this applies to this whole repo

@OSBotify

This comment has been minimized.

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://eb6b1be1.helpdot.pages.dev ⚡️

@iwiznia
iwiznia merged commit e4a52b1 into main Sep 8, 2026
19 of 20 checks passed
@iwiznia
iwiznia deleted the ionatan/blacksmith-checkout-container branch September 8, 2026 20:37
@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 9, 2026
83 tasks done
@OSBotify

OSBotify commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.4.75-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets

Copy link
Copy Markdown

Hi @iwiznia. Any QA steps?

cc @coleaeason

@iwiznia

iwiznia commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Oh sorry, yeah, check it off

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants