Repository navigation
[NoQA] [Insights] Move the Account button to the top bar - #100705
Merged
cristipaval merged 23 commits intoSep 16, 2026
Merged
cristipaval merged 23 commits into
cristipaval merged 23 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
1 task done
…ttonContent to improve performance when button is not to be shown
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 8a9bea44..8d58e53c 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -10900,6 +10900,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
gpsTooltip: '<tooltip>GPS-Tracking läuft! Wenn du fertig bist, stoppe die Aufzeichnung unten.</tooltip>',
hasFilterNegation: '<tooltip>Suchen Sie nach Ausgaben ohne Belege mit <strong>-has:receipt</strong>.</tooltip>',
mileageRateAutoUpdated: '<tooltip>Wir haben den Kurs basierend auf Ihrem Reisedatum aktualisiert.</tooltip>',
+ accountMovedToTopBar: '<tooltip>Greifen Sie auf Ihr Konto und Ihre persönlichen Einstellungen zu.</tooltip>',
},
discardChangesConfirmation: {
title: 'Änderungen verwerfen?',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 770d8319..2c358317 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -11092,6 +11092,7 @@ ${reportName}`,
gpsTooltip: '<tooltip>Η παρακολούθηση GPS βρίσκεται σε εξέλιξη! Όταν τελειώσετε, διακόψτε την παρακολούθηση παρακάτω.</tooltip>',
hasFilterNegation: '<tooltip>Αναζητήστε δαπάνες χωρίς αποδείξεις χρησιμοποιώντας το <strong>-has:receipt</strong>.</tooltip>',
mileageRateAutoUpdated: '<tooltip>Ενημερώσαμε την τιμή με βάση την ημερομηνία του ταξιδιού σας.</tooltip>',
+ accountMovedToTopBar: '<tooltip>Αποκτήστε πρόσβαση στον λογαριασμό και τις προσωπικές σας ρυθμίσεις.</tooltip>',
},
discardChangesConfirmation: {
title: 'Απόρριψη αλλαγών;',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 2135f39b..4f54981a 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -11104,6 +11104,7 @@ ${reportName}`,
gpsTooltip: '<tooltip>¡Seguimiento por GPS en curso! Cuando termines, detén el seguimiento a continuación.</tooltip>',
hasFilterNegation: '<tooltip>Busca gastos sin recibos usando <strong>-has:receipt</strong>.</tooltip>',
mileageRateAutoUpdated: '<tooltip>Hemos actualizado la tasa según tu fecha de viaje.</tooltip>',
+ accountMovedToTopBar: '<tooltip>Accede a tu cuenta y a tu configuración personal.</tooltip>',
},
discardChangesConfirmation: {
title: '¿Descartar cambios?',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 54614b92..6ac29e93 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -10921,6 +10921,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
gpsTooltip: '<tooltip>Suivi GPS en cours ! Lorsque vous avez terminé, arrêtez le suivi ci-dessous.</tooltip>',
hasFilterNegation: '<tooltip>Recherchez les dépenses sans reçus à l’aide de <strong>-has:receipt</strong>.</tooltip>',
mileageRateAutoUpdated: '<tooltip>Nous avons mis à jour le taux en fonction de votre date de voyage.</tooltip>',
+ accountMovedToTopBar: '<tooltip>Accédez à votre compte et à vos paramètres personnels.</tooltip>',
},
discardChangesConfirmation: {
title: 'Ignorer les modifications ?',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 23ae5c1f..1b223164 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -10854,6 +10854,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
gpsTooltip: '<tooltip>Tracciamento GPS in corso! Quando hai finito, interrompi il tracciamento qui sotto.</tooltip>',
hasFilterNegation: '<tooltip>Cerca le spese senza ricevute usando <strong>-has:receipt</strong>.</tooltip>',
mileageRateAutoUpdated: '<tooltip>Abbiamo aggiornato il tasso in base alla tua data di viaggio.</tooltip>',
+ accountMovedToTopBar: '<tooltip>Accedi al tuo account e alle impostazioni personali.</tooltip>',
},
discardChangesConfirmation: {
title: 'Scartare le modifiche?',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 52f9476c..5c3533f4 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -10708,6 +10708,7 @@ ${reportName}`,
gpsTooltip: '<tooltip>GPS追跡を実行中です！完了したら、下で追跡を停止してください。</tooltip>',
hasFilterNegation: '<tooltip><strong>-has:receipt</strong> を使って、レシートのない経費を検索します。</tooltip>',
mileageRateAutoUpdated: '<tooltip>出張日にもとづいてレートを更新しました。</tooltip>',
+ accountMovedToTopBar: '<tooltip>アカウントと個人設定にアクセスします。</tooltip>',
},
discardChangesConfirmation: {
title: '変更を破棄しますか？',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index eb530a0e..b4a407eb 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -10820,6 +10820,7 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
gpsTooltip: '<tooltip>GPS-tracking bezig! Als je klaar bent, stop dan hieronder met bijhouden.</tooltip>',
hasFilterNegation: '<tooltip>Zoek naar uitgaven zonder bonnen met <strong>-has:receipt</strong>.</tooltip>',
mileageRateAutoUpdated: '<tooltip>We hebben het tarief bijgewerkt op basis van je reisdatum.</tooltip>',
+ accountMovedToTopBar: '<tooltip>Ga naar je account en persoonlijke instellingen.</tooltip>',
},
discardChangesConfirmation: {
title: 'Wijzigingen negeren?',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index de72057d..d5114b33 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -10842,6 +10842,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
gpsTooltip: '<tooltip>Śledzenie GPS w toku! Gdy skończysz, zatrzymaj śledzenie poniżej.</tooltip>',
hasFilterNegation: '<tooltip>Wyszukaj wydatki bez paragonów za pomocą <strong>-has:receipt</strong>.</tooltip>',
mileageRateAutoUpdated: '<tooltip>Zaktualizowaliśmy stawkę na podstawie daty twojej podróży.</tooltip>',
+ accountMovedToTopBar: '<tooltip>Uzyskaj dostęp do swojego konta i ustawień osobistych.</tooltip>',
},
discardChangesConfirmation: {
title: 'Odrzucić zmiany?',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 26383837..0d9e0631 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -10815,6 +10815,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
gpsTooltip: '<tooltip>Rastreamento por GPS em andamento! Quando terminar, pare o rastreamento abaixo.</tooltip>',
hasFilterNegation: '<tooltip>Pesquise despesas sem recibos usando <strong>-has:receipt</strong>.</tooltip>',
mileageRateAutoUpdated: '<tooltip>Nós atualizamos a taxa com base na sua data de viagem.</tooltip>',
+ accountMovedToTopBar: '<tooltip>Acesse sua conta e configurações pessoais.</tooltip>',
},
discardChangesConfirmation: {
title: 'Descartar alterações?',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 2459b6c6..3d92258f 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -10440,6 +10440,7 @@ ${reportName}`,
gpsTooltip: '<tooltip>正在进行 GPS 跟踪！完成后，请在下方停止跟踪。</tooltip>',
hasFilterNegation: '<tooltip>使用 <strong>-has:receipt</strong> 搜索没有收据的报销。</tooltip>',
mileageRateAutoUpdated: '<tooltip>我们已根据您的出行日期更新了汇率。</tooltip>',
+ accountMovedToTopBar: '<tooltip>访问你的账户和个人设置。</tooltip>',
},
discardChangesConfirmation: {
title: '放弃更改？',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
sumo-slonik
reviewed
Sep 10, 2026
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
heyjennahay
and removed request for
a team
September 10, 2026 15:00
Member
Author
|
cc: @Expensify/design my reasoning as to on which pages to show the button was: if we show the navigation tab bar there, we show the Account button in the top bar, if not then we don't. please let me know if that's not the desired behavior also this is what it looks like selected: and on hover: I also replaced the Concierge Anywhere button under beta only, let me know if you'd like it to change already for all users |
JmillsExpensify
requested review from
JmillsExpensify
and removed request for
heyjennahay
September 10, 2026 15:36
Contributor
Mind explaining this one a bit more? The intention is to start with Accounting only being visible on the top-level pages. For example:
And so on and so forth. |
Member
Author
okay, thanks for clarifying, I'll make changes. that is the behavior for both the wide and narrow layouts? |
Member
Author
|
oh, per design doc: "To free up a top-level slot, we move Account to the top bar on all desktop pages; on mobile we show the Account avatar on top-level pages (Home, Inbox, Spend, Insights, Workspaces)" so I guess that's only for mobile? |
aldo-expensify
approved these changes
Sep 15, 2026
cristipaval
approved these changes
Sep 15, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.mp4Android: mWeb Chromeandroid.mweb.mp4iOS: HybridAppios.mp4iOS: mWeb Safariios.mweb.mp4MacOS: Chrome / Safariweb.mp4 |
bernhardoj
approved these changes
Sep 16, 2026
melvin-bot
Bot
requested review from
aldo-expensify,
cristipaval and
luacmartins
September 16, 2026 01:00
aldo-expensify
approved these changes
Sep 16, 2026
cristipaval
approved these changes
Sep 16, 2026
Contributor
|
🚧 cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
luacmartins
reviewed
Sep 16, 2026
luacmartins
left a comment
luacmartins
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this!
48 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.4.81-0 🚀
|
1 of 7 tasks
|
Deploy Blocker #101380 was identified to be related to this PR. |
1 of 7 tasks
1 of 7 tasks
|
Deploy Blocker #101405 was identified to be related to this PR. |
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
1 similar comment
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
Contributor
|
@mhawryluk can you do a quick follow up here and add a little bit of space between the Concierge icon and the account avatar, so all of the gaps look visually the same? Before/Now: After (add margin-right: 4px to Concierge): |
Member
Author
|
sure, I have a bug fix PR coming up, so I'll include it there! |
38 tasks done
1 of 7 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Moves the Account tab button from the navigation tab bar to the top bar on narrow layouts. Extends
TopBarandHeaderWithBackButtoncomponents to render the button, similar to how Concierge Anywhere is currently implemented.TopBaralways renders it,HeaderWithBackButtonis opt-in as it has a wide variety of usages, most of which do not need the button. Also adds an educational tooltip attached to the button being moved. All gated by theinsightsPagebeta.Fixed Issues
$ #100651
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
No tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Nagranie.z.ekranu.2026-09-9.o.14.59.55.mov
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.-.2026-09-10.at.16.31.46.mov
Simulator.Screen.Recording.-.iPhone.17.-.2026-09-10.at.16.33.13.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-15.o.10.50.58.mov