Skip to content

Unpin the contact method child screens from the profile - #100780

Merged
roryabraham merged 2 commits into
Expensify:mainfrom
mukhrr:fix/100765
Sep 10, 2026
Merged

roryabraham merged 2 commits into
Expensify:mainfrom
mukhrr:fix/100765

Conversation

@mukhrr

@mukhrr mukhrr commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

#100292 unpinned the contact methods list from SETTINGS.PROFILE.ROOT so its background follows the base path, but left the three screens that hang off it pinned: DYNAMIC_CONTACT_METHOD_DETAILS, DYNAMIC_NEW_CONTACT_METHOD and DYNAMIC_NEW_CONTACT_METHOD_CONFIRM_VALIDATE_CODE. getMatchingFullScreenRoute checks the relation maps before the dynamic base-path branch, so on a fresh load of a URL whose base is itself an RHP (/e/:reportID, /search/r/:reportID, /search/view/:reportID) the pinned entry wins and the background resolves to Account > Profile.

In-app navigation never hit this, because linkTo skips the full-screen matching block while an RHP is already on top. That is why the background only jumps on refresh, and why #100292 looked complete.

All three hang off CONTACT_METHODS, which declares entryScreens: ['*'], so they can sit over any base path and none of them should name a central pane. Deep links under /settings/profile/contact-methods still resolve the settings split, since the base path itself resolves it.

Fixed Issues

$ #100765
PROPOSAL:

Tests

Use an account with no phone number contact method, so the "Add your number" link is rendered.

  1. Open a workspace chat and create an expense.
  2. Open the report.
  3. Note which page is behind the expense, then refresh the page and confirm the same page is still behind it. This is the background the next steps are compared against.
  4. Click "Add your number" on the add receipt modal.
  5. Click on the contact email.
  6. Refresh the page.
  7. Verify the background is the same page as in step 3, and has not changed to Account > Profile.
  8. Click the back button, then click "New contact method".
  9. Refresh the page.
  10. Verify the background is again the same page as in step 3.
  • Verify that no errors appear in the JS console

Offline tests

The change only affects which full screen is resolved under the right hand panel on a fresh load, so it has no network surface. Going offline before step 1 and repeating the flow gives the same result, and the background still matches step 3 after each refresh.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
REC-20260910115108.mp4

The contact methods list was unpinned so its background follows the base
path, but the details and new contact method screens hanging off it stayed
pinned to the profile root. getMatchingFullScreenRoute checks the relation
maps before the dynamic base-path branch, so on a fresh load of a URL whose
base is itself an RHP the pinned entry wins and the background jumps to
Account > Profile. In-app navigation never hit this because linkTo skips the
full-screen matching block while an RHP is already on top, so the jump only
showed on refresh.

All three hang off CONTACT_METHODS, which declares entryScreens: ['*'], so
they can sit over any base path and none of them should name a central pane.
@mukhrr
mukhrr requested review from a team as code owners September 10, 2026 03:07
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and dmkt9 and removed request for a team September 10, 2026 03:07
@melvin-bot

melvin-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 10, 2026 03:07
The pinned relations only bite on a cold load, because linkTo skips full
screen matching while an RHP is already on top. A test that walks the app
would never have caught it, so assert the resolved background straight from
the URL instead, including the bases that are themselves RHP routes.
@dmkt9

dmkt9 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

chrome.mp4

@dmkt9 dmkt9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from roryabraham September 10, 2026 14:20
@mukhrr

mukhrr commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor Author

@dmkt9 oh sorry. I didn't warn you. I am pushing fix for this bug as well

@roryabraham
roryabraham merged commit edeeafc into Expensify:main Sep 10, 2026
36 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.76-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR, so I did not create a docs PR.

This change is internal navigation config only. It removes three contact method screens from the SETTINGS.PROFILE.ROOT entry in src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts, plus a new test file. Nothing else changed.

Why the help site is unaffected

The help site documents what users do, not which page renders behind an overlay. This PR changes neither:

  • No new or renamed feature, setting, tab, or button. The diff touches only a route-relation map and adds tests/navigation/contactMethodsBackgroundTests.ts.
  • No change to any documented step. The steps for adding, verifying, or removing a contact method are identical before and after. /settings/profile/contact-methods deep links still resolve the settings split, which the new tests assert explicitly.
  • No documented behavior contradicted. I searched docs/articles for the affected surfaces. The articles that cover contact methods — for example Update-Email-Address.md and expensify-classic/settings/Contact-Methods.md — describe navigation paths and actions, never the background page behind the right-hand panel. No article mentions page-refresh behavior on those screens.

Per HELP_AUTHORING_GUIDELINES.md, help content covers user-facing tasks and concepts. A bug fix that restores the intended background on refresh produces no new instruction, no new label, and no changed outcome for the reader, so there is nothing to add or correct.

@mukhrr, if you believe a user-facing behavior did change here that the help site should describe, reply with the specific article and behavior and I'll draft the docs PR.


view run · no recording available

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.76-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants