[mountiny]

Explanation of Change

This reverts Add beta override switches to the Test Tool menu.

The revert removes the Beta overrides page, the betaOverrides Onyx key and its type, BetaOverridesContext, the Beta overrides row in TestToolMenu, the /beta-overrides route and RHP screen, the overrides parameter on Permissions.isBetaEnabled, the copy in all ten languages, and the tests added by that PR. tests/ui/TestToolMenuTest.tsx goes back to its previous name, tests/ui/TestToolMenuBiometricsTest.tsx.

Three conflicts came up against current main and were resolved as follows:

1. src/libs/actions/SignInRedirect.ts — main moved the preserved keys into a KEYS_TO_PRESERVE_ON_SIGN_OUT array after the PR merged. The array stays and only ONYXKEYS.BETA_OVERRIDES is dropped from it.
2. src/hooks/useTransactionInlineEdit.ts — main added a rules Onyx read next to the usePermissions() call. The rules read stays and only the usePermissions() call goes away.
3. src/pages/settings/Troubleshoot/BetaOverridesPage.tsx — the file was touched after the PR merged by the repo wide ButtonComposed to Button rename. The file is deleted, so that rename does not apply to it.

npx tsc --noEmit passes and the four affected test suites pass (66 tests).

Fixed Issues

$ #100851
PROPOSAL:

Tests

1. Sign in to the app on web.
2. Open Settings > Troubleshoot.
3. Verify that no Beta overrides row appears in the Test Tool menu.
4. Open the hidden Test Tools modal.
5. Verify that no Beta overrides row appears there either.
6. Navigate to /beta-overrides directly in the URL bar.
7. Verify that the not found page appears.
8. Toggle a switch in the Test Tool menu, for example Use Staging Server, and verify that it still works.
9. Sign out and sign back in, then verify that the app loads normally.
10. Open an expense report, edit an expense field inline, and verify that the edit saves.

• Verify that no errors appear in the JS console

Offline tests

1. Turn off your network connection.
2. Open Settings > Troubleshoot.
3. Verify that the page renders and that no Beta overrides row appears.
4. Turn your network connection back on and verify that the page still renders correctly.

QA Steps

1. Sign in to the app.
2. Open Settings > Troubleshoot.
3. Verify that no Beta overrides row appears in the Test Tool menu.
4. Open the hidden Test Tools modal and verify that no Beta overrides row appears there.
5. Navigate to /beta-overrides directly and verify that the not found page appears.
6. Sign out and sign back in, then verify that the app loads normally.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100856.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://100856.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀