Repository navigation
[NoQA] [Insights] Add "Go to Insights" option to the search router - #100946
luacmartins merged 3 commits into
Conversation
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-09-12.at.23.47.33.mov |
daledah
left a comment
There was a problem hiding this comment.
The code changes LGTM and tested well
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.78-0 🚀
|
|
Yes, help site changes are required. Draft PR: #101134 Two published articles document the Search router's top-level destinations and how to reach Insights, and neither mentioned the new Go to Insights row:
Because the row is gated behind the Live UI verification and one extra correctionI drove the running app to confirm the destination labels rather than trusting the docs. Typing That surfaced a pre-existing gap: both destination lists also omitted Domains. Since it sits in the exact sentences I was already editing, I added it there too. Flagging it explicitly because it is outside the scope of your PR — say the word and I'll drop it. Placement of Insights follows The articles were written against One thing worth your judgment: the dedicated Insights page this navigates to is itself beta-gated, while the existing Insights articles describe Insights as living under Spend. I kept the wording neutral about which surface opens, but if the beta page replaces the Spend section at rollout, those articles will need a follow-up pass. @mhawryluk, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds a "Go to Insights" option to the search router, matching other tabs. Gated behind the
insightsPagebeta.Fixed Issues
$ #100913
PROPOSAL: N/A
Tests
insightsPagebeta.Offline tests
Same as tests, but offline.
QA Steps
No tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-11.o.12.08.09.mov