[Payment due @thelullabyy] Use useSortedReportActionsData instead of useSortedActions by sosek108 · Pull Request #100947 · Expensify/App

sosek108 · 2026-09-11T10:21:01Z

Explanation of Change

Prep PR 4/4 decomposing #99062 ("Route Search previews through the shared LHN alternate text pipeline").

Replaces the narrow useSortedActions hook (which only returned sortedActions) with useSortedReportActionsData, which returns the whole RAM_ONLY_SORTED_REPORT_ACTIONS derived value. Every consumer keeps behaving identically by destructuring sortedActions off the returned object; no other behavior changes.

$ #98958
PROPOSAL:

Tests

Open the Search Router (CMD+K) and the "Share" tab, and the "In" filter selector on Search.
Verify sorting/filtering of report/action-based options behaves exactly as on main (no visible change is expected).

Verify that no errors appear in the JS console

Offline tests

N/A — no data-fetching or network-dependent behavior is touched by this rename.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-09-11.o.14.45.55.mov

codecov · 2026-09-11T10:24:25Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../components/Search/FilterComponents/InSelector.tsx	`89.61% <100.00%> (+0.13%)`	⬆️
src/components/Search/SearchAutocompleteList.tsx	`88.42% <100.00%> (+0.05%)`	⬆️
...rc/components/Search/SearchRouter/SearchRouter.tsx	`72.41% <100.00%> (+0.15%)`	⬆️
.../Search/SearchRouter/SearchRouterOptionsWarmer.tsx	`96.66% <100.00%> (ø)`
src/hooks/useAutocompleteSuggestions.ts	`73.52% <100.00%> (+0.13%)`	⬆️
src/hooks/useFilteredOptions.ts	`84.61% <100.00%> (+0.61%)`	⬆️
src/hooks/useSearchSelector/base.ts	`87.90% <100.00%> (+0.09%)`	⬆️
src/hooks/useSortedReportActionsData.ts	`100.00% <100.00%> (ø)`
src/pages/Share/ShareTab.tsx	`0.00% <0.00%> (ø)`
... and 14 files with indirect coverage changes

sosek108 · 2026-09-11T12:48:16Z

@codex review

melvin-bot · 2026-09-11T12:48:46Z

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-09-11T12:50:59Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 94b9f33467

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

thelullabyy · 2026-09-15T08:46:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-09-15.at.18.47.18.mov

melvin-bot · 2026-09-15T10:48:41Z

🎯 @thelullabyy, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

github-actions · 2026-09-15T13:23:56Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-15T13:26:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-15T13:28:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100947.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d22a64c-25042b9-61fda5095641df73c8a0730bd2f75c4f86cdf524/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d22a64c-25042b9-8e20a5db0ad06671f5618904edf7813258da8580/index.html

Web 🕸️
https://100947.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-16T00:02:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-16T00:05:46Z

🤖 No help site changes are required. I did not create a draft docs PR.

This PR is a pure internal refactor: it renames the useSortedActions hook to useSortedReportActionsData and has each consumer destructure sortedActions off the returned object. Nothing user-facing changes — no new feature, no renamed UI label, no changed flow, and no altered behavior in the Search Router, the Share tab, or the In filter. Your own test plan confirms this ("no visible change is expected").

What I checked

Every changed file is source or test code — none are under docs/:

src/hooks/useSortedActions.ts (deleted) → src/hooks/useSortedReportActionsData.ts
Import and call-site updates only in InSelector.tsx, SearchAutocompleteList.tsx, SearchRouter.tsx, SearchRouterOptionsWarmer.tsx, useAutocompleteSuggestions.ts, useFilteredOptions.ts, useSearchSelector/base.ts, ShareTab.tsx
One test rename in tests/ui/InSelectorTest.tsx

Help site scan: I grepped docs/ for useSortedActions, useSortedReportActionsData, and sortedActions — zero matches. The help site documents user-facing behavior, not internal hook names, so there is nothing to update.

Help site articles would only need an update if this PR changed what someone sees or does in the product — for example a new filter, a renamed tab, or different search results. This PR changes none of those.

@sosek108, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

Note: there is no linked help site PR to review, because this refactor requires no documentation changes. If you believe a user-facing behavior did change here that I missed, reply with the specific flow and I'll draft the docs update.

view run

OSBotify · 2026-09-16T19:25:55Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android

melvin-bot · 2026-09-16T19:27:12Z

🤖 Payment issue created: #101368

Use useSortedReportActionsData instead of useSortedActions

94b9f33

melvin-bot Bot assigned sosek108 Sep 11, 2026

sosek108 marked this pull request as ready for review September 11, 2026 12:48

sosek108 requested review from a team as code owners September 11, 2026 12:48

melvin-bot Bot requested review from AndrewGable and heyjennahay and removed request for a team September 11, 2026 12:48

mountiny requested review from mountiny and thelullabyy and removed request for AndrewGable September 11, 2026 13:40

sosek108 added 2 commits September 14, 2026 14:51

Merge branch 'main' into slice/use-sorted-report-actions-data

f4b899c

Merge branch 'main' into slice/use-sorted-report-actions-data

20f5b90

thelullabyy approved these changes Sep 15, 2026

View reviewed changes

melvin-bot Bot changed the title ~~Use useSortedReportActionsData instead of useSortedActions~~ [Payment due @thelullabyy] Use useSortedReportActionsData instead of useSortedActions Sep 15, 2026

mountiny approved these changes Sep 15, 2026

View reviewed changes

mountiny merged commit d22a64c into Expensify:main Sep 15, 2026
36 of 38 checks passed

MelvinBot mentioned this pull request Sep 15, 2026

Show New message marker when a user marks their own message as unread #95217

Merged

56 of 58 tasks

OSBotify mentioned this pull request Sep 15, 2026

Deploy Checklist: New Expensify 2026-09-15 #101255

Closed

43 tasks done

sosek108 mentioned this pull request Sep 16, 2026

Route Search row previews through the shared LHN alternate text #101298

Merged

45 tasks done

melvin-bot Bot mentioned this pull request Sep 16, 2026

[Due for payment 2026-09-23] Payment issue for E/App PR#100947 #101368

Closed

Conversation

sosek108 commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sosek108 commented Sep 11, 2026

Uh oh!

melvin-bot Bot commented Sep 11, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 11, 2026

Uh oh!

thelullabyy commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 15, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

OSBotify commented Sep 15, 2026

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

OSBotify commented Sep 16, 2026

Uh oh!

MelvinBot commented Sep 16, 2026

Uh oh!

OSBotify commented Sep 16, 2026

Uh oh!

melvin-bot Bot commented Sep 16, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sosek108 commented Sep 11, 2026 •

edited

Loading

codecov Bot commented Sep 11, 2026 •

edited by github-actions Bot

Loading

thelullabyy commented Sep 15, 2026 •

edited

Loading