Repository navigation
[Payment due @linhvovan29546] fix: send domainAccountID when setting card feed transaction liability - #101046
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@rayane-d Is this PR still on hold? |
|
Yes, this is on hold on the BE PRs |
|
@linhvovan29546 - the PR is ready for review. Thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-20.at.09.43.39.movAndroid: mWeb ChromeScreen.Recording.2026-09-20.at.09.39.11.moviOS: HybridAppScreen.Recording.2026-09-20.at.09.46.55.moviOS: mWeb SafariScreen.Recording.2026-09-20.at.09.37.16.movMacOS: Chrome / SafariScreen.Recording.2026-09-20.at.09.21.43.mov |
|
NAB: This isn’t related to the |
@linhvovan29546 - I prefer to handle this in a separate PR. It is not the only action missing failure handling. |
|
🎯 @linhvovan29546, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.91-0 🚀
|
|
🤖 No help site changes are required for this PR. This is a pure bug fix. It sends What I checkedPR diff — three files, none user-facing:
Help site articles that mention this setting — both already describe the correct behavior, so neither needs an edit:
Neither article distinguishes domain feeds from workspace feeds for this setting, and it shouldn't — after this fix the behavior is the same for both, which is exactly what the docs say. I did not create a draft PR, and so did not need to verify labels against the live UI. If you'd like the articles to call out domain-owned feeds explicitly, or to note that a feed setting change posts a message in #admins only for workspace-owned feeds, say so and I'll open the draft PR. @rayane-d, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Hi @rayane-d. We need some clarification regarding the QA steps here. bandicam.2026-09-22.15-42-40-653.mp4 |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #101977 |
@IuliiaHerets The company cards feed needs to be created under the domain from OldDot, not from the workspace. |
Explanation of Change
Problem
Allow deleting transactions does not save for domain card feeds. The switch flips, the request returns 200, then the old value comes back on reload.
Root cause
setWorkspaceCompanyCardTransactionLiabilityalready had the account ID and used it for the optimistic Onyx key, but dropped it beforeAPI.write. The backend then wrote to the workspace account instead of the domain account.Solution
Send
domainAccountIDwith the request, and declare it in the parameter type.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/680218
PROPOSAL:
Tests
Bug Reproduction recording (Before the fix):
Screen.Recording.2026-09-14.at.6.50.01.PM.mov
After the fix:
Screen.Recording.2026-09-14.at.6.48.02.PM.mov
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari