Skip to content

[Payment due @linhvovan29546] fix: send domainAccountID when setting card feed transaction liability - #101046

Merged
mjasikowski merged 7 commits into
Expensify:mainfrom
rayane-d:SetFeedTransactionLiability-domainAccountID-fix
Sep 21, 2026
Merged

mjasikowski merged 7 commits into
Expensify:mainfrom
rayane-d:SetFeedTransactionLiability-domainAccountID-fix

Conversation

@rayane-d

@rayane-d rayane-d commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Problem

Allow deleting transactions does not save for domain card feeds. The switch flips, the request returns 200, then the old value comes back on reload.

Root cause

setWorkspaceCompanyCardTransactionLiability already had the account ID and used it for the optimistic Onyx key, but dropped it before API.write. The backend then wrote to the workspace account instead of the domain account.

Solution

Send domainAccountID with the request, and declare it in the parameter type.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/680218
PROPOSAL:

Tests

  1. Sign in as an admin of a workspace whose company cards come from a domain feed.
  2. Open Workspace > Company cards, select that feed, and open its settings.
  3. Check that Allow deleting transactions is on.
  4. Turn it off.
  5. Refresh the browser and the Onyx data. The toggle should still being off.
  6. Open the workspace #admins room. A domain feed posts no message about the change.
  7. Repeat steps 2 to 4 on a workspace-owned feed. It still saves, and #admins does get a message.

Bug Reproduction recording (Before the fix):

Screen.Recording.2026-09-14.at.6.50.01.PM.mov

After the fix:

Screen.Recording.2026-09-14.at.6.48.02.PM.mov
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@rayane-d

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 9cb01baf39

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@rayane-d rayane-d changed the title Fix: "Allow deleting transactions" toggle does not save for domain card feeds fix: send domainAccountID when setting card feed transaction liability Sep 16, 2026
@rayane-d rayane-d changed the title fix: send domainAccountID when setting card feed transaction liability [Hold Auth#24476 Web-E#56138] fix: send domainAccountID when setting card feed transaction liability Sep 16, 2026
@rayane-d
rayane-d marked this pull request as ready for review September 16, 2026 10:40
@rayane-d
rayane-d requested review from a team as code owners September 16, 2026 10:40
@melvin-bot
melvin-bot Bot requested review from flaviadefaria and linhvovan29546 and removed request for a team September 16, 2026 10:40
@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 16, 2026 10:40
@linhvovan29546

Copy link
Copy Markdown
Contributor

@rayane-d Is this PR still on hold?

@rayane-d

Copy link
Copy Markdown
Contributor Author

Yes, this is on hold on the BE PRs

@rayane-d rayane-d changed the title [Hold Auth#24476 Web-E#56138] fix: send domainAccountID when setting card feed transaction liability fix: send domainAccountID when setting card feed transaction liability Sep 19, 2026
@rayane-d

Copy link
Copy Markdown
Contributor Author

@linhvovan29546 - the PR is ready for review. Thanks!

@linhvovan29546

linhvovan29546 commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-09-20.at.09.43.39.mov
Android: mWeb Chrome
Screen.Recording.2026-09-20.at.09.39.11.mov
iOS: HybridApp
Screen.Recording.2026-09-20.at.09.46.55.mov
iOS: mWeb Safari
Screen.Recording.2026-09-20.at.09.37.16.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-20.at.09.21.43.mov

@linhvovan29546

Copy link
Copy Markdown
Contributor

NAB: This isn’t related to the domainAccountID fix, but I noticed that the setWorkspaceCompanyCardTransactionLiability action itself has no failure handling. If SET_COMPANY_CARD_TRANSACTION_LIABILITY fails, the optimistic toggle is never rolled back, and no error is recorded anywhere in Onyx. The UI will silently continue showing the wrong (unsaved) state. Even if failureData existed, the page doesn’t wire it up. Should we handle this in this PR or create a separate issue?

@rayane-d

Copy link
Copy Markdown
Contributor Author

NAB: This isn’t related to the domainAccountID fix, but I noticed that the setWorkspaceCompanyCardTransactionLiability action itself has no failure handling. If SET_COMPANY_CARD_TRANSACTION_LIABILITY fails, the optimistic toggle is never rolled back, and no error is recorded anywhere in Onyx. The UI will silently continue showing the wrong (unsaved) state. Even if failureData existed, the page doesn’t wire it up. Should we handle this in this PR or create a separate issue?

@linhvovan29546 - I prefer to handle this in a separate PR. It is not the only action missing failure handling. setWorkspaceCompanyCardFeedName also only sets optimisticData

@melvin-bot melvin-bot Bot changed the title fix: send domainAccountID when setting card feed transaction liability [Payment due @linhvovan29546] fix: send domainAccountID when setting card feed transaction liability Sep 21, 2026
@melvin-bot

melvin-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

🎯 @linhvovan29546, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/680218.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@mjasikowski
mjasikowski merged commit f5a886a into Expensify:main Sep 21, 2026
36 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.91-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR.

This is a pure bug fix. It sends domainAccountID with SetCompanyCardTransactionLiability so the setting writes to the domain account instead of the workspace account. It adds no setting, no UI, and no copy — it makes Allow deleting transactions persist for domain feeds, which is what the help site already documents.

What I checked

PR diff — three files, none user-facing:

Help site articles that mention this setting — both already describe the correct behavior, so neither needs an edit:

Neither article distinguishes domain feeds from workspace feeds for this setting, and it shouldn't — after this fix the behavior is the same for both, which is exactly what the docs say.

I did not create a draft PR, and so did not need to verify labels against the live UI. If you'd like the articles to call out domain-owned feeds explicitly, or to note that a feed setting change posts a message in #admins only for workspace-owned feeds, say so and I'll open the draft PR.


@rayane-d, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@rayane-d
rayane-d deleted the SetFeedTransactionLiability-domainAccountID-fix branch September 21, 2026 22:29
@IuliiaHerets

Copy link
Copy Markdown

Hi @rayane-d. We need some clarification regarding the QA steps here.
Step 6 says: Open the workspace #admins room. A domain feed posts no message about the change.
We used an admin account that has a company card, and there is a post in the #admins room, so the expected result doesn’t match what we’re seeing.
Which account should we use for testing this scenario?

bandicam.2026-09-22.15-42-40-653.mp4

cc @mjasikowski @puneetlath @flaviadefaria

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #101977

@rayane-d

Copy link
Copy Markdown
Contributor Author

Hi @rayane-d. We need some clarification regarding the QA steps here. Step 6 says: Open the workspace #admins room. A domain feed posts no message about the change. We used an admin account that has a company card, and there is a post in the #admins room, so the expected result doesn’t match what we’re seeing. Which account should we use for testing this scenario?

bandicam.2026-09-22.15-42-40-653.mp4
cc @mjasikowski @puneetlath @flaviadefaria

@IuliiaHerets The company cards feed needs to be created under the domain from OldDot, not from the workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants