Repository navigation
Conversation
Co-authored-by: nkdengineer <nkdengineer@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch because I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. If you only need to review the wording, no action is needed here. |
40 tasks done
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://c5ec0bd0.helpdot.pages.dev ⚡️ Updated articles: |
This was referenced Sep 22, 2026
Contributor
|
Handled in Handled in #101948 |
bernhardoj
pushed a commit
to bernhardoj/Expensify
that referenced
this pull request
Sep 25, 2026
…nsify/insights
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site updates for the behavior shipped in [CP prod] fix: The Violation column can be selected without the necessary filters.
That PR made the Violations column conditional: it is only listed in Display > Edit columns when the search has a
has:submitted-violationorhas:approved-violationfilter, it can't be deselected while one of those filters is applied, and it is dropped from a saved column layout when both filters are removed. The help site documented Edit columns as a free choice of columns and never explained this dependency, so members who went looking for Violations had no article telling them why it wasn't there.Docs-only change, no code touched. Three articles:
docs/articles/new-expensify/reports-and-expenses/Using-Reports-in-New-Expensify.md## How to add the Violations column in Spendsection with the steps to apply the filter, what happens to the column while the filter is applied, and what happens when the filter is removed.getHasOptionAvailabilityinsrc/libs/SearchUIUtils.ts), since that is the most likely reason a member can't find the filter at all.View ResultstoView resultsto match the UI string insrc/languages/en.ts.docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.mdapproved-violationto the documented values for thehas:operator. It was missing, and this PR makes it a first-class trigger for the Violations column alongsidesubmitted-violation.docs/articles/new-expensify/insights/View-the-Violations-by-submitter-report.mdUI labels (Spend, Display, Edit columns, Filters, Has, Submitted violation, Approved violation, View results) were verified against dev NewDot web and
src/languages/en.ts. Writing followsdocs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: no###or deeper headings, task-based##headings, exact UI labels in bold, and relative cross-links placed outside numbered steps.Fixed Issues
$ #100877
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
AI tests run by MelvinBot: none required. Per the
test-selection-matrixskill, this change touches only markdown underdocs/articles— no app code, no shell scripts, no docs routing or config, so norequired-localbundle applies.cspellcould not be run in this sandbox (the command was blocked); CI will run it.Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@nkdengineer, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.