Repository navigation
Conversation
Co-authored-by: Yusuf: Software Engineer <yusufdeveloper2903@users.noreply.github.com>
39 tasks done
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Feel free to reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Fix back button loop on Profile after copiloting into an agent (
Expensify/App#100686).That PR fixes a navigation loop that happens after using Copilot into account from the agent chat header. Reviewing it surfaced a gap in Create and Use Agents: the article documents only one of the three places you can start a Copilot session with an agent, so the exact flow that PR fixes is not described anywhere on the help site.
This PR updates
docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.mdto:## Where else you can Copilot into an agent's accountsection covering the Edit agent page and the agent chat header → Profile page entry points.Expensify/App#100686corrects.No product behavior is documented as changing — the code fix restores the expected back behavior, and the article now matches it.
UI label verification. Every label used was checked against the running app on web rather than taken from the existing article. Confirmed exact strings: Agents, Copilot, Edit, Edit agent, Chat with agent, Copilot into account, Profile, Account.
Screenshots of the verified UI
Agents list row — Copilot and Edit controls plus the chat icon:
Edit agent page — Chat with agent, Copilot into account, Delete agent:
Agent chat header → Profile page — Copilot into account:
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: bolded UI labels with no quotation marks, a task-based##heading, no new#heading, and the unified web/mobile navigation phrasing already used in the article.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Suggested check for this docs-only change:
Offline tests
This change only edits a Markdown file under
docs/articles. There is no offline-specific behavior.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
// These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@yusufdeveloper2903, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.