Repository navigation
Conversation
Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
38 of 40 tasks
This was referenced Sep 23, 2026
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Feel free to reopen if you disagree! |
truph01
pushed a commit
to truph01/App
that referenced
this pull request
Sep 28, 2026
…nsify/workspaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site docs for the behavior shipped in Deduct home-office distance from valid requests when enabled (
Expensify/App#100189).That PR made the Exclude usual commute method on a workspace's Exclude commutes setting actually deduct from distance expenses. Before it, the option existed on the settings screen but only Remove fixed distance changed what a member was reimbursed. The help site has no article on Exclude commutes at all — searching
docs/articlesfor "commut" returns only an unrelated Expensify Classic line — so there was nothing to amend.What changed
docs/articles/new-expensify/workspaces/Exclude-commutes-from-distance-expenses.md— admin setup for Exclude commutes, the addresses Exclude usual commute needs, how each method changes an expense, and what the member sees.docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md— one bullet under Distance expenses created on a Workspace, a cross-link, and one FAQ entry for a member whose expense came out shorter than the trip they entered.Where the behavior claims come from
The three home-and-office outcomes in the article match
getTransactionCommuterExclusionDataand the PR's own test steps: whole trip excluded when the trip is the commute, home-to-office excluded when the trip continues past the office, nothing excluded when the trip starts at the office and ends somewhere other than home. Manual and odometer entry are excluded persrc/libs/DistanceRequestUtils.ts:355-357; the workspace-chat-only scope comes fromisPolicyExpenseChatinuseDistanceRequestState; the "Original: …" label and "Removed … commuter miles" hint come fromgetDistanceDisplayDetailsWithCommuter.Two things for you to confirm
Exclude commutesis still behind thecommuterExclusionsbeta. I drove the live web app and the row is not on Distance rates > Settings for a non-beta account — it is gated byisBetaEnabled(CONST.BETAS.COMMUTER_EXCLUSIONS)inPolicyDistanceRatesSettingsPage. Every other label in the article was verified against the live UI orsrc/languages/en.ts. Publishing may want to wait until the beta opens up.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/642601
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Melvin ran, on the changed files only:
npm run spell-changed— 2 files checked, 0 issues../.github/scripts/createDocsRoutes.sh— "The docs routes files is up to date!", so the new article needs no routes change.This PR changes Markdown under
docs/articlesonly; no app code is touched.Offline tests
N/A — help site content only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Gonals, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.