Skip to content

Revert "Localize decimal separator" - #10129

Merged
techievivek merged 1 commit into
mainfrom
revert-9800-eVoloshchak_localizeDecimalSeparator
Jul 27, 2022
Merged

techievivek merged 1 commit into
mainfrom
revert-9800-eVoloshchak_localizeDecimalSeparator

Conversation

@sketchydroide

@sketchydroide sketchydroide commented Jul 27, 2022 •

Copy link
Copy Markdown
Contributor

CC @Santhosh-Sellavel
Reverts #9800

This PR add some issues and the C+ asked me to revert it.

Some more info here #10108 and #9497 (comment)

@sketchydroide
sketchydroide requested a review from a team as a code owner July 27, 2022 12:24
@sketchydroide sketchydroide self-assigned this Jul 27, 2022
@melvin-bot
melvin-bot Bot requested review from techievivek and removed request for a team July 27, 2022 12:24

@techievivek techievivek left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just updated the description with an additional link to the comment that asks for a revert.

@techievivek
techievivek merged commit bfbdd4e into main Jul 27, 2022
@techievivek
techievivek deleted the revert-9800-eVoloshchak_localizeDecimalSeparator branch July 27, 2022 12:48
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 1, 2022
95 tasks done
@OSBotify

OSBotify commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @techievivek in version: 1.1.87-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify

OSBotify commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat mentioned this pull request Nov 10, 2022
43 of 87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants