Skip to content

fix: drop pending domain adminship request when closing a user account - #101353

Merged
mollfpr merged 4 commits into
Expensify:mainfrom
software-mansion-labs:jakubstec/domain-domain-adminship-request-list-fix
Sep 24, 2026
Merged

mollfpr merged 4 commits into
Expensify:mainfrom
software-mansion-labs:jakubstec/domain-domain-adminship-request-list-fix

Conversation

@jakubstec

@jakubstec jakubstec commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

Explanation of Change

Fix stale pending adminship request entry in domain admin list after closing the user's account. closeUserAccount now drops the domain_adminRequesters entry along with the member, and restores it if the call fails. It only works for the flow when an admin performs an action of closing a requester's account; when they close it themselves, the row stays until the admin clears the cache.

Fixed Issues

$ #101042
PROPOSAL:

Tests

Precondition:

  • As 'X' domain member, go to Workspaces > Domains > 'X' domain name > Request admin access.
  • Log in as 'X' domain admin and perform the steps below:
  1. Go to staging.new.expensify.com
  2. Go to Workspaces > Domains.
  3. Click applause.expensifail.com
  4. Go to Domains members.
  5. Search for the member who requested admin access.
  6. Click on the member > Close account > Force close account > Close account.
  7. Go to Domain admins.
  8. Verify that the member whose account is closed will no longer appear in Requests list.
  • Verify that no errors appear in the JS console

Offline tests

  1. As a domain admin, go offline.
  2. Go to Domain members > click a member who requested admin access > Close account > Force close account > Close account.
  3. Go to Domain admins and verify the member is still in the Requests list, greyed out with a pending state.
  4. Go back online and verify the member disappears from the Requests list.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-09-16.at.17.06.15.mov

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/actions/Domain.ts 65.79% <100.00%> (+0.11%) ⬆️
src/pages/domain/Members/DomainMembersPage.tsx 0.00% <ø> (ø)
...c/pages/domain/Members/DomainMemberDetailsPage.tsx 0.00% <0.00%> (ø)
... and 22 files with indirect coverage changes

@jakubstec

Copy link
Copy Markdown
Member Author

@codex review
@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Code review — the fix works for the happy path, but the optimistic update contradicts a deliberate design decision made ~450 lines above it in the same file, and the failure rollback is incomplete.

1. Dropping the requester optimistically breaks the offline/error affordance (medium)

src/libs/actions/Domain.ts:1538-1548 removes domain_adminRequesters[targetAccountID] in optimisticData. declineDomainAdminshipRequest deliberately does not do that, and says why at Domain.ts:1092:

The requester is dropped only once the decline lands, not optimistically: while offline the entry has to survive so the row keeps rendering with its DELETE pending action, and on failure it has to survive so the row can show the error.

shouldShowPendingRow (isOffline || !isPendingDelete || hasErrors) exists precisely to support that. Concretely, offline: the Members row correctly greys out with a DELETE pending action, but the Requests row vanishes instantly with no pending state. If the request then fails, the row silently reappears with no error on it — the error goes to memberErrors on a different page.

Mirroring decline fixes both: optimistic sets adminshipRequester: {[targetAccountID]: {pendingAction: DELETE}}, successData nulls domain_adminRequesters[targetAccountID] and the pending action, failureData clears just the pending action.

2. The cleared adminshipRequester pending action is never restored (medium)

optimisticData nulls adminshipRequester: {[targetAccountID]: null} (Domain.ts:1550-1555) but failureData only restores domain_adminRequesters.

Repro: admin declines the request while offline (queued, row carries a DELETE pending action) → admin closes the account → both keys are nulled → the close fails → the row returns as a normal actionable request with live Approve/Deny buttons, while the decline is still sitting in the request queue. Either restore the pending action in failureData, or drop the optimistic null if it's only defensive.

3. Smaller notes

  • Two adjacent booleans. closeUserAccount(..., securityGroupsData, hasPendingAdminshipRequest, overrideProcessingReports = false) — swapping them silently force-closes an account with outstanding reports and skips the request cleanup. Neither TS nor a test catches it. An options object for the trailing flags would.
  • Duplicate key in failureData. There's already a ${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID} entry for the security-group restore; Domain.ts:1556-1565 adds a second one. Harmless, but foldable.
  • Hardcoded 'read' at Domain.ts:1562 is safe (domain_adminRequesters is typed Record<string, 'read' | null>) and matches approveDomainAdminshipRequest, so just flagging it as a magic value.
  • Weak negative assertion. tests/actions/DomainTest.ts:729-734 matches failureData on the exact value {[accountID]: 'read'}, so it would still pass if the code regressed to writing a different value under the same key. expect.objectContaining({value: expect.objectContaining({domain_adminRequesters: expect.anything()})}) is tighter.
  • Bulk path silently no-ops if the domain hasn't loaded. DomainMembersPage.tsx:179 passes hasPendingAdminshipRequestSelector(accountID)(domain); if domain is undefined the flag is false and the cleanup is skipped with no signal. Same pre-existing risk as securityGroupData, so low priority.

4. Test plan

Two gaps worth closing before merge:

  1. Offline is marked N/A, but this change is nothing but optimistic Onyx data — offline is exactly what's at stake. Please add: go offline → close a requester's account → check the Requests row state → come back online with a failing request → verify the row returns and an error is visible somewhere the admin will see it.
  2. Step 8 only verifies within the session. Since this is a stale-cache fix, add a hard refresh / re-open of the domain after the close to confirm the backend dropped the request too, and that the optimistic update isn't masking a row the server still has.
What I verified and what I didn't

Verified statically against 84b2735: closeUserAccount is the only DELETE_DOMAIN_MEMBER caller and both call sites were updated; hasPendingAdminshipRequestSelector pre-exists in src/selectors/Domain.ts and isn't part of this diff; accountID is declared locally in every touched test; the Requests list renders from pendingAdminRequesterAccountIDsSelector + adminshipRequester pending actions, which is what makes findings 1 and 2 reachable.

Not verified: I could not run Jest or npm run typecheck in this environment, so I did not execute the new tests.

The inline selector: hasPendingAdminshipRequestSelector(accountID) in DomainMemberDetailsPage is correct as written — per CLAUDE.md, React Compiler handles memoization and manual useCallback should not be added to new code.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84b2735808

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/Domain.ts Resolved
@jakubstec
jakubstec force-pushed the jakubstec/domain-domain-adminship-request-list-fix branch from 0e1b7bd to e91e29c Compare September 16, 2026 22:10
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: e91e29cdf6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Re-verified against e91e29cd. All six points from my last review are fixed, and the rework is cleaner than what I suggested. One item is still open: the test plan.

What changed

You adopted the declineDomainAdminshipRequest shape exactly, rather than patching the optimistic removal:

Previous finding Status
Optimistic drop broke the offline/error affordance Fixed — Domain.ts:1476 now marks adminshipRequester[targetAccountID] with a DELETE pending action, and the entry is only dropped in successData at Domain.ts:1504
Pending action never restored on failure Fixed — Domain.ts:1533 clears it in failureData
Hardcoded 'read' restore Gone — nothing is removed optimistically, so there is nothing to restore
Duplicate DOMAIN key in failureData Gone — the DOMAIN write moved to successData
Two adjacent booleans in the signature Gone — hasPendingAdminshipRequest was dropped entirely; only targetAccountID was added
Weak negative test assertion Fixed — DomainTest.ts:718-732 now matches on domain_adminRequesters: expect.anything() and checks both optimisticData and failureData

Removing the flag also removed the risk I flagged where the bulk path would silently no-op if domain hadn't loaded yet — there is no longer a call-site read to get wrong.

Verified the unconditional write is safe

Dropping the flag means every close now writes an adminshipRequester pending action, including for members who never requested adminship. I checked both consumers and it's inert:

  • DomainUtils.ts:96 iterates pendingAdminRequesterAccountIDsSelector(domain) — keys of domain_adminRequesters — so an orphan pending action can't inflate the pending-requests indicator.
  • DomainAdminsPage.tsx:137-144 builds the Requests list from the same source, so no phantom row appears.

One thing still open

The test plan hasn't been updated, and Offline is still N/A. That mattered before; now it matters more, because offline persistence is the fix. The whole point of deferring the drop to successData is that the row survives offline rendering its DELETE pending action — untested, that's the behavior most likely to silently regress. Please add:

  1. Go offline → close a requester's account → confirm the Requests row is still visible and greyed with a pending state (not gone).
  2. Come back online with a failing request → confirm the row returns to a normal actionable state and the error is visible on the Members row.
  3. After a successful close, hard-refresh and re-open the domain → confirm the request is still gone (proves the backend dropped it too, not just the optimistic update).

Minor, non-blocking

  • Residue on failure. For a member with no adminship request, a failed close leaves adminshipRequester: {[accountID]: {pendingAction: null}} in DOMAIN_PENDING_ACTIONS indefinitely — clearDomainMemberError only clears memberErrors and member. Nothing reads it without a matching domain_adminRequesters key, so it's inert, just accumulating. Nulling the whole entry instead of the pendingAction in failureData would avoid it.
  • Unchanged edge case. If a decline is queued offline and a close is then issued and fails, failureData clears the DELETE marker the decline set, so the row goes actionable with the decline still in the queue. Narrow enough that I wouldn't hold the PR for it — noting it only because I raised it last round.
What I verified and what I didn't

Verified statically at e91e29cd: the full closeUserAccount body; both call sites updated and closeUserAccount is still the only DELETE_DOMAIN_MEMBER caller; shouldShowPendingRow (isOffline || !isPendingDelete || hasErrors) supports the deferred-drop pattern the rework relies on; both adminshipRequester consumers key off domain_adminRequesters, which is what makes the unconditional write safe; the tightened negative assertion does not accidentally match the securityGroupsData restore entry in failureData (that entry has no domain_adminRequesters key, so expect.anything() doesn't match).

Not verified: Jest and npm run typecheck are not runnable in this environment, so I did not execute the updated tests.

@jakubstec

Copy link
Copy Markdown
Member Author

@MelvinBot could you assign @war-in to this PR?

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Done — added war-in as an assignee. Current assignees: war-in, jakubstec.

Note this only sets the assignee. If you also want war-in as a reviewer so the PR shows up in their review queue, say the word and I'll request the review too.

Comment on lines 1479 to 1487
@@ -1478,12 +1487,21 @@ function closeUserAccount(domainAccountID: number, domain: string, targetEmail:
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also clear adminshipRequesterErrors here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
value: {
member: {[targetEmail]: {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}},
adminshipRequester: {[targetAccountID]: {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it's also written for members who never requested adminship. is this fine?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's harmless. I made sure to clear the entire object on success & failure

@war-in

war-in commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot update offline tests with

1. As a domain admin, go offline.
2. Go to Domain members > click a member who requested admin access > Close account > Force close account > Close account.
3. Go to Domain admins and verify the member is still in the Requests list, greyed out with a pending state.
4. Go back online and verify the member disappears from the Requests list.

@war-in

war-in commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark PR as redy for review

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Updated the Offline tests section of the PR description with your steps (it previously said N/A).

The steps match what the code does:

I could not verify this in a browser on this run — browser control was unavailable, so the above is from static analysis only.

@MelvinBot
MelvinBot marked this pull request as ready for review September 23, 2026 16:27
@MelvinBot
MelvinBot requested review from a team as code owners September 23, 2026 16:27
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and trjExpensify and removed request for a team September 23, 2026 16:27
@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Done — this PR is now marked ready for review (no longer a draft).

All checks on the latest commit were passing before the switch; the usual ready-for-review checks (review, checklist) are re-running now.

Comment on lines +1479 to 1485
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
value: {
// eslint-disable-next-line @typescript-eslint/naming-convention
domain_adminRequesters: {[targetAccountID]: null},
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to re-add the targetAccountID to domain_adminRequesters in failureData?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we dont 😄 optimistic data doesn't touch domain_adminRequesters, so we don't have to restore anything on failure. While closing the account, we mark the request with a delete-pending action, so it appears crossed out

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming!

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@war-in

war-in commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach we're ready for your review 😄

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Will check after an hour!

@ZhenjaHorbach

ZhenjaHorbach commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-09-24.at.12.47.16.mov
Android: mWeb Chrome
Screen.Recording.2026-09-24.at.12.47.16.mov
iOS: HybridApp
Screen.Recording.2026-09-24.at.12.43.15.mov
iOS: mWeb Safari
Screen.Recording.2026-09-24.at.12.36.42.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-24.at.12.32.15.mov

@melvin-bot
melvin-bot Bot requested review from mollfpr and mountiny September 24, 2026 10:51
@mollfpr
mollfpr merged commit 78f0588 into Expensify:main Sep 24, 2026
41 of 49 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are needed for this PR, so I did not create a docs PR.

This PR fixes a bug. When a Domain Admin closed the account of a member who had asked for admin access, that member's request stayed in the Domain Admins Requests list. It doesn't add a feature, setting, or button, and it doesn't change any documented steps.

Articles checked

view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants