Repository navigation
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| useEffect(() => { | ||
| getWorkspaceMembers(); | ||
| }, [getWorkspaceMembers]); |
There was a problem hiding this comment.
This was added in #61169 to trigger the API once when the page opens, but it's unintentionally fired every time the employeeList changes.
| return; | ||
| } | ||
| getWorkspaceMembers(); | ||
| }, [isOffline, prevIsOffline, getWorkspaceMembers]); |
There was a problem hiding this comment.
Moved this to useNetwork onReconnect
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@bernhardoj Conflicts |
|
@shubham1206agra fixed |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-09-21.at.6.40.20.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.91-0 🚀
|
|
🤖 No help site changes required — I did not create a docs PR. This PR is an internal refactor with no user-facing change. It threads a Nothing in What I checkedEvery changed call site is a signature update passing
The PR's own QA steps are all "verify the API sends @bernhardoj, since no help site update is needed, there is no linked help site PR to review or mark |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66391
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Prerequisite:
clientMemberEmails)clientMemberEmails)PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4