Repository navigation
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This reverts commit efd392b.
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@shawnborton I accidentally pushed my local debug changes 😅 could you rerun the build? it should work fine this time |
|
Can do! |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Only minor thing: I wouldn't expect the table to scroll horizontally unless my mouse was over the horizontal scroll area... it feels weird that I can scroll horizontally when I am in the area for the search input/etc. Curious what @Expensify/design thinks. CleanShot.2026-09-21.at.12.37.41.mp4 |
Big agree. That feels really odd. |
|
@shawnborton @dannymcclain that was the hard one, but we got this 🎉 |
|
Nice! On it 🚀 |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
@Krishna2323 review addressed 🫡 |
|
@war-in TS check failing |
|
@Krishna2323 fixed! |
|
@JS00001 PR's all yours! |
|
on it |
| } | ||
|
|
||
| /* Hold a table's columns still while the pointer is on the filter bar pinned inside their scroller */ | ||
| [data-table-column-scroller='true']:has([data-table-page-header='true']:hover) { |
There was a problem hiding this comment.
why does this have to be a global change? That seems like it'd cause issues
There was a problem hiding this comment.
We could go another way and use React state to track hover (instead of css) but it'd cause the list to re-render each time the header is hovered. I decided to use css here because it's only enabled when dataSet has tableColumnScroller set to true and should be harmless for the rest of the app
I'm happy to adjust it if you think rerender (or any other solution) would be better
|
@JS00001 review addressed! |
|
Do we merge it @JS00001? 👀 |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.96-0 🚀
|
|
No help site update needed. This PR fixes table layout so the search input, filters, and column header stay in place while columns scroll sideways, and it corrects screen reader row numbering. It adds no new feature, renames nothing, and makes no sentence in |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.99-0 🚀
|
|
No help site update needed. This PR is a layout fix that keeps the table search and filters in place while the columns scroll sideways, so no sentence in an existing article becomes incorrect. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀
Bundle Size Analysis (Sentry): |
|
@war-in the test steps here led to a false bug report (#102613), so I think they need updating. Test 1 asks testers to narrow to 900–1100px while keeping the wide layout, but below 1025px we switch to the card layout, which has no columns or horizontal scrollbar. Step 2 then asks them to narrow until a scrollbar appears, so they end up in a layout where it can't exist. That's exactly what happened in the Applause test. The Members table also needs a Control workspace with long Custom Field 1 and 2 values to overflow, but that's missing from the prerequisites. Test 3, step 5 has a similar issue: below 1025px, there's no Could you update the steps with the correct width range and workspace setup? Also, Test 1 jumps from step 8 to step 10. |
|
@Krishna2323 updated 🫡 |

Explanation of Change
Tables with an in-list filter bar now scroll their columns in the FlashList scroller instead of an ancestor one, so the page header and filter bar stay pinned while the columns move. The column header moves from FlashList's sticky-row overlay into the list header. Adds a
COLUMN_HEADER_PLACEMENTenum and fixes inconsistentaria-rowcount/aria-rowindex.Fixed Issues
$ #101331
PROPOSAL:
Tests
Tests
Prerequisites (Tests 1 and 3)
role="table"). Keep the browser window wider than 1024px for all steps belowTest 1 — the search input and filters stay fixed while the columns scroll
Test 2 — tables whose columns fit are unchanged
Test 3 — screen reader row numbering stays consistent
role="table"aria-rowcountequals the number of data rows + 1 for the header rowaria-rowindex="2", the second3, and so on (index 1 is reserved for the header row)role="table"is still present, andaria-rowcountandaria-rowindexstill have the same values as in steps 3 and 4. The counts must not shift when the header changes placementOffline tests
N/A — this PR only changes table layout and accessibility attributes. No API calls, data fetching or Onyx operations are involved.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-18.at.14.34.20.mov