Skip to content

Fix 0% tax rate flash when deselecting a category on an expense - #101572

Merged
JS00001 merged 6 commits into
Expensify:mainfrom
Krishna2323:krishna2323/issue/100591
Oct 6, 2026
Merged

JS00001 merged 6 commits into
Expensify:mainfrom
Krishna2323:krishna2323/issue/100591

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #100591
PROPOSAL:

Tests

  1. Create a workspace and enable Taxes and Rules (upgrade to Control if prompted).
  2. Add Ten Percent (10%) under Taxes.
  3. Under Categories → Advertising, set Default tax rate to Ten Percent • 10%.
  4. In workspace chat, create a $25.00 manual expense with category Advertising.
  5. Open the expense and verify Tax is Ten Percent (10%) and Tax amount is $2.27.
  6. Open Category and deselect Advertising.
  7. Verify the tax stays at Ten Percent (10%) / $2.27 without flashing to 0% or Tax exempt.
  8. Set Five Percent (5%) as the default tax rate for Benefits, then change the expense category to Benefits. Verify the tax updates to Five Percent (5%) without flashing.
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/TransactionUtils/getUpdatedTransaction.ts 96.89% <100.00%> (+0.01%) ⬆️
... and 348 files with indirect coverage changes

@Krishna2323
Krishna2323 marked this pull request as ready for review September 18, 2026 12:25
@Krishna2323
Krishna2323 requested review from a team as code owners September 18, 2026 12:25
@melvin-bot
melvin-bot Bot requested review from garrettmknight and situchan and removed request for a team and garrettmknight September 18, 2026 12:25
@melvin-bot

melvin-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Krishna2323

Copy link
Copy Markdown
Contributor Author

@situchan friendly bump

@situchan

situchan commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

before:

Screen.Recording.2026-10-02.at.7.49.01.PM.mov

after:

Screen.Recording.2026-10-02.at.7.51.32.PM.mov

@Krishna2323

Copy link
Copy Markdown
Contributor Author

@situchan bump

@@ -403,7 +403,9 @@ function getUpdatedTransaction({
if (Object.hasOwn(transactionChanges, 'category') && typeof transactionChanges.category === 'string') {
updatedTransaction.category = transactionChanges.category;
const {categoryTaxCode, categoryTaxAmount, categoryTaxValue} = getCategoryTaxDetails(transactionChanges.category, transaction, policy, getCurrencyDecimals);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code optimization:
If !transactionChanges.category, no need to run getCategoryTaxDetails.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved getCategoryTaxDetails inside the guard so it doesn't run when we skip.

@MelvinBot

MelvinBot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Regression review

I found one likely regression, in split flows. The single-expense edit flow from Expense-Deselecting category shows 0% tax rate briefly and changes to previous rate looks safe.

Split drafts now save the old category's tax. The split flows use setDraftSplitTransaction, which calls getUpdatedTransaction. These drafts get no server response afterwards. The tax in the draft is the tax that gets sent to the server:

Here is how to reproduce it in a split:

  1. Use an expense with category Advertising and its 10% default tax.
  2. Deselect the category on a split item, then save.

Before this PR, the split saved the workspace default tax. Now it keeps 10%. The PR comment says the server response "immediately overwrites" the tax, but that isn't true for these flows.

Fix: Scope the guard to the server-backed edit path, or confirm which behavior product wants for splits. Then add a unit test either way.

Other findings and what I checked
  • Create flow is now inconsistent. setMoneyRequestCategory has no empty-category guard. Clearing a category while you create an expense still resets tax to the default. When you edit an expense, tax now stays.
  • Wasted call. getUpdatedTransaction.ts:405 still runs getCategoryTaxDetails for '' and then discards the result. Move the empty-category check before that call.
  • No test added. The PR checklist says unit tests were added, but the diff changes only one file. No existing test asserts that tax resets when a category is cleared, so CI shouldn't break.
  • Not affected or improved:
    • UpdateMoneyRequestCategory sends only category, so tax changes only the optimistic data there.
    • Bulk edit never sends an empty category.
    • Merge and split update send explicit tax values, and the PR stops the default from overwriting them optimistically.
    • Report totals and the expense change message don't use this tax.
  • Not verified: No backend code confirms that the server keeps tax when the category is cleared. The linked issue's flash-then-revert behavior is the only evidence.
  • Web testing didn't run. The test browser session failed to sign in and showed a blank page, so these findings come from code review only.

view run · no recording available

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Krishna2323 requested a review from situchan October 5, 2026 19:51
@situchan

situchan commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot review

// On a server backed edit, clearing the category leaves the stored tax rate untouched, so predicting a
// change here only writes a rate that the response immediately overwrites. Split drafts have no such
// response and send whatever tax the draft holds, so they keep recalculating.
if (transactionChanges.category || isSplitTransaction) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is split case really regression from this PR?

@MelvinBot

Copy link
Copy Markdown
Contributor

Review

No blocking issues. The latest commit fixes the split problem from my earlier review.

Was split really a regression? Yes, in the first commit (73b53ee), but not anymore:

  • Editing a split's category calls setDraftSplitTransaction, which calls getUpdatedTransaction.
  • In 73b53ee, clearing the category skipped the tax update, so the split draft kept the old category's tax.
  • No server response corrects a draft. SplitExpenseItems.ts:833-835 saves the draft's tax as is. Before this PR, the draft reset to the workspace default tax.

The latest commit adds || isSplitTransaction to the guard at getUpdatedTransaction.ts:408. Split.ts:1346 passes that flag, so split drafts reset as before. The new tests cover both paths.

Other checks
  • Saving an edited split: SplitTransactionUpdate.ts:912 also passes isSplitTransaction: true. The draft already holds the default tax, so the second update writes the same value. There is no conflict.
  • Unneeded getCategoryTaxDetails call: fixed. It now runs only inside the guard.
  • Other callers: UpdateMoneyRequest.ts and BulkEdit.ts don't set the flag, so they keep the stored tax, as intended.
  • Nit: The PR body's "Explanation of Change" and "PROPOSAL" sections are empty.
  • Not run: I didn't run the unit tests or test on web. These findings come from reading the code only.

view run

@melvin-bot
melvin-bot Bot requested a review from JS00001 October 6, 2026 07:35
@JS00001
JS00001 merged commit c1c1da2 into Expensify:main Oct 6, 2026
37 of 41 checks passed
@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Oct 6, 2026
100 tasks done
@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.4-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR fixes a brief optimistic flash of a 0% tax rate when you clear an expense's category. The saved tax rate doesn't change, so no existing article sentence becomes incorrect.


view run

@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants