Skip to content

[no QA] Docs updates for E/A#100687 broken card feed reconnect behavior - #101608

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsBrokenCardFeedReconnect
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsBrokenCardFeedReconnect

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for the behavior changed in #100687 (Broken card feed connection RHP spins forever). That PR changed three things a Workspace Admin actually sees, and none of them were documented:

  1. The broken-connection message differs by feed type. Only direct (OAuth/Plaid) feeds render the log into your bank link now. Commercial and spreadsheet feeds with a feed-level error render Your card connection is broken. with no link, because they cannot be reconnected from inside Expensify.
  2. A failed reconnect now shows an error state instead of spinning. If the import fails after the bank login, the panel stays open and shows Couldn't load this feed with a Got it button that returns to Company cards.
  3. An expired feed hit during card assignment no longer resumes the assignment. After the bank login the panel closes and the admin has to assign the card again.

Changes in this PR:

docs/articles/new-expensify/connect-credit-cards/Fix-a-Broken-Company-Card-Feed-Connection.md

  • Named the exact link (log into your bank) in the reconnect steps and noted that the panel stays open through the login and closes on its own.
  • Added ## What to do when a card feed has no log into your bank link covering commercial and spreadsheet feeds.
  • Added an Error: Couldn't load this feed entry to the troubleshooting list, with the Got it recovery path.
  • Added a matching FAQ entry and updated keywords / internalScope.

docs/articles/new-expensify/connect-credit-cards/Assign-Company-Cards.md

  • Added an FAQ entry explaining that an expired feed hit at the Assign card confirmation step opens the bank login first, and the card must be assigned again afterward.

UI labels were verified against the live web build rather than taken from the source strings: Workspaces tab, Company cards row, More features > Spend > Company cards toggle. The common.buttonConfirm key renders as Got it, not "Confirm", so the article uses Got it.

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: one # title plus # FAQ, all sections ## starting with an action verb or question word, bolded UI labels in sentence case, relative cross-links placed outside numbered steps. npm run spell-changed passes with 0 issues.

Fixed Issues

$ #100465
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes work.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@jmusial, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Jan Musiał <jmusial@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 18, 2026 18:22
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 18, 2026
@stephanieelliott stephanieelliott changed the title Docs updates for E/A#100687 broken card feed reconnect behavior [no QA] Docs updates for E/A#100687 broken card feed reconnect behavior Sep 22, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Dupe of #101481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants