Skip to content

[No QA] Docs updates for E/A#100082 Submit workspace upgrade plan per feature - #101627

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-93096-submit-upgrade-plan
Closed

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-93096-submit-upgrade-plan

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to fix: tag Control-tier upgrade features with requiredPlan for Submit workspaces.

That PR made the upgrade target deterministic for free Submit workspaces: turning on a feature that is only available on Control now upgrades the workspace straight to Control instead of Collect, so the feature stays unlocked and the upgrade page doesn't reappear when you turn it off and back on. Collect-tier features (for example Travel and Company cards) still upgrade to Collect.

Two help site articles were out of date:

  1. docs/articles/new-expensify/getting-started/Submit-Workspace.md

    • The upgrade section listed only two upgrade paths (switching Plan type in Overview, and an approver clicking Approve). It never mentioned the third and most common path: turning on a premium feature and upgrading when prompted.
    • Added a section that states which plan a Submit workspace lands on per feature, and that the workspace keeps that plan if you later turn the feature off — the exact behavior PR fix: tag Control-tier upgrade features with requiredPlan for Submit workspaces #100082 fixed.
  2. docs/articles/new-expensify/workspaces/Enable-Report-Fields.md

    • The steps pointed at More features > Report Fields. The Report fields toggle now lives on the workspace Reports page, so the documented path no longer exists.
    • Corrected the navigation in all three sections and added what happens on the upgrade prompt, including the direct-to-Control upgrade for Submit workspaces.

UI labels were verified against src/languages/en.ts on main (the source of the rendered strings) rather than paraphrased: Reports, Report fields, Prevent members from changing custom report titles, GL codes, GL & Payroll codes, Tax codes, Multi-level tags, Multiple approval levels, Prevent self-approvals, Per diem, Rules, Upgrade.

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: one # title per article, task-based ## headings starting with an action verb or question word, bolded sentence-case UI labels, relative cross-links with descriptive anchor text, and no links inside numbered steps.

Known follow-up, deliberately left out of scope: Enable-Report-Fields.md still uses three # headings and the prose casing "Report Fields" instead of the UI's "Report fields". Fixing those means restructuring the whole article, which is unrelated to this behavior change.

Fixed Issues

$ #93096
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable. This PR only changes help site markdown under docs/articles; no app code runs.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not applicable — help site markdown only.

Android: mWeb Chrome

Not applicable — help site markdown only.

iOS: Native

Not applicable — help site markdown only.

iOS: mWeb Safari

Not applicable — help site markdown only.

MacOS: Chrome / Safari

Not applicable — help site markdown only.


@neerajbachani, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Neeraj Bachani  <neerajbachani@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 18, 2026 20:27
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 18, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#100082 Submit workspace upgrade plan per feature [No QA] Docs updates for E/A#100082 Submit workspace upgrade plan per feature Sep 18, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://bd5a17c0.helpdot.pages.dev ⚡️

Updated articles:

@neerajbachani

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

paulnjs pushed a commit to paulnjs/paulnjs-expensify-app that referenced this pull request Sep 25, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Consolidating to #101958 to avoid conflicts

truph01 pushed a commit to truph01/App that referenced this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants