Repository navigation
Conversation
Co-authored-by: Neeraj Bachani <neerajbachani@users.noreply.github.com>
40 tasks done
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://bd5a17c0.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
|
@MelvinBot mark this PR as ready for review |
This was referenced Sep 23, 2026
paulnjs
pushed a commit
to paulnjs/paulnjs-expensify-app
that referenced
this pull request
Sep 25, 2026
…nsify/getting-started
Contributor
|
Consolidating to #101958 to avoid conflicts |
truph01
pushed a commit
to truph01/App
that referenced
this pull request
Sep 28, 2026
…nsify/workspaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to fix: tag Control-tier upgrade features with requiredPlan for Submit workspaces.
That PR made the upgrade target deterministic for free Submit workspaces: turning on a feature that is only available on Control now upgrades the workspace straight to Control instead of Collect, so the feature stays unlocked and the upgrade page doesn't reappear when you turn it off and back on. Collect-tier features (for example Travel and Company cards) still upgrade to Collect.
Two help site articles were out of date:
docs/articles/new-expensify/getting-started/Submit-Workspace.mddocs/articles/new-expensify/workspaces/Enable-Report-Fields.mdUI labels were verified against
src/languages/en.tsonmain(the source of the rendered strings) rather than paraphrased: Reports, Report fields, Prevent members from changing custom report titles, GL codes, GL & Payroll codes, Tax codes, Multi-level tags, Multiple approval levels, Prevent self-approvals, Per diem, Rules, Upgrade.Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one#title per article, task-based##headings starting with an action verb or question word, bolded sentence-case UI labels, relative cross-links with descriptive anchor text, and no links inside numbered steps.Known follow-up, deliberately left out of scope:
Enable-Report-Fields.mdstill uses three#headings and the prose casing "Report Fields" instead of the UI's "Report fields". Fixing those means restructuring the whole article, which is unrelated to this behavior change.Fixed Issues
$ #93096
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable. This PR only changes help site markdown under
docs/articles; no app code runs.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not applicable — help site markdown only.
Android: mWeb Chrome
Not applicable — help site markdown only.
iOS: Native
Not applicable — help site markdown only.
iOS: mWeb Safari
Not applicable — help site markdown only.
MacOS: Chrome / Safari
Not applicable — help site markdown only.
@neerajbachani, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.