Repository navigation
Conversation
Co-authored-by: Jan Musiał <jmusial@users.noreply.github.com>
38 tasks done
Contributor
|
@trjExpensify can you help review this docs change, and either make the changes that are needed or instruct Melvin on the changes you recommend? |
Contributor
Contributor
|
Seeing the parent PR was reverted, we can close this -- a new docs update will be created once the replacement PR hits staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to Align workspace selector logic (
Expensify/App#101430), which changed which workspace a new report is created on:The help site only said "Reports are opened on your default workspace", which did not explain the Preferred Workspace override or when members are asked to Choose a workspace for this report.
Changes:
docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md— spelled out the workspace a new report opens on, added the Preferred Workspace override, added the case where the member is asked to choose, and added two FAQ entries (which workspace a report opens on, and how to set a default workspace so the list stops appearing). Added matching keywords.docs/articles/new-expensify/domains/Create-and-Manage-Domain-Groups.md— noted in What Preferred Workspace does that the preferred workspace beats the member's own default workspace and that members are not asked to choose, plus an FAQ entry covering the same for Create report.UI labels were verified against
src/languages/en.ts(Create report, "Choose a workspace for this report.", Set as default workspace, Preferred Workspace) rather than in a browser — browser verification was unavailable in this run.Not covered here: the edge case where the preferred workspace owner is past due beyond the grace period and the restricted-action page opens instead. Say the word if you want that documented too.
Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@jmusial, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.