[sosek108]

Explanation of Change

Follow-up to #100033, answering this review question: #100033 (comment)

Adds tests/unit/useMoneyRequestReportScrollTest.tsx — 24 cases covering the scroll logic useMoneyRequestReportScroll owns, which so far was only exercised by manual QA steps:

• Bottom-offset math — the contentHeight - layoutHeight - scrollY measurement, the ACTION_VISIBLE_THRESHOLD flag the caller uses, and the offset shared through ActionListContext (which is what decides whether incoming messages auto-scroll).
• Deferred mark-as-read — scrollToLatestMessages must not mark the report read; that happens only once a scroll event reports the list actually landed, and is cancelled if the user drags away first.
• Stick-to-bottom — re-pinning while deferred content settles, its expiry, and the cancel-on-drag path.
• Own-comment autoscroll — own comment jumps, someone else's comment does not, a non-comment action does not, plus the pending-action path where the action is not in the rendered data yet when the event arrives.
• AgentZero thinking indicator — reveals the footer indicator once per run rather than once per label change, and not at all while the user is reading higher up.
• Teardown — pending timeouts cleared and the subscribeToNewActionEvent subscription released.

No product code changes. The mocks assert that the hook asks the list to scroll to the last item; whether the list visually lands at the bottom without a blank region is FlashList behavior that stays manual QA — it is exactly why the hook uses scrollToIndex over scrollToEnd, and the wiring for that choice is covered by the autoscroll-wiring case.

Fixed Issues

$ #99919
PROPOSAL:

Tests

1. Run npx jest tests/unit/useMoneyRequestReportScrollTest.tsx
2. Verify all 24 cases pass

Offline tests

Not applicable — test-only change, no product code ships.

QA Steps

No QA — test-only change with no runtime effect.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline — N/A, no product code changed
  • I tested this PR with a High Traffic account against staging or production — N/A, no product code changed
• I included screenshots or videos for tests on all platforms — N/A, no UI change
• I ran the tests on all platforms & verified they passed on: — N/A, no product code changed; exercised by the unit test job
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers — the mocking shape follows useReportActionsScrollTest.tsx, useMoneyRequestReportPaginationTest.ts and useReportUnreadMessageScrollTrackingTest.ts
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes — no product code changed
• If a new CSS style is added I verified that: — N/A
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function
• If new assets were added or existing ones were modified, I verified that: — N/A
  • The assets are optimized and compressed
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I verified no unexpected markdown behavior — N/A, no product code changed
• If the PR modifies a generic component, I verified other usages still work — N/A, no product code changed
• If the PR modifies a component related to existing Storybook stories, I tested all stories — N/A
• If the PR modifies a page reachable by direct deeplink, I verified it from a logged in and logged out account — N/A, no product code changed
• If the PR modifies the UI or form input styles: — N/A, no UI change
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Not applicable — no UI change.

[melvin-bot]

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.93-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.93-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android