Repository navigation
Conversation
|
|
3793106 to
6211715
Compare
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@collectioneur Merge main please |
# Conflicts: # package-lock.json # package.json
|
@shubham1206agra merged ✅ |
|
@shubham1206agra lets try to get through these before ooo |
|
App is crashing on iOS 27 |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-09-25.at.6.11.49.PM.movScreen.Recording.2026-09-25.at.2.33.32.PM.movScreen.Recording.2026-09-25.at.6.38.12.PM.mov |
This comment was marked as outdated.
This comment was marked as outdated.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.95-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|
Explanation of Change
Bumps
react-native-screensfrom 4.25.0 to 4.28.0. This is one of the library upgrades that has to land before the RN 0.88 / Expo SDK 58 bump (#101427). The library declaresreact-native: *as its peer dependency, so it lands on the RN 0.86 / Expo SDK 57 stack we run today.What changes in this PR:
package.json/package-lock.json: 4.25.0 → 4.28.0.patches/react-native-screens/is deleted. Our only patch (001+fix-removal-listener-use-after-free, Sentry APP-9Y9, [Due for payment 2026-08-28] [$250] [Sentry: APP-9Y9] Android MountingCoordinator pullTransaction crash #93842) is the upstream fix(Android): use-after-free of RNSScreenRemovalListener registered as mounting override delegate software-mansion/react-native-screens#4413 (b3badd0), which shipped in 4.28.0. The patch reverse-applies cleanly on the published 4.28.0 package, so the fix is included as is.ios/Podfile.lock(standalone NewDot) and the HybridAppPodfile.lockin the companion Mobile-Expensify PR: pod version and spec checksum.Why 4.28.0 and not 4.27.0 (the version mentioned in the issue):
~4.28.0(bundledNativeModules.jsonon thesdk-58branch), so bumping to 4.27.0 would mean touching this library again in the RN 0.88 PR.Relevant library changes between 4.25.0 and 4.28.0: bug fixes only, no API changes for our usages. The ones that touch code paths we use are on Android:
transparentModalscreens on top of opaque screens, so this is covered by tests 2 and 3.RNSScreenRemovalListeneruse-after-free on cold launch (Block chronos@, receipts@ and concierge@ from Split Bill and Request Money #4413, our removed patch).SwipeRefreshLayouttransitions and the example app.Where we use the library: every native stack in the app goes through
@react-navigation/native-stack(PlatformStackNavigation), including the root stack, the RHP and the attachment / MFA modals. We also use it for freezing inactive screens (FreezeWrapper, and the composer under the attachment modal) and for swipe-back gestures (hideKeyboardOnSwipe).Fixed Issues
$ #101445
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14139
Tests
+FAB, select Create expense, and go back through the flow. Verify the modal opens and closes cleanly.Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-09-23.at.17.20.48.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-09-23.at.17.09.03.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-23.at.17.27.56.mov