Skip to content

Docs updates for E/A#101741 document annual subscription expiring soon reminder - #102161

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsSubscriptionExpiringSoonAlert
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsSubscriptionExpiringSoonAlert

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for Alert subscription owners when their annual subscription is about to expire with auto-renew off, which added a new user-facing warning that the help site did not document.

That PR introduced a reminder shown to a Workspace owner when all three are true: the subscription is Annual, Auto-renew is off, and the end date is one month or less away. It appears in three places — a Time sensitive item on Home, a green dot next to Subscription in the navigation tabs, and a banner at the top of Account > Subscription.

Nothing on the help site mentioned any of this. Manage-Annual-Subscription-Settings.md told owners what disabling Auto-renew does but not that Expensify warns them before the term ends, and Expensify-Home-Overview.md listed every trigger for the Time-sensitive section except this new one. An owner who saw the green dot or the banner had no article to land on.

Two articles changed:

  1. Manage-Annual-Subscription-Settings.md — new ## How Expensify reminds you before your Annual subscription ends section after the existing "How to disable Auto-renew" section, describing the exact trigger conditions and all three surfaces. Plus three FAQ entries written as the questions owners will actually search: why the green dot appears, what the Home message means, and whether the reminder persists after the end date. Keywords and internalScope updated to match.

  2. Expensify-Home-Overview.md — added the new trigger to the Time-sensitive bullet list, plus one cross-link to the article above. Keywords updated.

The docs deliberately frame this as a pre-expiry reminder only. shouldShowSubscriptionExpiringSoonUI compares the end date to now, so it never renders retroactively after the subscription lapses — the "Will I still be reminded after my Annual subscription ends?" FAQ reflects that.

How the UI copy was verified

All UI strings in these articles (Time sensitive, Turn on auto-renew to keep your current pricing, Subscription ends, Your subscription ends, Manage, Auto-renew, Subscription settings) were taken from the merged src/languages/en.ts strings in the source PR rather than from a live session.

I attempted live verification on web first and could not complete it: the reminder requires an Annual subscription with Auto-renew off, the test account owns no paid workspace (so Subscription does not even appear under Account), and the Onyx.merge console workaround from the source PR's test steps is outside the web tester's automation surface. Please sanity-check the on-screen wording against a real account when you review.

Checks run

  • npm run spell-changed — 0 issues
  • ./.github/scripts/createDocsRoutes.sh — routes up to date

Fixed Issues

$ #101724
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable — this PR only changes help site markdown under docs/articles.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@ahmedGaber93, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 24, 2026 13:03
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 24, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants