Repository navigation
Conversation
Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
40 tasks done
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree! |
38 of 40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Alert subscription owners when their annual subscription is about to expire with auto-renew off, which added a new user-facing warning that the help site did not document.
That PR introduced a reminder shown to a Workspace owner when all three are true: the subscription is Annual, Auto-renew is off, and the end date is one month or less away. It appears in three places — a Time sensitive item on Home, a green dot next to Subscription in the navigation tabs, and a banner at the top of Account > Subscription.
Nothing on the help site mentioned any of this.
Manage-Annual-Subscription-Settings.mdtold owners what disabling Auto-renew does but not that Expensify warns them before the term ends, andExpensify-Home-Overview.mdlisted every trigger for the Time-sensitive section except this new one. An owner who saw the green dot or the banner had no article to land on.Two articles changed:
Manage-Annual-Subscription-Settings.md— new## How Expensify reminds you before your Annual subscription endssection after the existing "How to disable Auto-renew" section, describing the exact trigger conditions and all three surfaces. Plus three FAQ entries written as the questions owners will actually search: why the green dot appears, what the Home message means, and whether the reminder persists after the end date. Keywords andinternalScopeupdated to match.Expensify-Home-Overview.md— added the new trigger to the Time-sensitive bullet list, plus one cross-link to the article above. Keywords updated.The docs deliberately frame this as a pre-expiry reminder only.
shouldShowSubscriptionExpiringSoonUIcompares the end date to now, so it never renders retroactively after the subscription lapses — the "Will I still be reminded after my Annual subscription ends?" FAQ reflects that.How the UI copy was verified
All UI strings in these articles (Time sensitive, Turn on auto-renew to keep your current pricing, Subscription ends, Your subscription ends, Manage, Auto-renew, Subscription settings) were taken from the merged
src/languages/en.tsstrings in the source PR rather than from a live session.I attempted live verification on web first and could not complete it: the reminder requires an Annual subscription with Auto-renew off, the test account owns no paid workspace (so Subscription does not even appear under Account), and the
Onyx.mergeconsole workaround from the source PR's test steps is outside the web tester's automation surface. Please sanity-check the on-screen wording against a real account when you review.Checks run
npm run spell-changed— 0 issues./.github/scripts/createDocsRoutes.sh— routes up to dateFixed Issues
$ #101724
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — this PR only changes help site markdown under
docs/articles.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ahmedGaber93, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.