Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
s77rt
marked this pull request as ready for review
September 28, 2026 11:23
melvin-bot
Bot
requested review from
JmillsExpensify and
truph01
and removed request for
a team
September 28, 2026 11:23
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
cc @truph01 it'd be great if you could start your review |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index ac809631..30444274 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -8892,6 +8892,35 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
description: 'Wählen Sie Ihr Verrechnungskonto aus, und wir erstellen die Zahlung in Campfire.',
},
travelInvoicingPayableAccount: {label: 'Verbindlichkeitskonto für Reiseabrechnungen'},
+ exportToMultipleAccounts: 'Export in mehrere Konten konfigurieren',
+ cardProgramAccount: {
+ label: 'Kartenprogramm-Konto',
+ description: 'Überschreiben Sie das Arbeitsbereichskonto für diese Kartenprogramme.',
+ descriptionLevel2: 'Überschreiben Sie das Workspace-Konto für dieses Kartenprogramm.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Alle Programme verwenden das Standardkonto';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} Programm mit benutzerdefiniertem Konto`;
+ }
+ return `${customAccountsCount} Programme mit benutzerdefinierten Konten`;
+ },
+ },
+ cardAccount: {
+ label: 'Konto pro Karte',
+ description: 'Programm-Konto für einzelne Karten überschreiben.',
+ descriptionLevel2: 'Programm-Konto für diese Karten überschreiben.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Alle Karten verwenden Programmkonten';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} Karte mit benutzerdefiniertem Konto`;
+ }
+ return `${customAccountsCount} Karten mit benutzerdefinierten Konten`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Dynamics 365 Business Central-Einrichtung',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 1b2040bc..849b5c02 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -9058,6 +9058,35 @@ ${reportName}`,
description: 'Επιλέξτε τον λογαριασμό διακανονισμού σας και θα δημιουργήσουμε την πληρωμή στο Campfire.',
},
travelInvoicingPayableAccount: {label: 'Λογαριασμός πληρωτέων για τιμολόγηση ταξιδιών'},
+ exportToMultipleAccounts: 'Ρύθμιση εξαγωγής σε πολλούς λογαριασμούς',
+ cardProgramAccount: {
+ label: 'Λογαριασμός προγράμματος κάρτας',
+ description: 'Παρακάμψτε τον λογαριασμό χώρου εργασίας για αυτά τα προγράμματα καρτών.',
+ descriptionLevel2: 'Παράκαμψη του λογαριασμού χώρου εργασίας για αυτό το πρόγραμμα κάρτας.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Όλα τα προγράμματα χρησιμοποιούν τον προεπιλεγμένο λογαριασμό';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} πρόγραμμα με προσαρμοσμένο λογαριασμό`;
+ }
+ return `${customAccountsCount} προγράμματα με προσαρμοσμένους λογαριασμούς`;
+ },
+ },
+ cardAccount: {
+ label: 'Λογαριασμός ανά κάρτα',
+ description: 'Παρακάμψτε τον λογαριασμό προγράμματος για μεμονωμένες κάρτες.',
+ descriptionLevel2: 'Παράκαμψη του λογαριασμού προγράμματος για αυτές τις κάρτες.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Όλες οι κάρτες χρησιμοποιούν λογαριασμούς προγράμματος';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} κάρτα με προσαρμοσμένο λογαριασμό`;
+ }
+ return `${customAccountsCount} κάρτες με προσαρμοσμένους λογαριασμούς`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Ρύθμιση Dynamics 365 Business Central',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 33d1eb17..503476bd 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -8717,6 +8717,35 @@ ${reportName}`,
syncTravelInvoicingSettlements: 'Sincroniza las liquidaciones de facturación de viajes',
travelInvoicingSettlementAccount: {label: 'Cuenta de liquidación de facturación de viajes', description: 'Elige tu cuenta de liquidación y crearemos el pago en Campfire.'},
travelInvoicingPayableAccount: {label: 'Cuenta a pagar de facturación de viajes'},
+ exportToMultipleAccounts: 'Configura la exportación a varias cuentas',
+ cardProgramAccount: {
+ label: 'Cuenta del programa de tarjetas',
+ description: 'Sobrescribe la cuenta del espacio de trabajo para estos programas de tarjetas.',
+ descriptionLevel2: 'Anular la cuenta del espacio de trabajo para este programa de tarjetas.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Todos los programas usan la cuenta predeterminada';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} programa con cuenta personalizada`;
+ }
+ return `${customAccountsCount} programas con cuentas personalizadas`;
+ },
+ },
+ cardAccount: {
+ label: 'Cuenta por tarjeta',
+ description: 'Anula la cuenta del programa para tarjetas individuales.',
+ descriptionLevel2: 'Sobrescribe la cuenta del programa para estas tarjetas.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Todas las tarjetas usan cuentas del programa';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} tarjeta con cuenta personalizada`;
+ }
+ return `${customAccountsCount} tarjetas con cuentas personalizadas`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Configuración de Dynamics 365 Business Central',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 191662c9..8a860f84 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -8914,6 +8914,35 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
description: 'Choisissez votre compte de règlement et nous créerons le paiement dans Campfire.',
},
travelInvoicingPayableAccount: {label: 'Compte fournisseur pour la facturation de voyage'},
+ exportToMultipleAccounts: 'Configurer l’exportation vers plusieurs comptes',
+ cardProgramAccount: {
+ label: 'Compte du programme de carte',
+ description: 'Remplacer le compte de l’espace de travail pour ces programmes de cartes.',
+ descriptionLevel2: 'Remplacer le compte de l’espace de travail pour ce programme de carte.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Tous les programmes utilisent le compte par défaut';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} programme avec compte personnalisé`;
+ }
+ return `${customAccountsCount} programmes avec comptes personnalisés`;
+ },
+ },
+ cardAccount: {
+ label: 'Compte par carte',
+ description: 'Remplacez le compte de programme pour des cartes individuelles.',
+ descriptionLevel2: 'Remplacer le compte de programme pour ces cartes.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Toutes les cartes utilisent des comptes de programme';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} carte avec un compte personnalisé`;
+ }
+ return `${customAccountsCount} cartes avec comptes personnalisés`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Configuration de Dynamics 365 Business Central',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index f9c5d5ad..874ee0e6 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -8837,6 +8837,35 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
syncTravelInvoicingSettlements: 'Sincronizza le liquidazioni di fatturazione viaggi',
travelInvoicingSettlementAccount: {label: 'Conto di regolamento fatturazione viaggi', description: 'Scegli il tuo conto di regolamento e creeremo il pagamento in Campfire.'},
travelInvoicingPayableAccount: {label: 'Conto debiti per fatturazione viaggi'},
+ exportToMultipleAccounts: 'Configura l’esportazione su più conti',
+ cardProgramAccount: {
+ label: 'Conto del programma carta',
+ description: 'Ignora il conto spazio di lavoro per questi programmi di carta.',
+ descriptionLevel2: 'Ignora il conto dello spazio di lavoro per questo programma di carte.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Tutti i programmi usano il conto predefinito';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} programma con conto personalizzato`;
+ }
+ return `${customAccountsCount} programmi con conti personalizzati`;
+ },
+ },
+ cardAccount: {
+ label: 'Conto per carta',
+ description: 'Sostituisci il conto del programma per le singole carte.',
+ descriptionLevel2: 'Sostituisci il conto del programma per queste carte.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Tutte le carte usano conti di programma';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} carta con conto personalizzato`;
+ }
+ return `${customAccountsCount} carte con conti personalizzati`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Configurazione Dynamics 365 Business Central',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 8c92e75b..0c0b9ab9 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -8715,6 +8715,35 @@ ${reportName}`,
syncTravelInvoicingSettlements: '出張請求の精算を同期',
travelInvoicingSettlementAccount: {label: '出張請求精算口座', description: '精算に使う口座を選択してください。選択された口座で、Campfire に支払いを作成します。'},
travelInvoicingPayableAccount: {label: '旅行請求買掛金勘定'},
+ exportToMultipleAccounts: '複数の勘定科目へのエクスポートを設定する',
+ cardProgramAccount: {
+ label: 'カードプログラム口座',
+ description: 'これらのカードプログラムのワークスペースアカウントを上書きします。',
+ descriptionLevel2: 'このカードプログラムのワークスペース口座を上書きします。',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'すべてのプログラムはデフォルトアカウントを使用します';
+ }
+ if (customAccountsCount === 1) {
+ return `カスタム勘定科目を使用するプログラム：${customAccountsCount} 件`;
+ }
+ return `${customAccountsCount} 件のプログラム（カスタムアカウントあり）`;
+ },
+ },
+ cardAccount: {
+ label: 'カード単位の口座',
+ description: '個々のカードに対してプログラム口座を上書きします。',
+ descriptionLevel2: 'これらのカードのプログラム口座を上書きします。',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'すべてのカードはプログラムアカウントを使用します';
+ }
+ if (customAccountsCount === 1) {
+ return `カスタム口座付きカード ${customAccountsCount} 枚`;
+ }
+ return `カスタム口座のあるカードが ${customAccountsCount} 枚`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Dynamics 365 Business Central のセットアップ',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 2eb4a8f4..fccdc561 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -8812,6 +8812,35 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
syncTravelInvoicingSettlements: 'Reisfacturering-afrekeningen synchroniseren',
travelInvoicingSettlementAccount: {label: 'Reisfacturatie-vereffeningsrekening', description: 'Kies je afrekenrekening en we maken de betaling aan in Campfire.'},
travelInvoicingPayableAccount: {label: 'Te betalen rekening voor reisinvoicing'},
+ exportToMultipleAccounts: 'Export naar meerdere rekeningen instellen',
+ cardProgramAccount: {
+ label: 'Kaartprogramma-account',
+ description: 'Overschrijf de werkruimteaccount voor deze kaartprogramma’s.',
+ descriptionLevel2: 'Overschrijf de workspace-account voor dit kaartprogramma.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Alle programma’s gebruiken de standaardrekening';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} programma met aangepaste rekening`;
+ }
+ return `${customAccountsCount} programma’s met aangepaste rekeningen`;
+ },
+ },
+ cardAccount: {
+ label: 'Account per kaart',
+ description: 'Overschrijf de programmarekening voor individuele kaarten.',
+ descriptionLevel2: 'Overschrijf de programmarekening voor deze kaarten.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Alle kaarten gebruiken programmarekeningen';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} kaart met aangepast account`;
+ }
+ return `${customAccountsCount} kaarten met aangepaste rekeningen`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Dynamics 365 Business Central-configuratie',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 678a05ed..bb4189f7 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -8827,6 +8827,35 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
syncTravelInvoicingSettlements: 'Synchronizuj rozliczenia Travel Invoicing',
travelInvoicingSettlementAccount: {label: 'Konto rozliczeniowe fakturowania podróży', description: 'Wybierz swoje konto rozliczeniowe, a my utworzymy płatność w Campfire.'},
travelInvoicingPayableAccount: {label: 'Konto zobowiązań z tytułu faktur za podróże'},
+ exportToMultipleAccounts: 'Skonfiguruj eksport do wielu kont',
+ cardProgramAccount: {
+ label: 'Konto programu kartowego',
+ description: 'Zastąp konto przestrzeni roboczej dla tych programów kart.',
+ descriptionLevel2: 'Zastąp konto przestrzeni roboczej dla tego programu kart.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Wszystkie programy używają domyślnego konta';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} program z niestandardowym kontem`;
+ }
+ return `${customAccountsCount} programy z niestandardowymi kontami`;
+ },
+ },
+ cardAccount: {
+ label: 'Konto przypisane do karty',
+ description: 'Zastąp konto programu dla poszczególnych kart.',
+ descriptionLevel2: 'Zastąp konto programu dla tych kart.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Wszystkie karty korzystają z kont programu';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} karta z niestandardowym kontem`;
+ }
+ return `${customAccountsCount} karty z niestandardowymi kontami`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Konfiguracja Dynamics 365 Business Central',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 2afcf6a9..e2bd0d47 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -8818,6 +8818,35 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
description: 'Escolha sua conta de liquidação e nós vamos criar o pagamento no Campfire.',
},
travelInvoicingPayableAccount: {label: 'Conta a pagar de faturamento de viagens'},
+ exportToMultipleAccounts: 'Configurar exportação para várias contas',
+ cardProgramAccount: {
+ label: 'Conta do programa de cartão',
+ description: 'Substituir a conta do workspace para estes programas de cartão.',
+ descriptionLevel2: 'Substituir a conta do workspace para este programa de cartão.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Todos os programas usam a conta padrão';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} programa com conta personalizada`;
+ }
+ return `${customAccountsCount} programas com contas personalizadas`;
+ },
+ },
+ cardAccount: {
+ label: 'Conta por cartão',
+ description: 'Substitua a conta do programa para cartões individuais.',
+ descriptionLevel2: 'Substituir a conta do programa para estes cartões.',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return 'Todos os cartões usam contas do programa';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} cartão com conta personalizada`;
+ }
+ return `${customAccountsCount} cartões com contas personalizadas`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Configuração do Dynamics 365 Business Central',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 6f7e16e0..e3ae04db 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -8480,6 +8480,35 @@ ${reportName}`,
syncTravelInvoicingSettlements: '同步差旅开票结算',
travelInvoicingSettlementAccount: {label: '差旅开票结算账户', description: '选择您的结算账户，我们会在 Campfire 中创建这笔付款。'},
travelInvoicingPayableAccount: {label: '差旅开票应付账户'},
+ exportToMultipleAccounts: '配置导出到多个账户',
+ cardProgramAccount: {
+ label: '卡计划账户',
+ description: '为这些卡计划覆盖工作区账户。',
+ descriptionLevel2: '覆盖此卡计划的工作区账户。',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return '所有方案使用默认账户';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} 个自定义账户的项目`;
+ }
+ return `${customAccountsCount} 个具有自定义科目的项目`;
+ },
+ },
+ cardAccount: {
+ label: '按卡计费账户',
+ description: '为单张卡片覆盖默认项目账户。',
+ descriptionLevel2: '为这些卡片覆盖默认项目账户。',
+ countInfo: (customAccountsCount: number) => {
+ if (!customAccountsCount) {
+ return '所有卡都使用项目账户';
+ }
+ if (customAccountsCount === 1) {
+ return `${customAccountsCount} 张带有自定义账户的卡`;
+ }
+ return `${customAccountsCount} 张带有自定义账户的卡`;
+ },
+ },
},
businessCentral: {
businessCentralSetup: 'Dynamics 365 Business Central 设置',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
JmillsExpensify
previously approved these changes
Sep 29, 2026
JmillsExpensify
left a comment
JmillsExpensify
left a comment
Contributor
There was a problem hiding this comment.
Part of an existing product initiative. LGTM though we should add screenshots/videos.
truph01
reviewed
Sep 29, 2026
Contributor
|
I have a workspace that was previously connected to @s77rt I encountered the following error when calling
Could you help check whether this is expected? |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-30.at.00.26.52.mov |
Contributor
cc @ShridharGoel too |
Contributor
|
The error is expected behavior since all integrations guard against another integration owning settlement reconciliation. But there seems to be an issue with Rillet - it never releases ownership on disconnect (no Rillet::disconnect, unlike DualEntry/Campfire), so its NVPs outlive the connection and block later integrations. Workaround for testing: have the workspace's expensifyCard_useContinuousReconciliation NVP set to false, then retry. Proper fix would be adding a release-on-disconnect for Rillet, will add it. |
Contributor
|
^ cc @truph01 regarding the settlements error
Thank you @ShridharGoel |
truph01
approved these changes
Sep 30, 2026
Contributor
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
70 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.5.0-0 🚀
|
4 of 7 tasks
|
Deploy Blocker #102721 was identified to be related to this PR. |
|
This PR failing because of the issue #102721 |
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Add Campfire multiple card account export settings
Fixed Issues
$ #100184
PROPOSAL:
Tests
Configure exporting to multiple accountstoggleCard program accountandPer-card accountCard program accountfor each programPer-card accountfor each cardDualEntry per-card account export)Screen.Recording.2026-09-30.at.4.55.56.PM.mov
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari