Skip to content

[No QA] Docs updates for E/A#101656 Add Norway, Sweden, and South Africa government rates - #102461

Merged
stephanieelliott merged 2 commits into
mainfrom
claude-docsGovernmentRatesNoSeZa
Sep 30, 2026
Merged

stephanieelliott merged 2 commits into
mainfrom
claude-docsGovernmentRatesNoSeZa

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Add NOK, SEK, ZAR to auto-update government distance rates made the Auto-update government rates toggle available for workspaces with a NOK, SEK, or ZAR default currency. The Set Distance Rates article still listed only USD, CAD, GBP, and AUD, so admins in Norway, Sweden, and South Africa would read that the feature isn't available to them.

This PR updates docs/articles/new-expensify/workspaces/Set-distance-rates.md:

  • Adds NOK, SEK, and ZAR to the supported default currencies in the Who can set distance rates section and the Why isn't Auto-update government rates turned on for my workspace? FAQ.
  • Adds NOK for Norway, SEK for Sweden, and ZAR for South Africa to the currency-to-government mapping.
  • Adds Norway, Sweden, and South Africa to the countries that publish rates in Kilometers, matching GOVERNMENT_RATE_COUNTRY_TO_UNIT in src/CONST/index.ts.
  • Adds country-specific mileage rate search phrases to the keywords metadata.

Country names match the English UI copy in governmentRateCountries (src/languages/en.ts), and the toggle label matches autoUpdateGovernmentRate (Auto-update government rates).

@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #101656
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…docs

Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 28, 2026 21:41
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 28, 2026
title: Set Distance Rates
description: Set and manage rates for distance reimbursement in your Expensify workspace.
keywords: [New Expensify, distance rates, mileage reimbursement, enable distance rates, workspace settings, bulk edit rates, auto-update government rates, IRS standard rate, mileage rates, distance bands, auto-generated rate, lightning bolt icon, default currency change, miles kilometers unit]
keywords: [New Expensify, distance rates, mileage reimbursement, enable distance rates, workspace settings, bulk edit rates, auto-update government rates, IRS standard rate, Norway mileage rate, Sweden mileage rate, South Africa mileage rate, mileage rates, distance bands, auto-generated rate, lightning bolt icon, default currency change, miles kilometers unit]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot undo this, "mileage rates" is already there

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I reverted the keywords line to match main, so it no longer includes the country-specific mileage rate phrases. Commit: 69abfba


view run

@ShridharGoel

Copy link
Copy Markdown
Contributor

@MelvinBot mark it as ready

Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I couldn't mark this PR as ready for review. This run doesn't have permission to change a PR's draft status, so the PR is still a draft.

To mark it ready yourself, select Ready for review at the bottom of the PR. Before you do, fill out the Tests and QA Steps sections in the PR description. They still contain the // TODO placeholders.


view run

@github-actions github-actions Bot changed the title Docs updates for E/A#101656 Add Norway, Sweden, and South Africa government rates [No QA] Docs updates for E/A#101656 Add Norway, Sweden, and South Africa government rates Sep 29, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://bf77c46a.helpdot.pages.dev ⚡️

Updated articles:

@ShridharGoel

Copy link
Copy Markdown
Contributor

@MelvinBot mark it as ready

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I couldn't mark this PR as ready for review. My environment blocked the gh pr ready command in this run, so the PR is still a draft.

ShridharGoel, you're an assignee, so you can click Ready for review at the bottom of the PR page.


view run

@ShridharGoel

Copy link
Copy Markdown
Contributor

@stephanieelliott Assigning this to you since I don't have the access to mark it as ready for review.

@stephanieelliott
stephanieelliott marked this pull request as ready for review September 30, 2026 18:37
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @johncschuster

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T18:55:24.910932Z 69abfba Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from johncschuster and removed request for a team September 30, 2026 18:37
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott
stephanieelliott merged commit ef752bc into main Sep 30, 2026
19 of 20 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsGovernmentRatesNoSeZa branch September 30, 2026 18:38
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR is a small, well-scoped content update to Set-distance-rates.md. It extends the list of currencies supported for the Auto-update government rates feature by adding NOK (Norway), SEK (Sweden), and ZAR (South Africa), and updates the corresponding unit mapping (Kilometers for the three new countries). The changes are applied consistently across all four affected locations: the eligibility note, the currency-to-country explanation, the default-currency-change behavior, and the related FAQ answer.

Scores Summary

  • Readability: 9/10 - Additions integrate cleanly into existing sentences; lists remain parallel and easy to scan.
  • AI Readiness: 9/10 - Feature names (Auto-update government rates, Unit, Miles, Kilometers) are used exactly and consistently; the new currency/country/unit facts are explicit and unambiguous. Metadata (including internalScope) is untouched and still valid.
  • Style Compliance: 9/10 - UI-exact terminology and bold formatting are preserved. The added enumerations follow the existing pattern precisely.

Key Findings

  • Consistency is the strongest aspect: all four references to the supported-currency set were updated in lockstep, so no stale list remains.
  • Unit mapping is handled correctly - the new countries are grouped under Kilometers, matching the existing structure.
  • Minor: the longer inline currency enumerations (USD, CAD, GBP, AUD, NOK, SEK, or ZAR) are approaching the length where a short bulleted currency/country/unit reference could improve scannability, but this is optional and not required by governance.

Recommendations

  • No blocking issues. The diff is accurate, consistent, and compliant.
  • Optional future enhancement: consider a small reference table mapping currency to country and unit if the supported list continues to grow.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Set-distance-rates.md - Approved; additive currency-support update, fully consistent and compliant.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants