Repository navigation
[No QA] Docs updates for E/A#101656 Add Norway, Sweden, and South Africa government rates - #102461
Conversation
…docs Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
| title: Set Distance Rates | ||
| description: Set and manage rates for distance reimbursement in your Expensify workspace. | ||
| keywords: [New Expensify, distance rates, mileage reimbursement, enable distance rates, workspace settings, bulk edit rates, auto-update government rates, IRS standard rate, mileage rates, distance bands, auto-generated rate, lightning bolt icon, default currency change, miles kilometers unit] | ||
| keywords: [New Expensify, distance rates, mileage reimbursement, enable distance rates, workspace settings, bulk edit rates, auto-update government rates, IRS standard rate, Norway mileage rate, Sweden mileage rate, South Africa mileage rate, mileage rates, distance bands, auto-generated rate, lightning bolt icon, default currency change, miles kilometers unit] |
There was a problem hiding this comment.
@MelvinBot undo this, "mileage rates" is already there
|
@MelvinBot mark it as ready |
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
|
I couldn't mark this PR as ready for review. This run doesn't have permission to change a PR's draft status, so the PR is still a draft. To mark it ready yourself, select Ready for review at the bottom of the PR. Before you do, fill out the Tests and QA Steps sections in the PR description. They still contain the |
|
A preview of your ExpensifyHelp changes have been deployed to https://bf77c46a.helpdot.pages.dev ⚡️ Updated articles: |
|
@MelvinBot mark it as ready |
|
I couldn't mark this PR as ready for review. My environment blocked the
|
|
@stephanieelliott Assigning this to you since I don't have the access to mark it as ready for review. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Add NOK, SEK, ZAR to auto-update government distance rates made the Auto-update government rates toggle available for workspaces with a NOK, SEK, or ZAR default currency. The Set Distance Rates article still listed only USD, CAD, GBP, and AUD, so admins in Norway, Sweden, and South Africa would read that the feature isn't available to them.
This PR updates
docs/articles/new-expensify/workspaces/Set-distance-rates.md:GOVERNMENT_RATE_COUNTRY_TO_UNITinsrc/CONST/index.ts.keywordsmetadata.Country names match the English UI copy in
governmentRateCountries(src/languages/en.ts), and the toggle label matchesautoUpdateGovernmentRate(Auto-update government rates).@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #101656
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari