Repository navigation
[No QA] Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle - #102463
Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
|
@MelvinBot mark is as ready |
|
I couldn't mark this PR as ready for review. This run doesn't have permission to run Since you're the assignee, you can do it yourself. Click Ready for review at the bottom of the PR page. |
|
@MelvinBot mark is as ready |
|
🤖 I couldn't mark this PR as ready for review. The You can mark it ready yourself with the Ready for review button at the bottom of the PR. |
|
@stephanieelliott Assigning this to you since I don't have the access to mark it as ready for review. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR updates docs/articles/new-expensify/connections/netsuite/Configure-Netsuite.md to document the new Split exports by posting period toggle in NetSuite export settings. The changes are scoped and well-targeted: a new export settings list item, a capitalization fix for Export to next open period, three new FAQ entries covering the toggle behavior and its lock dependency, and two new keywords. The additions are accurate, clearly written, and consistent with the surrounding article. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdd9769843
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Export Foreign Currency Amount** – Enable to export original currency values | ||
| - **Export to Next Open Period** – Enable to skip closed periods and use the next available NetSuite period | ||
| - **Export to next open period** – Enable to skip closed periods and use the next available NetSuite period | ||
| - **Split exports by posting period** – Enable to export non-reimbursable expenses as one NetSuite transaction per calendar month, each dated in its own month. **Export to next open period** must be on first. While this toggle is on, **Export to next open period** stays locked on. |
There was a problem hiding this comment.
Remove documentation for the reverted toggle
This advertises a setting customers cannot access: PR #102588 (revert e7c887bb562, merged as 248682b6ddf) removed #101934 before this documentation commit, and the current src/pages/workspace/accounting/netsuite/export/NetSuiteExportConfigurationPage.tsx ends the toggle list at lines 202–212 immediately after Export to next open period. Publishing this would direct workspace admins to a nonexistent control and make the three added FAQs stale, so these additions should be held until the feature is restored.
Useful? React with 👍 / 👎.
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
#101934 added a Split exports by posting period toggle to Accounting > NetSuite > Export. It is coupled with Export to next open period: split cannot be turned on until Export to next open period is on, and Export to next open period is locked on while split is on. Customers need to know what the toggle does and why one of the two toggles may appear locked.
This updates
docs/articles/new-expensify/connections/netsuite/Configure-Netsuite.md:Labels were checked against
src/languages/en.tsonmain. The live UI check could not run because the test session could not sign in, and the test account has no NetSuite connection.@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #101934
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari