Skip to content

[No QA] Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle - #102463

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-netsuiteSplitExportsByPostingPeriodDocs
Sep 30, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-netsuiteSplitExportsByPostingPeriodDocs

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#101934 added a Split exports by posting period toggle to Accounting > NetSuite > Export. It is coupled with Export to next open period: split cannot be turned on until Export to next open period is on, and Export to next open period is locked on while split is on. Customers need to know what the toggle does and why one of the two toggles may appear locked.

This updates docs/articles/new-expensify/connections/netsuite/Configure-Netsuite.md:

  • Adds Split exports by posting period to the export settings list, with its dependency on Export to next open period.
  • Corrects the capitalization of Export to next open period to match the UI.
  • Adds three FAQs: how the split works, why Export to next open period can't be turned off, and why Split exports by posting period can't be turned on.
  • Adds both toggle names to the article keywords.

Labels were checked against src/languages/en.ts on main. The live UI check could not run because the test session could not sign in, and the test account has no NetSuite connection.

@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #101934
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 28, 2026 21:42
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 28, 2026
@ShridharGoel

Copy link
Copy Markdown
Contributor

@MelvinBot mark is as ready

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I couldn't mark this PR as ready for review. This run doesn't have permission to run gh pr ready.

Since you're the assignee, you can do it yourself. Click Ready for review at the bottom of the PR page.


view run

@ShridharGoel

Copy link
Copy Markdown
Contributor

@MelvinBot mark is as ready

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I couldn't mark this PR as ready for review. The gh pr ready command is blocked by my permissions in this run.

You can mark it ready yourself with the Ready for review button at the bottom of the PR.


view run

@ShridharGoel

Copy link
Copy Markdown
Contributor

@stephanieelliott Assigning this to you since I don't have the access to mark it as ready for review.

@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @kadiealexander

@melvin-bot
melvin-bot Bot requested review from kadiealexander and removed request for a team September 30, 2026 18:38
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T18:56:23.309687Z bdd9769 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates docs/articles/new-expensify/connections/netsuite/Configure-Netsuite.md to document the new Split exports by posting period toggle in NetSuite export settings. The changes are scoped and well-targeted: a new export settings list item, a capitalization fix for Export to next open period, three new FAQ entries covering the toggle behavior and its lock dependency, and two new keywords. The additions are accurate, clearly written, and consistent with the surrounding article.

Scores Summary

  • Readability: 9/10 - Clear, concise sentences. The dependency between the two toggles is explained plainly and repeated where helpful without becoming redundant.
  • AI Readiness: 8/10 - New FAQ headings are question-based and feature-specific with full UI names, and the new keywords reflect real search intent. Scored below full marks only because the added list item folds a hard dependency (Export to next open period must be on first, stays locked on) into a bullet, where an explicit cross-reference to the new FAQ would improve retrieval.
  • Style Compliance: 9/10 - UI labels are bolded and match the product exactly; the sentence-case correction of Export to next open period aligns with the naming conventions. FAQ headings sit correctly under the existing FAQ heading and use level-two headings. Minor: curly apostrophes in the word cannot match the existing article style, so not a regression.

Key Findings

  • Strong positive: the capitalization correction of Export to next open period brings the label into compliance with the exact-UI-text rule in HELPSITE_NAMING_CONVENTIONS.md.
  • Strong positive: the three new FAQ headings all begin with a question word (How/Why), are feature-specific, and use full UI labels, fully aligned with the task-based heading rules.
  • Strong positive: keywords were expanded with both exact toggle names, improving semantic retrieval.
  • Minor: the new export-settings bullet carries two sentences of dependency/lock logic. This is accurate but dense for a settings list; the detail is well-covered by the new FAQs, so a brief pointer would tighten it.
  • Context (not a regression, pre-existing): the article uses level-one headings for major sections (e.g. Step 1: Configure Import Settings) and lacks internalScope in frontmatter. These are outside this PR diff and are not scored here.

Recommendations

  • Consider trimming the new bullet second sentence and letting the new FAQ on why the toggle cannot be turned on carry the lock explanation.
  • Optional: standardize on straight apostrophes if the article is ever normalized, but do not block on it since it matches existing style.

Files Reviewed

  • docs/articles/new-expensify/connections/netsuite/Configure-Netsuite.md - Approved. Accurate, compliant, well-scoped additions documenting the new toggle and its dependency.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit 10b83ef into main Sep 30, 2026
19 of 21 checks passed
@stephanieelliott
stephanieelliott deleted the claude-netsuiteSplitExportsByPostingPeriodDocs branch September 30, 2026 18:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bdd9769843

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- **Export Foreign Currency Amount** – Enable to export original currency values
- **Export to Next Open Period** – Enable to skip closed periods and use the next available NetSuite period
- **Export to next open period** – Enable to skip closed periods and use the next available NetSuite period
- **Split exports by posting period** – Enable to export non-reimbursable expenses as one NetSuite transaction per calendar month, each dated in its own month. **Export to next open period** must be on first. While this toggle is on, **Export to next open period** stays locked on.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove documentation for the reverted toggle

This advertises a setting customers cannot access: PR #102588 (revert e7c887bb562, merged as 248682b6ddf) removed #101934 before this documentation commit, and the current src/pages/workspace/accounting/netsuite/export/NetSuiteExportConfigurationPage.tsx ends the toggle list at lines 202–212 immediately after Export to next open period. Publishing this would direct workspace admins to a nonexistent control and make the three added FAQs stale, so these additions should be held until the feature is restored.

Useful? React with 👍 / 👎.

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle [No QA] Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants