Use the default circle shape for the onboarding accounting radio buttons by MelvinBot · Pull Request #102477 · Expensify/App

MelvinBot · 2026-09-28T22:41:19Z

Explanation of Change

Update the accounting software options and switch to a tile layout passed containerBorderRadius={variables.componentBorderRadiusSmall} to the RadioButton on each accounting tile. SelectionButton shows radio vs. checkbox only through the border radius, so the single-select radios looked like square checkboxes. That breaks the single-select vs. multi-select convention from Consistent checkboxes and radio buttons UI.

This PR removes the override so the tiles use the default circular radio shape. Behavior and accessibility role (radio) are unchanged.

Automated checks run by MelvinBot: npm run lint-changed, npm run typecheck, React Compiler compliance check on the changed file, and tests/ui/OnboardingAccountingAndInterestedFeatures.tsx (10/10 passed). A web browser check on the dev build confirmed round radio indicators and single selection:

Fixed Issues

$ #102469
PROPOSAL: #102469 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Co-authored-by: Marco Chávez <marcochavezf@users.noreply.github.com>

MelvinBot · 2026-09-28T22:48:26Z

🤖 Android test steps verification results: ❌ fail

I couldn't run the test steps on Android. The test account had already finished onboarding, so the app opened on Home. The "Do you use any accounting software?" step only appears for accounts that haven't finished onboarding. No step was checked, so this result says nothing about the fix itself.

Step	Status
The onboarding purpose screen appears and "Manage my team's expenses" can be selected. The app opened on Home ("Good evening, Tester.") instead of the onboarding purpose screen. The CI session setup had already completed onboarding for this account.	❌
The "Do you use any accounting software?" step is reached and shows the accounting tiles. Not reached. Once onboarding is complete, the app sends any onboarding route back to Home.	❌
Each accounting tile shows a round (circular) radio indicator, not a square checkbox. Not reached. The accounting tiles never appeared.	❌
Selecting one tile (for example, QuickBooks Online) shows a round selected indicator. Not reached.	❌
Selecting a different tile (for example, Xero) selects it and deselects the previous one. Not reached.	❌

To test this on Android, rerun with a fresh account that hasn't finished onboarding. The PR's Tests section is still empty, so I used the steps to reproduce from the linked issue.

view run · view recording

MelvinBot · 2026-09-28T22:57:17Z

🤖 Web test steps verification results: ⚠️ partial

The onboarding purpose step passed, but the test never reached the "Do you use any accounting software?" step. On the "What features are you interested in?" step, the tester clicked the Accounting option, which is already selected by default, and turned it off. Onboarding then finished without showing the accounting step. This was a test-run mistake, not an App bug, so the round radio indicators are still unverified.

Step	Status
The onboarding purpose screen appears and "Manage my team's expenses" can be selected. "What do you want to do today?" showed a "Manage my team's expenses" option. Selecting it moved on to "How many employees do you have?".	✅
The "Do you use any accounting software?" step is reached and shows the accounting tiles. Not reached. The tester turned off the preselected Accounting option on "What features are you interested in?". With Accounting off, onboarding skips the accounting step and goes to Home.	❌
Each accounting tile shows a round (circular) radio indicator, not a square checkbox. Not reached. The accounting tiles never appeared.	❌
Selecting one tile (for example, QuickBooks Online) shows a round selected indicator on that tile. Not reached.	❌
Selecting a different tile (for example, Xero) selects it and deselects the previous one. Not reached.	❌
No errors appear in the JS console during the flow. Not confirmed. The web test tool can't read the console. No error banners appeared on screen.	❌

To finish this check, rerun it with a fresh account and leave the Accounting option selected. The PR's Tests section is still empty, so I used the steps to reproduce from the linked issue.

view run · view recording

melvin-bot · 2026-09-29T03:13:03Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-09-29T03:13:45Z

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

mkhutornyi · 2026-09-29T03:15:14Z

I don't think this PR is needed.
Checkbox style was intentional by design

Mock in OP:

cc: @Expensify/design

dubielzyk-expensify · 2026-09-29T03:18:48Z

Isn't this mostly a question about whether you can select multiple or not? If multiple, then use square checkbox, if single option, then use round radio. I believe you can only select one though so I think this is fine!? @dylanexpensify to confirm.

mkhutornyi · 2026-09-29T03:21:58Z

We can only select one.
Btw any reason for using checkbox in mock design? Just you assumed multi selectable?

dubielzyk-expensify · 2026-09-29T03:57:22Z

Btw any reason for using checkbox in mock design? Just you assumed multi selectable?

I think it was just a mock bug that got carried over and we didn't notice. If you can only select one then using the radio buttons is correct 👍

mkhutornyi · 2026-09-29T03:59:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-09-29.at.4.58.59.AM.mov

dylanexpensify · 2026-09-29T16:00:03Z

Isn't this mostly a question about whether you can select multiple or not? If multiple, then use square checkbox, if single option, then use round radio. I believe you can only select one though so I think this is fine!? @dylanexpensify to confirm.

Ah yes, only one to select!

trjExpensify

LGTM. CC: @Expensify/design

dannymcclain · 2026-09-29T21:35:36Z

Looking good to me too 👍

dubielzyk-expensify · 2026-09-29T23:51:36Z

Same. Send it!

github-actions · 2026-09-30T07:22:58Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-09-30T07:27:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102477.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e0bb2f3-a23d96e-a39e20c0a6b08cb98079fc94c7a97f8b6cc7971c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e0bb2f3-a23d96e-1162bfa1840fcde5f93a170aa52fa1fba0c6c017/index.html

Web 🕸️
https://102477.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-01T00:03:19Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-01T00:07:24Z

No help site update is needed. This PR only changes the onboarding accounting selector from a square shape to a round radio button, and no help article describes that shape.

view run

kavimuru · 2026-10-01T00:27:22Z

@mkhutornyi any QA steps to be rested?

mkhutornyi · 2026-10-01T02:33:41Z

@mkhutornyi any QA steps to be rested?

Use the test steps in the linked issue

Go to staging.new.expensify.com
Log in with new Gmail account.
Select Manage my team's expenses.
Proceed to "Do you use any accounting software?" step.
Accounting tiles will show radio style button for single selection list (according to Consistent checkboxes and radio buttons UI #87087).

OSBotify · 2026-10-01T22:48:58Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android

Use the default circle shape for the onboarding accounting radio buttons

45b4822

Co-authored-by: Marco Chávez <marcochavezf@users.noreply.github.com>

MelvinBot assigned marcochavezf Sep 28, 2026

MelvinBot requested a review from a team September 28, 2026 22:41

melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Sep 28, 2026

MelvinBot mentioned this pull request Sep 28, 2026

[Due for payment 2026-10-08] [$175] Onboarding - Accounting tiles use checkbox style button when it does not support multi select #102469

Closed

2 of 7 tasks

marcochavezf marked this pull request as ready for review September 29, 2026 03:12

marcochavezf requested a review from a team as a code owner September 29, 2026 03:12

melvin-bot Bot requested review from mkhutornyi and trjExpensify and removed request for a team September 29, 2026 03:13

melvin-bot Bot removed the request for review from a team September 29, 2026 03:13

This comment has been minimized.

Sign in to view

mkhutornyi approved these changes Sep 29, 2026

View reviewed changes

melvin-bot Bot requested review from marcochavezf and roryabraham September 29, 2026 03:59

mkhutornyi mentioned this pull request Sep 29, 2026

Onboarding: show interested features as tiles with subtext #102566

Merged

43 tasks done

trjExpensify reviewed Sep 29, 2026

View reviewed changes

roryabraham approved these changes Sep 30, 2026

View reviewed changes

roryabraham merged commit e0bb2f3 into main Sep 30, 2026
50 of 53 checks passed

roryabraham deleted the claude-onboardingAccountingRadioShape branch September 30, 2026 07:22

OSBotify mentioned this pull request Sep 30, 2026

Deploy Checklist: New Expensify 2026-09-30 #102701

Closed

70 tasks done

Conversation

MelvinBot commented Sep 28, 2026 • edited by marcochavezf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Sep 29, 2026

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

mkhutornyi commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

mkhutornyi commented Sep 29, 2026

Uh oh!

dubielzyk-expensify commented Sep 29, 2026

Uh oh!

mkhutornyi commented Sep 29, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dylanexpensify commented Sep 29, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

dannymcclain commented Sep 29, 2026

Uh oh!

dubielzyk-expensify commented Sep 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

OSBotify commented Oct 1, 2026

Uh oh!

MelvinBot commented Oct 1, 2026

Uh oh!

kavimuru commented Oct 1, 2026

Uh oh!

mkhutornyi commented Oct 1, 2026

Uh oh!

OSBotify commented Oct 1, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

MelvinBot commented Sep 28, 2026 •

edited by marcochavezf

Loading

MelvinBot commented Sep 28, 2026 •

edited

Loading

MelvinBot commented Sep 28, 2026 •

edited

Loading

mkhutornyi commented Sep 29, 2026 •

edited

Loading

dubielzyk-expensify commented Sep 29, 2026 •

edited

Loading