Skip to content

[No QA] Fix eslint-seatbelt drift from HeaderWithBackButton migration rule - #102689

Merged
luacmartins merged 2 commits into
Expensify:mainfrom
software-mansion-labs:fix/seatbelt-header-migration-drift
Sep 30, 2026
Merged

[No QA] Fix eslint-seatbelt drift from HeaderWithBackButton migration rule#102689
luacmartins merged 2 commits into
Expensify:mainfrom
software-mansion-labs:fix/seatbelt-header-migration-drift

Conversation

@Guccio163

@Guccio163 Guccio163 commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

PR #98601 added a no-restricted-imports restriction on HeaderWithBackButton (migrating to the composed Header). That restriction is counted under the same no-restricted-imports seatbelt bucket as other restricted-import rules, so any file that already had a baselined no-restricted-imports violation for an unrelated reason (isPaidGroupPolicy) now has two violations for that rule, but the seatbelt baseline was never bumped to account for it. One additional file (WorkArrangementPage.tsx) still imports HeaderWithBackButton and was never baselined for it at all.

Both cause npm run lint to fail on main regardless of what a given PR touches, since the lint CI job always lints the whole repo, not just the diff.

This PR only updates config/eslint/eslint.seatbelt.tsv:

  • DynamicTravelUpgrade.tsx, WalletPage/index.tsx, WorkspaceUpgradePage.tsx: bump no-restricted-imports baseline 1 → 2 (the isPaidGroupPolicy usages in these files are genuinely billing-only checks, not the workspace-feature-gating mistake that rule guards against)
  • WorkArrangementPage.tsx: add the missing no-restricted-imports baseline (1) for its still-unmigrated HeaderWithBackButton usage

No source files are modified.

Fixed Issues

$ #102686
PROPOSAL:

Tests

  1. Checkout this branch.
  2. Run npm run lint (or open this PR and watch the lint / ESLint check GitHub Action).
  3. Verify it exits 0, with no errors reported for DynamicTravelUpgrade.tsx, WalletPage/index.tsx, WorkspaceUpgradePage.tsx, or WorkArrangementPage.tsx.
  • Verify that no errors appear in the JS console

Offline tests

N/A — config-only change (config/eslint/eslint.seatbelt.tsv), no runtime behavior affected.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — config-only change, no UI affected.

Android: mWeb Chrome

N/A — config-only change, no UI affected.

iOS: Native

N/A — config-only change, no UI affected.

iOS: mWeb Safari

N/A — config-only change, no UI affected.

MacOS: Chrome / Safari

N/A — config-only change, no UI affected.

@Guccio163
Fix eslint-seatbelt drift from HeaderWithBackButton migration rule
77a9bf1 
PR Expensify#98601 added a no-restricted-imports restriction for
HeaderWithBackButton, but the seatbelt baseline for files that already
had an unrelated no-restricted-imports violation (isPaidGroupPolicy)
was never bumped to account for the new second violation, and one new
file (WorkArrangementPage.tsx) was left unbaselined entirely. Both
break `npm run lint` on main regardless of what a PR touches.

- DynamicTravelUpgrade.tsx, WalletPage/index.tsx,
  WorkspaceUpgradePage.tsx: bump no-restricted-imports baseline 1->2
  (isPaidGroupPolicy usages there are genuinely billing-only checks)
- WorkArrangementPage.tsx: add missing no-restricted-imports baseline
  for its still-unmigrated HeaderWithBackButton usage
@Guccio163
Guccio163 marked this pull request as ready for review September 30, 2026 19:47
@Guccio163
Guccio163 requested a review from a team as a code owner September 30, 2026 19:47
@melvin-bot
melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team September 30, 2026 19:47
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Guccio163

Guccio163 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

cc @luacmartins @mountiny

@MelvinBot MelvinBot mentioned this pull request Sep 30, 2026
Merged
45 tasks
@luacmartins

luacmartins commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@luacmartins
luacmartins merged commit ff3f678 into Expensify:main Sep 30, 2026
19 of 21 checks passed
@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102689.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ff3f678-0ca1693-84df9b6e0c3fbf6eac62e247473dd73e57297dbe/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ff3f678-0ca1693-2a474f54e0d6f87b68f34465adfceee352769222/index.html
Android iOS
Web 🕸️
https://102689.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 30, 2026
Closed
70 tasks done
@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@kavimuru

kavimuru commented Oct 1, 2026

Copy link
Copy Markdown

@Guccio163 can you provide QA steps for Applause QA team?

@Guccio163 Guccio163 changed the title Fix eslint-seatbelt drift from HeaderWithBackButton migration rule [No QA] Fix eslint-seatbelt drift from HeaderWithBackButton migration rule Oct 1, 2026
@Guccio163

Guccio163 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@kavimuru nothing to test here, marking with NoQA

@melvin-bot melvin-bot Bot mentioned this pull request Oct 1, 2026
Closed
@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luacmartins luacmartins luacmartins approved these changes
@abdulrahuman5196 abdulrahuman5196 Awaiting requested review from abdulrahuman5196

Assignees

@Guccio163 Guccio163

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Guccio163 @luacmartins @OSBotify @kavimuru